Re: [PATCH] iio: adc: ad7768-1: Select GPIOLIB

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 12 Jan 2026 09:23:14 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sun, Jan 11, 2026 at 04:55:28PM +0000, Jonathan Cameron wrote:
> 
> Thanks for fixing this, my comment below.
> 
> > This driver provides a gpio chip a some related functions are not
> > stubbed if GPIOLIB is not built.
> > 
> >    hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_get':  
> > >> drivers/iio/adc/ad7768-1.c:420: undefined reference to `gpiochip_get_data'  
> >    hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_set':
> >    drivers/iio/adc/ad7768-1.c:453: undefined reference to `gpiochip_get_data'
> >    hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_init':  
> > >> drivers/iio/adc/ad7768-1.c:498: undefined reference to `devm_gpiochip_add_data_with_key'  
> >    hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_input':
> >    drivers/iio/adc/ad7768-1.c:387: undefined reference to `gpiochip_get_data'
> >    hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_output':
> >    drivers/iio/adc/ad7768-1.c:404: undefined reference to `gpiochip_get_data'  
> 
> We don't need these many strings, the important ones only would be enough, like
> 
>   ad7768-1.c:420: undefined reference to `gpiochip_get_data'
>   ad7768-1.c:498: undefined reference to `devm_gpiochip_add_data_with_key'
> 
> (and also no need to have a full path in this case, we can always read an email
>  from the LKP below).
> 
> > Fixes: ("d569ae0f052e iio: adc: ad7768-1: Add GPIO controller support")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202512271235.WwAmAbOa-lkp@intel.com/
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>  
> 

I'd forgotten about this one until i checked patchwork

Tweaked and applied. With silly situation that it has two different
sign-offs from me, but that correctly reflects the path so I'll leave them.