Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	linux-iio@vger.kernel.org, linux@analog.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad4080: fix AD4880 chip ID
Date: Tue, 2 Jun 2026 13:44:17 +0100	[thread overview]
Message-ID: <20260602134417.5fd78512@jic23-huawei> (raw)
In-Reply-To: <CALoEA-yz-kJGHXDC=Fwmi1C9P_EpEcimxt=9a94vv6eAHQ-TXg@mail.gmail.com>

On Tue, 2 Jun 2026 11:01:24 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Tue, 2 Jun 2026 at 10:52, Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> >
> > The AD4880 chip ID was incorrectly set to 0x0750. According to the
> > datasheet, the product ID registers read 0x00 (PRODUCT_ID_H) and 0x59
> > (PRODUCT_ID_L), giving a combined chip ID of 0x0059. Fix the value to
> > match the actual hardware.
> >
> > Fixes: 35fc53e802bf ("iio: adc: ad4080: add support for AD4880 dual-channel ADC")
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---  
> 
> Sashiko failed to apply your patch, are you developing against
> an old tree?
Other way around. This is only in the iio tree and sashiko seems to 
use either mainline or next, I haven't figured out which.


> 
> Codewise LGTM.
> 
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
> 

Applied but I dropped the fixes tag because it causes pain for me to have
references within my tree near merge windows and it will all be in the same
pull request anyway.  Note it had changed because I had to do some surgery
on the tree a few days ago.

  reply	other threads:[~2026-06-02 12:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  8:40 [PATCH] iio: adc: ad4080: fix AD4880 chip ID Antoniu Miclaus
2026-06-02  9:01 ` Joshua Crofts
2026-06-02 12:44   ` Jonathan Cameron [this message]
2026-06-02 14:02     ` Joshua Crofts
2026-06-02 14:25       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260602134417.5fd78512@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=antoniu.miclaus@analog.com \
    --cc=dlechner@baylibre.com \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox