[PATCH] iio: adc: ad4080: fix AD4880 chip ID

[PATCH] iio: adc: ad4080: fix AD4880 chip ID

[Antoniu Miclaus]

The AD4880 chip ID was incorrectly set to 0x0750. According to the
datasheet, the product ID registers read 0x00 (PRODUCT_ID_H) and 0x59
(PRODUCT_ID_L), giving a combined chip ID of 0x0059. Fix the value to
match the actual hardware.

Fixes: 35fc53e802bf ("iio: adc: ad4080: add support for AD4880 dual-channel ADC")
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/adc/ad4080.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
index 764d49eca9e0..8d2953341b15 100644
--- a/drivers/iio/adc/ad4080.c
+++ b/drivers/iio/adc/ad4080.c
@@ -135,7 +135,7 @@
 #define AD4086_CHIP_ID						0x0056
 #define AD4087_CHIP_ID						0x0057
 #define AD4088_CHIP_ID						0x0058
-#define AD4880_CHIP_ID						0x0750
+#define AD4880_CHIP_ID						0x0059
 #define AD4884_CHIP_ID						0x005C
 
 #define AD4080_MAX_CHANNELS					2
-- 
2.43.0

Re: [PATCH] iio: adc: ad4080: fix AD4880 chip ID

[Joshua Crofts]

On Tue, 2 Jun 2026 at 10:52, Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
>
> The AD4880 chip ID was incorrectly set to 0x0750. According to the
> datasheet, the product ID registers read 0x00 (PRODUCT_ID_H) and 0x59
> (PRODUCT_ID_L), giving a combined chip ID of 0x0059. Fix the value to
> match the actual hardware.
>
> Fixes: 35fc53e802bf ("iio: adc: ad4080: add support for AD4880 dual-channel ADC")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---

Sashiko failed to apply your patch, are you developing against
an old tree?

Codewise LGTM.

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

-- 
Kind regards

CJD

Re: [PATCH] iio: adc: ad4080: fix AD4880 chip ID

[Jonathan Cameron]

On Tue, 2 Jun 2026 11:01:24 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Tue, 2 Jun 2026 at 10:52, Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> >
> > The AD4880 chip ID was incorrectly set to 0x0750. According to the
> > datasheet, the product ID registers read 0x00 (PRODUCT_ID_H) and 0x59
> > (PRODUCT_ID_L), giving a combined chip ID of 0x0059. Fix the value to
> > match the actual hardware.
> >
> > Fixes: 35fc53e802bf ("iio: adc: ad4080: add support for AD4880 dual-channel ADC")
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---  
> 
> Sashiko failed to apply your patch, are you developing against
> an old tree?
Other way around. This is only in the iio tree and sashiko seems to 
use either mainline or next, I haven't figured out which.


> 
> Codewise LGTM.
> 
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
> 

Applied but I dropped the fixes tag because it causes pain for me to have
references within my tree near merge windows and it will all be in the same
pull request anyway.  Note it had changed because I had to do some surgery
on the tree a few days ago.

Re: [PATCH] iio: adc: ad4080: fix AD4880 chip ID

[Joshua Crofts]

On Tue, 2 Jun 2026 at 14:44, Jonathan Cameron <jic23@kernel.org> wrote:
> Applied but I dropped the fixes tag because it causes pain for me to have
> references within my tree near merge windows and it will all be in the same
> pull request anyway.  Note it had changed because I had to do some surgery
> on the tree a few days ago.

Hey Jonathan,

Just letting you know that your Signed-off-by tag is missing in the commit
in the togreg branch.

-- 
Kind regards

CJD

Re: [PATCH] iio: adc: ad4080: fix AD4880 chip ID

[Jonathan Cameron]

On Tue, 2 Jun 2026 16:02:48 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Tue, 2 Jun 2026 at 14:44, Jonathan Cameron <jic23@kernel.org> wrote:
> > Applied but I dropped the fixes tag because it causes pain for me to have
> > references within my tree near merge windows and it will all be in the same
> > pull request anyway.  Note it had changed because I had to do some surgery
> > on the tree a few days ago.  
> 
> Hey Jonathan,
> 
> Just letting you know that your Signed-off-by tag is missing in the commit
> in the togreg branch.
> 

Thanks. Fat fingered it.

Fixed up.