[PATCH] iio: core-trigger: correct CONFIG_IIO_TRIGGER macro name in #endif comment

[PATCH] iio: core-trigger: correct CONFIG_IIO_TRIGGER macro name in #endif comment

[Ethan Nelson-Moore]

A comment in drivers/iio/iio_core_trigger.h incorrectly refers to
CONFIG_TRIGGER_CONSUMER instead of CONFIG_IIO_TRIGGER. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.

Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
 drivers/iio/iio_core_trigger.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/iio_core_trigger.h b/drivers/iio/iio_core_trigger.h
index e1a56824e07f..4698a857739f 100644
--- a/drivers/iio/iio_core_trigger.h
+++ b/drivers/iio/iio_core_trigger.h
@@ -56,4 +56,4 @@ static inline int iio_trigger_detach_poll_func(struct iio_trigger *trig,
 	return 0;
 }
 
-#endif /* CONFIG_TRIGGER_CONSUMER */
+#endif /* CONFIG_IIO_TRIGGER */
-- 
2.43.0

Re: [PATCH] iio: core-trigger: correct CONFIG_IIO_TRIGGER macro name in #endif comment

[Joshua Crofts]

On Tue,  9 Jun 2026 21:05:01 -0700
Ethan Nelson-Moore <enelsonmoore@gmail.com> wrote:

> A comment in drivers/iio/iio_core_trigger.h incorrectly refers to
> CONFIG_TRIGGER_CONSUMER instead of CONFIG_IIO_TRIGGER. Correct it.
> 
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
> 
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

-- 
Kind regards

CJD

Re: [PATCH] iio: core-trigger: correct CONFIG_IIO_TRIGGER macro name in #endif comment

[Andy Shevchenko]

On Tue, Jun 09, 2026 at 09:05:01PM -0700, Ethan Nelson-Moore wrote:
> A comment in drivers/iio/iio_core_trigger.h incorrectly refers to
> CONFIG_TRIGGER_CONSUMER instead of CONFIG_IIO_TRIGGER. Correct it.
> 
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.

(Btw, did you do that manually or using some scripts?)

Wow! This line is from 2009

  commit 1637db44413e32a0f100dd4bd164644e641842f7
  Author: Jonathan Cameron <jic23@cam.ac.uk>
  Date:   Tue Aug 18 18:06:26 2009 +0100

    Staging: IIO: Trigger support added to core.

and that time it might have been correct one, dunno. In any case your change is
correct. The new header split was done in

  commit a980e046098b0a40eaff5e4e7fcde6cf035b7c06
  Author: Jonathan Cameron <jic23@kernel.org>
  Date:   Wed Apr 25 15:54:59 2012 +0100

    IIO: Move the core files to drivers/iio

and kept till now.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: core-trigger: correct CONFIG_IIO_TRIGGER macro name in #endif comment

[Joshua Crofts]

On Wed, 10 Jun 2026 16:41:54 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Tue, Jun 09, 2026 at 09:05:01PM -0700, Ethan Nelson-Moore wrote:
> > A comment in drivers/iio/iio_core_trigger.h incorrectly refers to
> > CONFIG_TRIGGER_CONSUMER instead of CONFIG_IIO_TRIGGER. Correct it.
> > 
> > Discovered while searching for CONFIG_* symbols referenced in code
> > but not defined in any Kconfig file.  
> 
> (Btw, did you do that manually or using some scripts?)
> 
> Wow! This line is from 2009
 
Perhaps there should be an award for finding issues this old :)

-- 
Kind regards

CJD

Re: [PATCH] iio: core-trigger: correct CONFIG_IIO_TRIGGER macro name in #endif comment

[Jonathan Cameron]

On Wed, 10 Jun 2026 15:59:21 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Wed, 10 Jun 2026 16:41:54 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> 
> > On Tue, Jun 09, 2026 at 09:05:01PM -0700, Ethan Nelson-Moore wrote:  
> > > A comment in drivers/iio/iio_core_trigger.h incorrectly refers to
> > > CONFIG_TRIGGER_CONSUMER instead of CONFIG_IIO_TRIGGER. Correct it.
> > > 
> > > Discovered while searching for CONFIG_* symbols referenced in code
> > > but not defined in any Kconfig file.    
> > 
> > (Btw, did you do that manually or using some scripts?)
> > 
> > Wow! This line is from 2009  
>  
> Perhaps there should be an award for finding issues this old :)

Plenty of those out there I suspect :(
Younger me didn't write particularly good code!

Applied.

Thanks,

Jonathan

Re: [PATCH] iio: core-trigger: correct CONFIG_IIO_TRIGGER macro name in #endif comment

[Ethan Nelson-Moore]

Hi, Andy and Joshua,

On Wed, Jun 10, 2026 at 6:59 AM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
>
> On Wed, 10 Jun 2026 16:41:54 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > (Btw, did you do that manually or using some scripts?)

I used a script I am writing. It attempts to filter out enums,
changelog entries, and example/dummy values, which makes the list
significantly shorter, although it does so by committing the cardinal
sin of parsing C using grep :). It also has an easily editable list of
known false positives. Once I reduce the rate of false positives to an
acceptable level (I notably need to exclude typedefs), I will post the
script on GitHub.

> > Wow! This line is from 2009
>
> Perhaps there should be an award for finding issues this old :)

You're welcome! :p

Ethan

Re: [PATCH] iio: core-trigger: correct CONFIG_IIO_TRIGGER macro name in #endif comment

[Andy Shevchenko]

On Wed, Jun 10, 2026 at 12:18:34PM -0700, Ethan Nelson-Moore wrote:
> On Wed, Jun 10, 2026 at 6:59 AM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> > On Wed, 10 Jun 2026 16:41:54 +0300
> > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > > (Btw, did you do that manually or using some scripts?)
> 
> I used a script I am writing. It attempts to filter out enums,
> changelog entries, and example/dummy values, which makes the list
> significantly shorter, although it does so by committing the cardinal
> sin of parsing C using grep :). It also has an easily editable list of
> known false positives. Once I reduce the rate of false positives to an
> acceptable level (I notably need to exclude typedefs), I will post the
> script on GitHub.

Okay. When modifying C code (not text or comments), consider using coccinelle.

-- 
With Best Regards,
Andy Shevchenko