From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Miao Li <limiao870622@163.com>
Cc: jic23@kernel.org, andy@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, dixitparmar19@gmail.com,
bigeasy@linutronix.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, Miao Li <limiao@kylinos.cn>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v3] iio: accel: stk8ba50: Update includes to match IWYU
Date: Fri, 19 Jun 2026 09:27:31 +0200 [thread overview]
Message-ID: <20260619092731.0000090f@gmail.com> (raw)
In-Reply-To: <20260617013834.166337-1-limiao870622@163.com>
On Wed, 17 Jun 2026 09:38:34 +0800
Miao Li <limiao870622@163.com> wrote:
> +#include <linux/array_size.h>
> +#include <linux/bits.h>
> +#include <linux/dev_printk.h>
> +#include <linux/errno.h>
> #include <linux/i2c.h>
> #include <linux/interrupt.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/mod_devicetable.h>
> +#include <linux/mutex.h>
> +#include <linux/pm.h>
> +#include <linux/sysfs.h>
> #include <linux/types.h>
> +
> #include <linux/iio/buffer.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
The driver uses sign_extend32(), which is included in <linux/bitops.h>.
Consider removing bits.h and adding bitops.h instead.
--
Kind regards
CJD
next prev parent reply other threads:[~2026-06-19 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 1:38 [PATCH v3] iio: accel: stk8ba50: Update includes to match IWYU Miao Li
2026-06-19 7:27 ` Joshua Crofts [this message]
2026-06-19 9:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619092731.0000090f@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=limiao870622@163.com \
--cc=limiao@kylinos.cn \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox