[PATCH v3] iio: accel: stk8ba50: Update includes to match IWYU

[PATCH v3] iio: accel: stk8ba50: Update includes to match IWYU

[Miao Li]

From: Miao Li <limiao@kylinos.cn>

Update the list of included headers in stk8ba50.c using
Include-What-You-Use (IWYU) tool, mainly to remove kernel.h
and add missing headers such as array_size.h, bits.h,
dev_printk.h, etc.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Miao Li <limiao@kylinos.cn>
---

Changes in v3:
- Put the changelog after cutter line, no functional changes.
- Link to v2:
  https://lore.kernel.org/all/20260615092116.83850-1-limiao870622@163.com/

Changes in v2:
- Drop linux/iio/types.h as it is already included by linux/iio/iio.h
- Link to v1:
  https://lore.kernel.org/all/20260603015033.187735-1-limiao870622@163.com/

 drivers/iio/accel/stk8ba50.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/accel/stk8ba50.c b/drivers/iio/accel/stk8ba50.c
index a9ff2a273fe1..6a60c0fcebe9 100644
--- a/drivers/iio/accel/stk8ba50.c
+++ b/drivers/iio/accel/stk8ba50.c
@@ -7,12 +7,19 @@
  * STK8BA50 7-bit I2C address: 0x18.
  */
 
+#include <linux/array_size.h>
+#include <linux/bits.h>
+#include <linux/dev_printk.h>
+#include <linux/errno.h>
 #include <linux/i2c.h>
 #include <linux/interrupt.h>
-#include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
+#include <linux/mutex.h>
+#include <linux/pm.h>
+#include <linux/sysfs.h>
 #include <linux/types.h>
+
 #include <linux/iio/buffer.h>
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
-- 
2.25.1

Re: [PATCH v3] iio: accel: stk8ba50: Update includes to match IWYU

[Joshua Crofts]

On Wed, 17 Jun 2026 09:38:34 +0800
Miao Li <limiao870622@163.com> wrote:

> +#include <linux/array_size.h>
> +#include <linux/bits.h>
> +#include <linux/dev_printk.h>
> +#include <linux/errno.h>
>  #include <linux/i2c.h>
>  #include <linux/interrupt.h>
> -#include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/mod_devicetable.h>
> +#include <linux/mutex.h>
> +#include <linux/pm.h>
> +#include <linux/sysfs.h>
>  #include <linux/types.h>
> +
>  #include <linux/iio/buffer.h>
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>

The driver uses sign_extend32(), which is included in <linux/bitops.h>.
Consider removing bits.h and adding bitops.h instead.

-- 
Kind regards

CJD

Re: [PATCH v3] iio: accel: stk8ba50: Update includes to match IWYU

[Andy Shevchenko]

On Fri, Jun 19, 2026 at 09:27:31AM +0200, Joshua Crofts wrote:
> On Wed, 17 Jun 2026 09:38:34 +0800
> Miao Li <limiao870622@163.com> wrote:

...

> The driver uses sign_extend32(), which is included in <linux/bitops.h>.
> Consider removing bits.h and adding bitops.h instead.

Good catch!

-- 
With Best Regards,
Andy Shevchenko