From: Jonathan Cameron <jic23@kernel.org>
To: "Prashant Rahul" <prashantrahul23@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
linux-iio@vger.kernel.org, "Shuah Khan" <shuahkhan@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Petr Mladek" <pmladek@suse.com>,
"Oleg Nesterov" <oleg@redhat.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Dixit Parmar" <dixitparmar19@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-adc*: use dev_err_probe for probe time errors
Date: Tue, 23 Jun 2026 20:31:37 +0100 [thread overview]
Message-ID: <20260623203137.7c4aae1e@jic23-huawei> (raw)
In-Reply-To: <DJCBXHCM2VTQ.1DBAHMPJHA9HP@gmail.com>
On Thu, 18 Jun 2026 22:22:15 +0530
"Prashant Rahul" <prashantrahul23@gmail.com> wrote:
> On Tue Jun 16, 2026 at 7:33 PM IST, David Lechner wrote:
> > Please make one patch per file.
>
> will do
>
> > Please don't add new error messages. If there is a really good
> > reason to, please do that in a separate patch with a justification
> > as to why it is needed.
> > In this particular case, the only error is -ENOMEM, which we never
> > have an error message for.
>
> I understand. I will remove the additional logs, except the ones after
> `devm_iio_triggered_buffer_setup` for -ENOMEM.
This jumped out at me. We very rarely do special prints for anything
that returns -ENOMEM as that tends to be very noisy on the rare occasion
it happens. Note that dev_err_probe() doesn't print anything in this
case.
J
next prev parent reply other threads:[~2026-06-23 19:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 13:05 [PATCH] iio: adc: ti-adc*: use dev_err_probe for probe time errors Prashant Rahul
2026-06-16 14:03 ` David Lechner
2026-06-18 16:52 ` Prashant Rahul
2026-06-23 19:31 ` Jonathan Cameron [this message]
2026-06-23 19:51 ` Andy Shevchenko
2026-06-18 23:14 ` [PATCH 0/5] use dev_err_probe for probe time error Prashant Rahul
2026-06-18 23:14 ` [PATCH 1/5] iio: adc: ti-adc081c: " Prashant Rahul
2026-07-03 0:32 ` Jonathan Cameron
2026-06-18 23:14 ` [PATCH 2/5] iio: adc: ti-adc084s021: " Prashant Rahul
2026-06-19 14:49 ` David Lechner
2026-07-03 0:35 ` Jonathan Cameron
2026-06-18 23:14 ` [PATCH 3/5] iio: adc: ti-adc108s102: log buffer setup failure in probe Prashant Rahul
2026-07-03 0:36 ` Jonathan Cameron
2026-06-18 23:14 ` [PATCH 4/5] iio: adc: ti-adc161s626: " Prashant Rahul
2026-06-18 23:14 ` [PATCH 5/5] iio: adc: ti-adc0832: " Prashant Rahul
2026-06-19 14:48 ` [PATCH 0/5] use dev_err_probe for probe time error David Lechner
2026-06-20 17:39 ` Prashant Rahul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260623203137.7c4aae1e@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=john.ogness@linutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=oleg@redhat.com \
--cc=pmladek@suse.com \
--cc=prashantrahul23@gmail.com \
--cc=shuahkhan@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox