Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Prashant Rahul <prashantrahul23@gmail.com>
Cc: linux-iio@vger.kernel.org, "Shuah Khan" <shuahkhan@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Petr Mladek" <pmladek@suse.com>,
	"Oleg Nesterov" <oleg@redhat.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"John Ogness" <john.ogness@linutronix.de>,
	linux-kernel@vger.kernel.or
Subject: Re: [PATCH 3/5] iio: adc: ti-adc108s102: log buffer setup failure in probe
Date: Fri, 3 Jul 2026 01:36:59 +0100	[thread overview]
Message-ID: <20260703013659.12315007@jic23-huawei> (raw)
In-Reply-To: <20260618231543.413771-4-prashantrahul23@gmail.com>

On Fri, 19 Jun 2026 04:44:36 +0530
Prashant Rahul <prashantrahul23@gmail.com> wrote:

> Errors are logged when enabling the regulator or adding the cleanup
> action fails, but not when buffer setup fails. Log the error returned by
> the buffer setup path as well.
> 
> Signed-off-by: Prashant Rahul <prashantrahul23@gmail.com>
I'm not going to add more prints to these. So won't pick up rest of
the series.

Thanks,

Jonathan


> ---
>  drivers/iio/adc/ti-adc108s102.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ti-adc108s102.c b/drivers/iio/adc/ti-adc108s102.c
> index 7d615e2bbf39..440afe584f5d 100644
> --- a/drivers/iio/adc/ti-adc108s102.c
> +++ b/drivers/iio/adc/ti-adc108s102.c
> @@ -256,7 +256,7 @@ static int adc108s102_probe(struct spi_device *spi)
>  					      &adc108s102_trigger_handler,
>  					      NULL);
>  	if (ret)
> -		return ret;
> +		return dev_err_probe(&spi->dev, ret, "iio triggered buffer setup failed\n");
>  
>  	ret = devm_iio_device_register(&spi->dev, indio_dev);
>  	if (ret)


  reply	other threads:[~2026-07-03  0:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16 13:05 [PATCH] iio: adc: ti-adc*: use dev_err_probe for probe time errors Prashant Rahul
2026-06-16 14:03 ` David Lechner
2026-06-18 16:52   ` Prashant Rahul
2026-06-23 19:31     ` Jonathan Cameron
2026-06-23 19:51       ` Andy Shevchenko
2026-06-18 23:14 ` [PATCH 0/5] use dev_err_probe for probe time error Prashant Rahul
2026-06-18 23:14   ` [PATCH 1/5] iio: adc: ti-adc081c: " Prashant Rahul
2026-07-03  0:32     ` Jonathan Cameron
2026-06-18 23:14   ` [PATCH 2/5] iio: adc: ti-adc084s021: " Prashant Rahul
2026-06-19 14:49     ` David Lechner
2026-07-03  0:35       ` Jonathan Cameron
2026-06-18 23:14   ` [PATCH 3/5] iio: adc: ti-adc108s102: log buffer setup failure in probe Prashant Rahul
2026-07-03  0:36     ` Jonathan Cameron [this message]
2026-06-18 23:14   ` [PATCH 4/5] iio: adc: ti-adc161s626: " Prashant Rahul
2026-06-18 23:14   ` [PATCH 5/5] iio: adc: ti-adc0832: " Prashant Rahul
2026-06-19 14:48   ` [PATCH 0/5] use dev_err_probe for probe time error David Lechner
2026-06-20 17:39     ` Prashant Rahul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260703013659.12315007@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=dlechner@baylibre.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.or \
    --cc=nuno.sa@analog.com \
    --cc=oleg@redhat.com \
    --cc=pmladek@suse.com \
    --cc=prashantrahul23@gmail.com \
    --cc=shuahkhan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox