[PATCH 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[PATCH 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Joshua Crofts]

This series adds REGMAP_I2C support to three AL3xxx ambient light
sensors that were previously missing this dependency, causing build
failures.

I made a separate commit for each driver, to ensure a proper Fixes:
tag is appended for easy backporting. Let me know if you prefer
squashing!

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
Joshua Crofts (3):
      iio: light: al3000a: add missing REGMAP_I2C to Kconfig
      iio: light: al3010: add missing REGMAP_I2C to Kconfig
      iio: light: al3320a: add missing REGMAP_I2C to Kconfig

 drivers/iio/light/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
---
base-commit: 7667a80340e99fd45357d0c90ae05813b01bbfef
change-id: 20260625-fix-al3xxx-kconfig-ddb1f00a2615

Best regards,
-- 
Kind regards

CJD

[PATCH 1/3] iio: light: al3000a: add missing REGMAP_I2C to Kconfig

[Joshua Crofts]

The KConfig entry for the al3000a is missing a `SELECT REGMAP_I2C`,
causing build failures.

Fixes: d531b9f78949 ("iio: light: Add support for AL3000a illuminance sensor")
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/light/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
index ef36824f312f..a33920568904 100644
--- a/drivers/iio/light/Kconfig
+++ b/drivers/iio/light/Kconfig
@@ -45,6 +45,7 @@ config ADUX1020
 
 config AL3000A
 	tristate "AL3000a ambient light sensor"
+	select REGMAP_I2C
 	depends on I2C
 	help
 	  Say Y here if you want to build a driver for the Dyna Image AL3000a

-- 
2.54.0

[PATCH 2/3] iio: light: al3010: add missing REGMAP_I2C to Kconfig

[Joshua Crofts]

The KConfig entry for the AL3010 is missing a `SELECT REGMAP_I2C`,
causing build failures.

Fixes: 0e5e21e23dd6 ("iio: light: al3010: Implement regmap support")
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/light/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
index a33920568904..4ba3151ebea7 100644
--- a/drivers/iio/light/Kconfig
+++ b/drivers/iio/light/Kconfig
@@ -56,6 +56,7 @@ config AL3000A
 
 config AL3010
 	tristate "AL3010 ambient light sensor"
+	select REGMAP_I2C
 	depends on I2C
 	help
 	  Say Y here if you want to build a driver for the Dyna Image AL3010

-- 
2.54.0

[PATCH 3/3] iio: light: al3320a: add missing REGMAP_I2C to Kconfig

[Joshua Crofts]

The Kconfig entry for the al3320a is missing a `SELECT REGMAP_I2C`,
causing build failures.

Fixes: 1850e6ae7f91 ("iio: light: al3320a: Implement regmap support")
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/light/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
index 4ba3151ebea7..f23bbce12c72 100644
--- a/drivers/iio/light/Kconfig
+++ b/drivers/iio/light/Kconfig
@@ -67,6 +67,7 @@ config AL3010
 
 config AL3320A
 	tristate "AL3320A ambient light sensor"
+	select REGMAP_I2C
 	depends on I2C
 	help
 	  Say Y here if you want to build a driver for the Dyna Image AL3320A

-- 
2.54.0

Re: [PATCH 1/3] iio: light: al3000a: add missing REGMAP_I2C to Kconfig

[Andy Shevchenko]

On Thu, Jun 25, 2026 at 07:20:43AM +0200, Joshua Crofts wrote:
> The KConfig entry for the al3000a is missing a `SELECT REGMAP_I2C`,

SELECT is not a SQL term here, but Kconfig, hence small letters only.

> causing build failures.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Andy Shevchenko]

On Thu, Jun 25, 2026 at 07:20:42AM +0200, Joshua Crofts wrote:
> This series adds REGMAP_I2C support to three AL3xxx ambient light
> sensors that were previously missing this dependency, causing build
> failures.

There are two problems with the commit message:
- SELECT versus select (see the comment against patch 1)
- you mentioned build failures but haven't provided any evidence, please
provide a reasonable lines of build output to prove that

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/3] iio: light: al3000a: add missing REGMAP_I2C to Kconfig

[Joshua Crofts]

On Thu, 25 Jun 2026 09:39:47 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Jun 25, 2026 at 07:20:43AM +0200, Joshua Crofts wrote:
> > The KConfig entry for the al3000a is missing a `SELECT REGMAP_I2C`,  
> 
> SELECT is not a SQL term here, but Kconfig, hence small letters only.
> 
> > causing build failures.  
> 

Haha, good point. Will fix.

-- 
Kind regards

CJD

Re: [PATCH 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Joshua Crofts]

On Thu, 25 Jun 2026 09:41:31 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Jun 25, 2026 at 07:20:42AM +0200, Joshua Crofts wrote:
> > This series adds REGMAP_I2C support to three AL3xxx ambient light
> > sensors that were previously missing this dependency, causing build
> > failures.  
> 
> There are two problems with the commit message:
> - SELECT versus select (see the comment against patch 1)
> - you mentioned build failures but haven't provided any evidence, please
> provide a reasonable lines of build output to prove that
> 

Sure, I could elaborate a bit more.

Just run `make allnoconfig` and `make menuconfig` in which you select
IIO, I2C and any AL3xxx sensor and `make .` will fail with errors such as

drivers/iio/light/al3010.c: In function ‘al3010_probe’:
drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
  185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
      |                        ^~~~~~~~~~~~~~~~~~~~
drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
      |                      ^
drivers/iio/light/al3010.c: At top level:
drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
   48 | static const struct regmap_config al3010_regmap_config = {
      |                                   ^~~~~~~~~~~~~~~~~~~~

Hopefully this is enough.

-- 
Kind regards

CJD

Re: [PATCH 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Andy Shevchenko]

On Thu, Jun 25, 2026 at 08:53:29AM +0200, Joshua Crofts wrote:
> On Thu, 25 Jun 2026 09:41:31 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > On Thu, Jun 25, 2026 at 07:20:42AM +0200, Joshua Crofts wrote:
> > > This series adds REGMAP_I2C support to three AL3xxx ambient light
> > > sensors that were previously missing this dependency, causing build
> > > failures.  
> > 
> > There are two problems with the commit message:
> > - SELECT versus select (see the comment against patch 1)
> > - you mentioned build failures but haven't provided any evidence, please
> > provide a reasonable lines of build output to prove that

> Sure, I could elaborate a bit more.
> 
> Just run `make allnoconfig` and `make menuconfig` in which you select
> IIO, I2C and any AL3xxx sensor and `make .` will fail with errors such as
> 
> drivers/iio/light/al3010.c: In function ‘al3010_probe’:
> drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
>   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
>       |                        ^~~~~~~~~~~~~~~~~~~~
> drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
>       |                      ^
> drivers/iio/light/al3010.c: At top level:
> drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
>    48 | static const struct regmap_config al3010_regmap_config = {
>       |                                   ^~~~~~~~~~~~~~~~~~~~
> 
> Hopefully this is enough.

Yes, put it into the cover letter of the v2.

-- 
With Best Regards,
Andy Shevchenko