Linux IIO development
 help / color / mirror / Atom feed
* [PATCH] iio: dac: mcp47feb02: add missing 'select REGMAP_I2C' to Kconfig
@ 2026-07-08 19:50 Joshua Crofts
  0 siblings, 0 replies; only message in thread
From: Joshua Crofts @ 2026-07-08 19:50 UTC (permalink / raw)
  To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
	Ariana Lazar
  Cc: linux-iio, linux-kernel, Jonathan Cameron, stable, Joshua Crofts

The Kconfig entry for the MCP47FEB02 is missing a 'select REGMAP_I2C',
causing build failures.

Fixes: bf394cc80369 ("iio: dac: adding support for Microchip MCP47FEB02")
Cc: stable@vger.kernel.org
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
This patch adds a missing 'select REGMAP_I2C' to the MCP47FEB02 Kconfig
entry. Without this, some builds may result in a failure.

Steps to reproduce build failure:
1. Run `make allnoconfig`.
2. Run `make menuconfig` and select I2C, IIO and the MCP47FEB02 driver.
3. Run `make .` and make will end with regmap-related errors.

An excerpt of the errors produced during the above build:
drivers/iio/dac/mcp47feb02.c: In function ‘mcp47feb02_probe’:
drivers/iio/dac/mcp47feb02.c:1114:32: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
 1114 |                 data->regmap = devm_regmap_init_i2c(client, &mcp47feb02_regmap_config);
      |                                ^~~~~~~~~~~~~~~~~~~~
drivers/iio/dac/mcp47feb02.c:1114:30: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
 1114 |                 data->regmap = devm_regmap_init_i2c(client, &mcp47feb02_regmap_config);
      |                              ^
---
 drivers/iio/dac/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index 657c68e75542..14a246729d2b 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -552,6 +552,7 @@ config MCP4728
 config MCP47FEB02
 	tristate "MCP47F(E/V)B01/02/04/08/11/12/14/18/21/22/24/28 DAC driver"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  Say yes here if you want to build the driver for the Microchip:
 	  - 8-bit DAC:

---
base-commit: fef4337eb2888c758c7058e1723903204f012a26
change-id: 20260708-add-missing-regmap-dac-abcf866aac1f

Best regards,
-- 
Kind regards

CJD


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-08 19:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-08 19:50 [PATCH] iio: dac: mcp47feb02: add missing 'select REGMAP_I2C' to Kconfig Joshua Crofts

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox