[PATCH 0/3] iio: adc: add missing 'select REGMAP' to Kconfig

[PATCH 0/3] iio: adc: add missing 'select REGMAP' to Kconfig

[Joshua Crofts]

This series adds missing `select REGMAP` and `select REGMAP_I2C` to the
AD7380/MAX34408/MAX14001 Kconfig entries. Without these, some builds
may result in a failure.

Steps to reproduce build failure:
1. Run `make allnoconfig`.
2. Run `make menuconfig` and select I2C/SPI, IIO and any of said drivers.
3. Run `make .` and make will end with regmap-related errors.

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
Joshua Crofts (3):
      iio: adc: ad7380: add missing 'select REGMAP' to Kconfig
      iio: adc: max34408: add missing 'select REGMAP_I2C' to Kconfig
      iio: adc: max14001: add missing 'select REGMAP' to Kconfig

 drivers/iio/adc/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
---
base-commit: 093239070573637ad2b4cb56abc9c4c7ee109294
change-id: 20260707-add-missing-regmap-b6c199a5cf6f

Best regards,
-- 
Kind regards

CJD

[PATCH 1/3] iio: adc: ad7380: add missing 'select REGMAP' to Kconfig

[Joshua Crofts]

The Kconfig entry for the AD7380 is missing a 'select REGMAP'
parameter, causing build failures.

Fixes: b095217c104b ("iio: adc: ad7380: new driver for AD7380 ADCs")
Cc: <stable@vger.kernel.org>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index d1b198cb8a80..6d1170bc4c7c 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -330,6 +330,7 @@ config AD7380
 	tristate "Analog Devices AD7380 ADC driver"
 	depends on SPI_MASTER
 	select SPI_OFFLOAD
+	select REGMAP
 	select IIO_BUFFER
 	select IIO_BUFFER_DMAENGINE
 	select IIO_TRIGGER

-- 
2.54.0

Re: [PATCH 1/3] iio: adc: ad7380: add missing 'select REGMAP' to Kconfig

[David Lechner]

On 7/8/26 12:34 AM, Joshua Crofts wrote:
> The Kconfig entry for the AD7380 is missing a 'select REGMAP'
> parameter, causing build failures.

This one has already been fixed.

https://lore.kernel.org/linux-iio/20260603134955.2f1d5ede@jic23-huawei/

Suggest to use linux-next for development so you get both the fixes-togreg
branch and the regular togreg branch.

> 
> Fixes: b095217c104b ("iio: adc: ad7380: new driver for AD7380 ADCs")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index d1b198cb8a80..6d1170bc4c7c 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -330,6 +330,7 @@ config AD7380
>  	tristate "Analog Devices AD7380 ADC driver"
>  	depends on SPI_MASTER
>  	select SPI_OFFLOAD
> +	select REGMAP
>  	select IIO_BUFFER
>  	select IIO_BUFFER_DMAENGINE
>  	select IIO_TRIGGER
> 

Re: [PATCH 1/3] iio: adc: ad7380: add missing 'select REGMAP' to Kconfig

[Joshua Crofts]

On Wed, 8 Jul 2026 09:32:24 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 7/8/26 12:34 AM, Joshua Crofts wrote:
> > The Kconfig entry for the AD7380 is missing a 'select REGMAP'
> > parameter, causing build failures.  
> 
> This one has already been fixed.
> 
> https://lore.kernel.org/linux-iio/20260603134955.2f1d5ede@jic23-huawei/
> 
> Suggest to use linux-next for development so you get both the fixes-togreg
> branch and the regular togreg branch.

Ugh, my bad, I only use the testing branch in the IIO tree.

Thanks

-- 
Kind regards

CJD

[PATCH 2/3] iio: adc: max34408: add missing 'select REGMAP_I2C' to Kconfig

[Joshua Crofts]

The Kconfig entry for the MAX34408 is missing a 'select REGMAP_I2C',
causing build failures.

Fixes: cf27775838c5 ("iio: adc: Add driver support for MAX34408/9")
Cc: <stable@vger.kernel.org>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 6d1170bc4c7c..01e48d6701ee 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -1085,6 +1085,7 @@ config MAX14001
 config MAX34408
 	tristate "Maxim max34408/max344089 ADC driver"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  Say yes here to build support for Maxim max34408/max34409 current sense
 	  monitor with 8-bits ADC interface with overcurrent delay/threshold and

-- 
2.54.0

[PATCH 3/3] iio: adc: max14001: add missing 'select REGMAP' to Kconfig

[Joshua Crofts]

The Kconfig entry for the MAX14001 is missing a 'select REGMAP',
causing build failures.

Fixes: 59795109fa67 ("iio: adc: max14001: New driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 01e48d6701ee..91a39860c676 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -1075,6 +1075,7 @@ config MAX1363
 config MAX14001
 	tristate "Analog Devices MAX14001/MAX14002 ADC driver"
 	depends on SPI
+	select REGMAP
 	help
 	  Say yes here to build support for Analog Devices MAX14001/MAX14002
 	  Configurable, Isolated 10-bit ADCs for Multi-Range Binary Inputs.

-- 
2.54.0

Re: [PATCH 0/3] iio: adc: add missing 'select REGMAP' to Kconfig

[Andy Shevchenko]

On Wed, Jul 08, 2026 at 07:34:11AM +0200, Joshua Crofts wrote:
> This series adds missing `select REGMAP` and `select REGMAP_I2C` to the
> AD7380/MAX34408/MAX14001 Kconfig entries. Without these, some builds
> may result in a failure.

> Steps to reproduce build failure:
> 1. Run `make allnoconfig`.
> 2. Run `make menuconfig` and select I2C/SPI, IIO and any of said drivers.
> 3. Run `make .` and make will end with regmap-related errors.

Repeating same mistake from the previous similar contribution. Where is the
actual excerpt of the failure? Please, provide one.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/3] iio: adc: add missing 'select REGMAP' to Kconfig

[Joshua Crofts]

On Wed, 8 Jul 2026 10:47:48 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Wed, Jul 08, 2026 at 07:34:11AM +0200, Joshua Crofts wrote:
> > This series adds missing `select REGMAP` and `select REGMAP_I2C` to the
> > AD7380/MAX34408/MAX14001 Kconfig entries. Without these, some builds
> > may result in a failure.  
> 
> > Steps to reproduce build failure:
> > 1. Run `make allnoconfig`.
> > 2. Run `make menuconfig` and select I2C/SPI, IIO and any of said drivers.
> > 3. Run `make .` and make will end with regmap-related errors.  
> 
> Repeating same mistake from the previous similar contribution. Where is the
> actual excerpt of the failure? Please, provide one.
> 

Here is one of the several errors when compiling.

drivers/iio/adc/max14001.c: In function ‘max14001_probe’:
drivers/iio/adc/max14001.c:315:22: error: implicit declaration of function ‘devm_regmap_init’ [-Wimplicit-function-declaration]
  315 |         st->regmap = devm_regmap_init(dev, NULL, st, &max14001_regmap_config);
      |                      ^~~~~~~~~~~~~~~~
drivers/iio/adc/max14001.c:315:20: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  315 |         st->regmap = devm_regmap_init(dev, NULL, st, &max14001_regmap_config);
      |                    ^

Funny how I essentially copied the cover letter from the series where I added
missing IIO_TRIGGER_BUFFER entries to Kconfig - to which you didn't require
an example build error :-)

Shall I do a v2 or is this reply enough?

Thanks

-- 
Kind regards

CJD

Re: [PATCH 0/3] iio: adc: add missing 'select REGMAP' to Kconfig

[Andy Shevchenko]

On Wed, Jul 08, 2026 at 10:01:50AM +0200, Joshua Crofts wrote:
> On Wed, 8 Jul 2026 10:47:48 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> 
> > On Wed, Jul 08, 2026 at 07:34:11AM +0200, Joshua Crofts wrote:
> > > This series adds missing `select REGMAP` and `select REGMAP_I2C` to the
> > > AD7380/MAX34408/MAX14001 Kconfig entries. Without these, some builds
> > > may result in a failure.  
> > 
> > > Steps to reproduce build failure:
> > > 1. Run `make allnoconfig`.
> > > 2. Run `make menuconfig` and select I2C/SPI, IIO and any of said drivers.
> > > 3. Run `make .` and make will end with regmap-related errors.  
> > 
> > Repeating same mistake from the previous similar contribution. Where is the
> > actual excerpt of the failure? Please, provide one.
> > 
> 
> Here is one of the several errors when compiling.
> 
> drivers/iio/adc/max14001.c: In function ‘max14001_probe’:
> drivers/iio/adc/max14001.c:315:22: error: implicit declaration of function ‘devm_regmap_init’ [-Wimplicit-function-declaration]
>   315 |         st->regmap = devm_regmap_init(dev, NULL, st, &max14001_regmap_config);
>       |                      ^~~~~~~~~~~~~~~~
> drivers/iio/adc/max14001.c:315:20: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>   315 |         st->regmap = devm_regmap_init(dev, NULL, st, &max14001_regmap_config);
>       |                    ^
> 
> Funny how I essentially copied the cover letter from the series where I added
> missing IIO_TRIGGER_BUFFER entries to Kconfig - to which you didn't require
> an example build error :-)
> 
> Shall I do a v2 or is this reply enough?

For now this reply is enough, but in the future add it to the initial
contribution from the start.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/3] iio: adc: add missing 'select REGMAP' to Kconfig

[Andy Shevchenko]

On Wed, Jul 08, 2026 at 07:34:11AM +0200, Joshua Crofts wrote:
> This series adds missing `select REGMAP` and `select REGMAP_I2C` to the
> AD7380/MAX34408/MAX14001 Kconfig entries. Without these, some builds
> may result in a failure.
> 
> Steps to reproduce build failure:
> 1. Run `make allnoconfig`.
> 2. Run `make menuconfig` and select I2C/SPI, IIO and any of said drivers.
> 3. Run `make .` and make will end with regmap-related errors.

Taking into account the real build failures as pointed in the replies,
the fixes LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/3] iio: adc: add missing 'select REGMAP' to Kconfig

[Jonathan Cameron]

On Wed, 8 Jul 2026 13:55:31 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Wed, Jul 08, 2026 at 07:34:11AM +0200, Joshua Crofts wrote:
> > This series adds missing `select REGMAP` and `select REGMAP_I2C` to the
> > AD7380/MAX34408/MAX14001 Kconfig entries. Without these, some builds
> > may result in a failure.
> > 
> > Steps to reproduce build failure:
> > 1. Run `make allnoconfig`.
> > 2. Run `make menuconfig` and select I2C/SPI, IIO and any of said drivers.
> > 3. Run `make .` and make will end with regmap-related errors.  
> 
> Taking into account the real build failures as pointed in the replies,
> the fixes LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
Applied patches 2 and 3 to the fixes-togreg branch of iio.git.

Thanks,

Jonathan