* [PATCH] iio: resolver: ad2s1200: use dev_err_probe()
@ 2026-07-16 12:31 Vojtěch Krátký
2026-07-16 12:46 ` Markus Elfring
2026-07-16 12:51 ` Joshua Crofts
0 siblings, 2 replies; 3+ messages in thread
From: Vojtěch Krátký @ 2026-07-16 12:31 UTC (permalink / raw)
To: nuno.sa, Michael.Hennerich, jic23
Cc: dlechner, andy, linux, linux-iio, linux-kernel, vo.kratky
Use dev_err_probe() instead of dev_err() to simplify the error path
and cleanly handle deferred probing.
Signed-off-by: Vojtěch Krátký <vo.kratky@seznam.cz>
---
drivers/iio/resolver/ad2s1200.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/resolver/ad2s1200.c b/drivers/iio/resolver/ad2s1200.c
index 55bcbbd4021a..7c7ce0e2f9cc 100644
--- a/drivers/iio/resolver/ad2s1200.c
+++ b/drivers/iio/resolver/ad2s1200.c
@@ -144,16 +144,14 @@ static int ad2s1200_probe(struct spi_device *spi)
st->sample = devm_gpiod_get(&spi->dev, "adi,sample", GPIOD_OUT_LOW);
if (IS_ERR(st->sample)) {
- dev_err(&spi->dev, "Failed to claim SAMPLE gpio: err=%ld\n",
- PTR_ERR(st->sample));
- return PTR_ERR(st->sample);
+ return dev_err_probe(&spi->dev, PTR_ERR(st->sample),
+ "Failed to claim SAMPLE gpio\n");
}
st->rdvel = devm_gpiod_get(&spi->dev, "adi,rdvel", GPIOD_OUT_LOW);
if (IS_ERR(st->rdvel)) {
- dev_err(&spi->dev, "Failed to claim RDVEL gpio: err=%ld\n",
- PTR_ERR(st->rdvel));
- return PTR_ERR(st->rdvel);
+ return dev_err_probe(&spi->dev, PTR_ERR(st->rdvel),
+ "Failed to claim RDVEL gpio\n");
}
indio_dev->info = &ad2s1200_info;
--
2.55.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: resolver: ad2s1200: use dev_err_probe()
2026-07-16 12:31 [PATCH] iio: resolver: ad2s1200: use dev_err_probe() Vojtěch Krátký
@ 2026-07-16 12:46 ` Markus Elfring
2026-07-16 12:51 ` Joshua Crofts
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2026-07-16 12:46 UTC (permalink / raw)
To: Vojtěch Krátký, linux-iio, Jonathan Cameron,
Michael Hennerich, Nuno Sá
Cc: LKML, linux, Andy Shevchenko, David Lechner
> Use dev_err_probe() instead of dev_err() to simplify the error path
> and cleanly handle deferred probing.
How do you think about to omit curly brackets accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.2-rc3#n197
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: resolver: ad2s1200: use dev_err_probe()
2026-07-16 12:31 [PATCH] iio: resolver: ad2s1200: use dev_err_probe() Vojtěch Krátký
2026-07-16 12:46 ` Markus Elfring
@ 2026-07-16 12:51 ` Joshua Crofts
1 sibling, 0 replies; 3+ messages in thread
From: Joshua Crofts @ 2026-07-16 12:51 UTC (permalink / raw)
To: Vojtěch Krátký
Cc: nuno.sa, Michael.Hennerich, jic23, dlechner, andy, linux,
linux-iio, linux-kernel
On Thu, 16 Jul 2026 14:31:00 +0200
Vojtěch Krátký <vo.kratky@seznam.cz> wrote:
> Use dev_err_probe() instead of dev_err() to simplify the error path
> and cleanly handle deferred probing.
>
> Signed-off-by: Vojtěch Krátký <vo.kratky@seznam.cz>
> ---
> drivers/iio/resolver/ad2s1200.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/resolver/ad2s1200.c b/drivers/iio/resolver/ad2s1200.c
> index 55bcbbd4021a..7c7ce0e2f9cc 100644
> --- a/drivers/iio/resolver/ad2s1200.c
> +++ b/drivers/iio/resolver/ad2s1200.c
> @@ -144,16 +144,14 @@ static int ad2s1200_probe(struct spi_device *spi)
>
> st->sample = devm_gpiod_get(&spi->dev, "adi,sample", GPIOD_OUT_LOW);
> if (IS_ERR(st->sample)) {
> - dev_err(&spi->dev, "Failed to claim SAMPLE gpio: err=%ld\n",
> - PTR_ERR(st->sample));
> - return PTR_ERR(st->sample);
> + return dev_err_probe(&spi->dev, PTR_ERR(st->sample),
> + "Failed to claim SAMPLE gpio\n");
Please align the error message with the parenthesis, i.e.
> + return dev_err_probe(&spi->dev, PTR_ERR(st->sample),
> + "Failed to claim SAMPLE gpio\n");
Same goes for the other change in this patch.
--
Kind regards
CJD
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-16 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-16 12:31 [PATCH] iio: resolver: ad2s1200: use dev_err_probe() Vojtěch Krátký
2026-07-16 12:46 ` Markus Elfring
2026-07-16 12:51 ` Joshua Crofts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox