From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: Vidhu Sarwal <vidhu.linux@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Per-Daniel Olsson" <perdaniel.olsson@axis.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH 0/3] iio: light: opt4060: Fix integration time, pointer type and error message
Date: Sun, 19 Jul 2026 23:36:30 +0100 [thread overview]
Message-ID: <20260719233630.70820ece@jic23-huawei> (raw)
In-Reply-To: <20260715011544.281148-1-vidhu.linux@gmail.com>
On Wed, 15 Jul 2026 06:45:41 +0530
Vidhu Sarwal <vidhu.linux@gmail.com> wrote:
> This series fixes three issues in the opt4060 driver, all of which have
> been present since the driver was introduced.
>
> Patch 1 rejects integration time writes with a non-zero seconds part.
> Previously, opt4060_write_raw() only considered the microseconds
> component, so values such as 1.000600 were accepted and programmed as
> 600 us.
>
> Patch 2 fixes a pointer type mismatch in the call to
> div_u64_rem(). This is a type cleanliness fix and does not change
> runtime behaviour.
>
> Patch 3 corrects a error in an error message that reported the
> wrong threshold register when a register read failed.
>
> The first 2 patches are similar to recently submitted patches on
> it's sister driver OPT4001 [1].
>
> Patch 3 is specific to opt4060.
All 3 applied to the fixes-togreg branch of iio.git.
I marked patches 1 and 3 for stable. The second one as you note
isn't a bug with affects as such so is less important to backport.
Nice little series.
Thanks,
Jonathan
>
> [1]: https://lore.kernel.org/all/20260714113134.3445-1-nikhilgtr@gmail.com/
>
> Vidhu Sarwal (3):
> iio: light: opt4060: Reject integration times with a non-zero seconds
> part
> iio: light: opt4060: Fix pointer type passed to div_u64_rem()
> iio: light: opt4060: Fix incorrect register name in threshold read
> error message
>
> drivers/iio/light/opt4060.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>
> base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa
prev parent reply other threads:[~2026-07-19 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 1:15 [PATCH 0/3] iio: light: opt4060: Fix integration time, pointer type and error message Vidhu Sarwal
2026-07-15 1:15 ` [PATCH 1/3] iio: light: opt4060: Reject integration times with a non-zero seconds part Vidhu Sarwal
2026-07-15 1:15 ` [PATCH 2/3] iio: light: opt4060: Fix pointer type passed to div_u64_rem() Vidhu Sarwal
2026-07-15 1:15 ` [PATCH 3/3] iio: light: opt4060: Fix incorrect register name in threshold read error message Vidhu Sarwal
2026-07-19 22:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260719233630.70820ece@jic23-huawei \
--to=jonathan.cameron@oss.qualcomm.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=perdaniel.olsson@axis.com \
--cc=skhan@linuxfoundation.org \
--cc=vidhu.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox