* [PATCH] iio: chemical: cleanup codestyle warning
@ 2026-07-23 16:10 Adi Nata
2026-07-23 21:51 ` Joshua Crofts
0 siblings, 1 reply; 3+ messages in thread
From: Adi Nata @ 2026-07-23 16:10 UTC (permalink / raw)
To: jic23, dlechner, nuno.sa, andy, mazziesaccount,
adinata.softwareengineer, email, u.kleine-koenig, linux-iio,
linux-kernel
Cc: linux-kernel-mentees
Reported by checkpatch:
FILE: drivers/iio/chemical/ccs811.c
WARNING: Prefer __packed over __attribute__((__packed__))
+} __attribute__((__packed__));
Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
---
drivers/iio/chemical/ccs811.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
index ce7187ccd706..0e5c79b775a2 100644
--- a/drivers/iio/chemical/ccs811.c
+++ b/drivers/iio/chemical/ccs811.c
@@ -70,7 +70,7 @@ struct ccs811_reading {
u8 status;
u8 error;
__be16 raw_data;
-} __attribute__((__packed__));
+} __packed;
struct ccs811_data {
struct i2c_client *client;
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: chemical: cleanup codestyle warning
2026-07-23 16:10 [PATCH] iio: chemical: cleanup codestyle warning Adi Nata
@ 2026-07-23 21:51 ` Joshua Crofts
2026-07-23 21:53 ` Joshua Crofts
0 siblings, 1 reply; 3+ messages in thread
From: Joshua Crofts @ 2026-07-23 21:51 UTC (permalink / raw)
To: Adi Nata
Cc: jic23, dlechner, nuno.sa, andy, mazziesaccount, email,
u.kleine-koenig, linux-iio, linux-kernel, linux-kernel-mentees
On Fri, 24 Jul 2026 00:10:38 +0800
Adi Nata <adinata.softwareengineer@gmail.com> wrote:
> Reported by checkpatch:
> FILE: drivers/iio/chemical/ccs811.c
>
> WARNING: Prefer __packed over __attribute__((__packed__))
> +} __attribute__((__packed__));
Perhaps a nit, but I'd change the commit title to "prefer __packed"
and the commit message to something like:
"Change instance of __attribute__((__packed__)) to __packed per
checkpatch.pl warning.
Other than that:
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
>
> Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
> ---
> drivers/iio/chemical/ccs811.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
> index ce7187ccd706..0e5c79b775a2 100644
> --- a/drivers/iio/chemical/ccs811.c
> +++ b/drivers/iio/chemical/ccs811.c
> @@ -70,7 +70,7 @@ struct ccs811_reading {
> u8 status;
> u8 error;
> __be16 raw_data;
> -} __attribute__((__packed__));
> +} __packed;
>
> struct ccs811_data {
> struct i2c_client *client;
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: chemical: cleanup codestyle warning
2026-07-23 21:51 ` Joshua Crofts
@ 2026-07-23 21:53 ` Joshua Crofts
0 siblings, 0 replies; 3+ messages in thread
From: Joshua Crofts @ 2026-07-23 21:53 UTC (permalink / raw)
To: Adi Nata
Cc: jic23, dlechner, nuno.sa, andy, mazziesaccount, email,
u.kleine-koenig, linux-iio, linux-kernel, linux-kernel-mentees
On Thu, 23 Jul 2026 23:51:39 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> On Fri, 24 Jul 2026 00:10:38 +0800
> Adi Nata <adinata.softwareengineer@gmail.com> wrote:
>
> > Reported by checkpatch:
> > FILE: drivers/iio/chemical/ccs811.c
> >
> > WARNING: Prefer __packed over __attribute__((__packed__))
> > +} __attribute__((__packed__));
>
> Perhaps a nit, but I'd change the commit title to "prefer __packed"
> and the commit message to something like:
>
> "Change instance of __attribute__((__packed__)) to __packed per
> checkpatch.pl warning.
>
> Other than that:
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
Additionally, you're missing the driver name in the subject/commit
message, it should be something like "iio: chemical: ccs811: prefer __packed"
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-23 21:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 16:10 [PATCH] iio: chemical: cleanup codestyle warning Adi Nata
2026-07-23 21:51 ` Joshua Crofts
2026-07-23 21:53 ` Joshua Crofts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox