From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Yash Suthar" <yashsuthar983@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: accel: bmc150: use IIO_DECLARE_BUFFER_WITH_TS
Date: Wed, 12 Aug 2026 05:52:02 +0100 [thread overview]
Message-ID: <20260812055202.1fcc271e@jic23-huawei> (raw)
In-Reply-To: <anmTFZkbbSqZ-5CY@ashevche-desk.local>
On Mon, 10 Aug 2026 12:00:05 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Mon, Aug 10, 2026 at 12:18:52AM +0100, Jonathan Cameron wrote:
> > On Sun, 9 Aug 2026 23:59:34 +0100
> > Jonathan Cameron <jic23@kernel.org> wrote:
> > > On Sun, 9 Aug 2026 11:24:42 +0530
> > > Yash Suthar <yashsuthar983@gmail.com> wrote:
>
> ...
>
> > Actually no. I've backed that out.
> >
> > Given the data alignment is fixed, if we were going to do this it would
> > be clearer as
> > struct {
> > s16 chans[3]; //see later, I believe this should be __le16
> > aligned_s64 timestamp;
> > };
> >
> > But that is very similar to the structure that follows immediately after
> > this, but that has __le16 chans[]
> >
> > So what is going on here?
>
> AI slop?
It's the original code I'm complaining about. Been around a while!
So for once, nope (I think!)
Jonathan
>
next prev parent reply other threads:[~2026-08-12 4:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 22:02 [PATCH] iio: accel: bmc150: use IIO_DECLARE_BUFFER_WITH_TS Yash Suthar
2026-08-08 22:35 ` David Lechner
2026-08-09 5:54 ` [PATCH v2] " Yash Suthar
2026-08-09 22:59 ` Jonathan Cameron
2026-08-09 23:18 ` Jonathan Cameron
2026-08-10 9:00 ` Andy Shevchenko
2026-08-12 4:52 ` Jonathan Cameron [this message]
2026-08-10 21:58 ` Yash Suthar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812055202.1fcc271e@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=yashsuthar983@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox