Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Gabriel Rondon <grondon@gmail.com>
Cc: "Matti Vaittinen" <mazziesaccount@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] iio: accel: kionix-kx022a: unify staging buffer and convert to iio_push_to_buffers_with_ts()
Date: Wed, 19 Aug 2026 01:09:00 +0100	[thread overview]
Message-ID: <20260819010900.7728cff8@jic23-huawei> (raw)
In-Reply-To: <20260818215122.52715-1-grondon@gmail.com>

On Tue, 18 Aug 2026 22:51:20 +0100
Gabriel Rondon <grondon@gmail.com> wrote:

> v1 was a single patch converting the two push sites to
> iio_push_to_buffers_with_ts(). Reviewing it, Jonathan pointed out that
> the driver carries two separate staging areas holding the same thing
> (buffer[8] and the scan struct), and asked to fold the cleanup into this
> set.
> 
> So v2 is a two-patch series: patch 1 drops the redundant buffer and
> routes the one-shot read and the triggered handler through scan, and
> patch 2 does the deprecated-API conversion, now with a single buffer to
> push at both sites.
> 
> Changes in v2:
> - New patch 1: drop buffer[8], use scan for the one-shot read and the
>   triggered handler, move IIO_DMA_MINALIGN onto scan (Jonathan)
> - Patch 2 now pushes data->scan at both sites instead of data->buffer
> 
Nice.  All looks good to me, so I'll queue it up.

Applied to the testing branch of iio.git which will be rebased on rc1 once
available.

Note that there is plenty of time for additional feedback, tags or indeed
me to drop it again if someone spots something I missed.

Thanks,

Jonathan

> v1: https://lore.kernel.org/linux-iio/20260818155635.8367-1-grondon@gmail.com/
> 
> Gabriel Rondon (2):
>   iio: accel: kionix-kx022a: use scan struct for one-shot and trigger
>     reads
>   iio: accel: kionix-kx022a: use iio_push_to_buffers_with_ts()
> 
>  drivers/iio/accel/kionix-kx022a.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 


  parent reply	other threads:[~2026-08-19  0:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 21:51 [PATCH v2 0/2] iio: accel: kionix-kx022a: unify staging buffer and convert to iio_push_to_buffers_with_ts() Gabriel Rondon
2026-08-18 21:51 ` [PATCH v2 1/2] iio: accel: kionix-kx022a: use scan struct for one-shot and trigger reads Gabriel Rondon
2026-08-19  4:59   ` Matti Vaittinen
2026-08-19  7:17   ` Andy Shevchenko
2026-08-18 21:51 ` [PATCH v2 2/2] iio: accel: kionix-kx022a: use iio_push_to_buffers_with_ts() Gabriel Rondon
2026-08-19  5:11   ` Matti Vaittinen
2026-08-19  0:09 ` Jonathan Cameron [this message]
2026-08-19  5:15   ` [PATCH v2 0/2] iio: accel: kionix-kx022a: unify staging buffer and convert to iio_push_to_buffers_with_ts() Matti Vaittinen
2026-08-19  7:18     ` Andy Shevchenko
2026-08-19  7:19 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819010900.7728cff8@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=grondon@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox