[PATCH v3] iio: light: ltr390: Remove stale TODOs

[PATCH v3] iio: light: ltr390: Remove stale TODOs

[Chang Yu]

Remove stale TODOs from ltr390.c. All features have already been
implemented by Abhash Jha<abhashkumarjha123@gmail.com>'s patches:

[1] Configurable gain and resolution
[2] Suspend/resume support
[3] Support for reading the ALS
[4] Interrupt support

Link: https://git.kernel.org/torvalds/c/13fad2607dad [1]
Link: https://git.kernel.org/torvalds/c/288ce72fb5fc [2]
Link: https://git.kernel.org/torvalds/c/14e0d914a855 [3]
Link: https://git.kernel.org/torvalds/c/7ca4b8957066 [4]

Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
---

Changes since v3:
  * Reformatted commit links.

 drivers/iio/light/ltr390.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/iio/light/ltr390.c b/drivers/iio/light/ltr390.c
index bc031f2c3141..f1bb066248e6 100644
--- a/drivers/iio/light/ltr390.c
+++ b/drivers/iio/light/ltr390.c
@@ -10,12 +10,6 @@
  *
  * Datasheet:
  *   https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf
- *
- * TODO:
- *   - Support for configurable gain and resolution
- *   - Sensor suspend/resume support
- *   - Add support for reading the ALS
- *   - Interrupt support
  */
 
 #include <linux/bitfield.h>
-- 
2.55.0

Re: [PATCH v3] iio: light: ltr390: Remove stale TODOs

[Andy Shevchenko]

On Fri, Aug 28, 2026 at 11:14 AM Chang Yu <marcus.yu.56@gmail.com> wrote:
>
> Remove stale TODOs from ltr390.c. All features have already been
> implemented by Abhash Jha<abhashkumarjha123@gmail.com>'s patches:
>
> [1] Configurable gain and resolution
> [2] Suspend/resume support
> [3] Support for reading the ALS
> [4] Interrupt support
>
> Link: https://git.kernel.org/torvalds/c/13fad2607dad [1]
> Link: https://git.kernel.org/torvalds/c/288ce72fb5fc [2]
> Link: https://git.kernel.org/torvalds/c/14e0d914a855 [3]
> Link: https://git.kernel.org/torvalds/c/7ca4b8957066 [4]
>

Link is the official tag, no blank line is supposed to be here. But no
need to resend anymore, for this patch I hope Jonathan will make a
necessary tweak whilst applying.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v3] iio: light: ltr390: Remove stale TODOs

[Joshua Crofts]

On Fri, 28 Aug 2026 01:13:54 -0700
Chang Yu <marcus.yu.56@gmail.com> wrote:

> Remove stale TODOs from ltr390.c. All features have already been
> implemented by Abhash Jha<abhashkumarjha123@gmail.com>'s patches:
> 
> [1] Configurable gain and resolution
> [2] Suspend/resume support
> [3] Support for reading the ALS
> [4] Interrupt support
> 
> Link: https://git.kernel.org/torvalds/c/13fad2607dad [1]
> Link: https://git.kernel.org/torvalds/c/288ce72fb5fc [2]
> Link: https://git.kernel.org/torvalds/c/14e0d914a855 [3]
> Link: https://git.kernel.org/torvalds/c/7ca4b8957066 [4]
> 
> Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
> ---

Next time, please wait at least 24 hours before sending a new
version.

-- 
Kind regards,
Joshua Crofts

Re: [PATCH v3] iio: light: ltr390: Remove stale TODOs

[Jonathan Cameron]

On Fri, 28 Aug 2026 11:19:46 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Fri, Aug 28, 2026 at 11:14 AM Chang Yu <marcus.yu.56@gmail.com> wrote:
> >
> > Remove stale TODOs from ltr390.c. All features have already been
> > implemented by Abhash Jha<abhashkumarjha123@gmail.com>'s patches:
> >
> > [1] Configurable gain and resolution
> > [2] Suspend/resume support
> > [3] Support for reading the ALS
> > [4] Interrupt support
> >
> > Link: https://git.kernel.org/torvalds/c/13fad2607dad [1]
> > Link: https://git.kernel.org/torvalds/c/288ce72fb5fc [2]
> > Link: https://git.kernel.org/torvalds/c/14e0d914a855 [3]
> > Link: https://git.kernel.org/torvalds/c/7ca4b8957066 [4]
> >  
> 
> Link is the official tag, no blank line is supposed to be here. But no
> need to resend anymore, for this patch I hope Jonathan will make a
> necessary tweak whilst applying.
> 
> Reviewed-by: Andy Shevchenko <andy@kernel.org>

It was a touch messy as b4 picked up the fact there were tags in
the earlier version for Link and (I think) because of this blank line
it didn't match them with these ones so we had two sets of the same
thing. Anyhow fixed up and applied

Jonathan

>