* [PATCH] iio: adc: ad7768-1: Fix trigger reference leak in ad7768_triggered_buffer_alloc()
@ 2026-09-16 16:17 Wentao Liang
2026-09-17 0:26 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Liang @ 2026-09-16 16:17 UTC (permalink / raw)
To: Michael.Hennerich
Cc: andy, dlechner, jic23, lars, linux-iio, linux-kernel, nuno.sa,
stefan.popa, Wentao Liang, stable
The reference taken with iio_trigger_get() is only dropped by
iio_dev_release() when INDIO_BUFFER_TRIGGERED is set. If
devm_iio_triggered_buffer_setup() fails before setting that mode, the
reference acquired for indio_dev->trig leaks. Move the
iio_trigger_get() after the buffer setup succeeds.
Fixes: a5f8c7da3dbe ("iio: adc: Add AD7768-1 ADC basic support")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/iio/adc/ad7768-1.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index 73fb734d06b2..94e746c78cd8 100644
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -1505,12 +1505,16 @@ static int ad7768_triggered_buffer_alloc(struct iio_dev *indio_dev)
if (ret)
return ret;
+ ret = devm_iio_triggered_buffer_setup(indio_dev->dev.parent, indio_dev,
+ &iio_pollfunc_store_time,
+ &ad7768_trigger_handler,
+ &ad7768_buffer_ops);
+ if (ret)
+ return ret;
+
indio_dev->trig = iio_trigger_get(st->trig);
- return devm_iio_triggered_buffer_setup(indio_dev->dev.parent, indio_dev,
- &iio_pollfunc_store_time,
- &ad7768_trigger_handler,
- &ad7768_buffer_ops);
+ return 0;
}
static int ad7768_vcm_enable(struct regulator_dev *rdev)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: adc: ad7768-1: Fix trigger reference leak in ad7768_triggered_buffer_alloc()
2026-09-16 16:17 [PATCH] iio: adc: ad7768-1: Fix trigger reference leak in ad7768_triggered_buffer_alloc() Wentao Liang
@ 2026-09-17 0:26 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2026-09-17 0:26 UTC (permalink / raw)
To: Wentao Liang
Cc: Michael.Hennerich, andy, dlechner, lars, linux-iio, linux-kernel,
nuno.sa, stefan.popa, stable
On Wed, 16 Sep 2026 16:17:26 +0000
Wentao Liang <vulab@iscas.ac.cn> wrote:
> The reference taken with iio_trigger_get() is only dropped by
> iio_dev_release() when INDIO_BUFFER_TRIGGERED is set. If
> devm_iio_triggered_buffer_setup() fails before setting that mode, the
> reference acquired for indio_dev->trig leaks. Move the
> iio_trigger_get() after the buffer setup succeeds.
>
> Fixes: a5f8c7da3dbe ("iio: adc: Add AD7768-1 ADC basic support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Not this solution. Same reasoning...
> ---
> drivers/iio/adc/ad7768-1.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
> index 73fb734d06b2..94e746c78cd8 100644
> --- a/drivers/iio/adc/ad7768-1.c
> +++ b/drivers/iio/adc/ad7768-1.c
> @@ -1505,12 +1505,16 @@ static int ad7768_triggered_buffer_alloc(struct iio_dev *indio_dev)
> if (ret)
> return ret;
>
> + ret = devm_iio_triggered_buffer_setup(indio_dev->dev.parent, indio_dev,
> + &iio_pollfunc_store_time,
> + &ad7768_trigger_handler,
> + &ad7768_buffer_ops);
> + if (ret)
> + return ret;
> +
> indio_dev->trig = iio_trigger_get(st->trig);
>
> - return devm_iio_triggered_buffer_setup(indio_dev->dev.parent, indio_dev,
> - &iio_pollfunc_store_time,
> - &ad7768_trigger_handler,
> - &ad7768_buffer_ops);
> + return 0;
> }
>
> static int ad7768_vcm_enable(struct regulator_dev *rdev)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-17 0:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-16 16:17 [PATCH] iio: adc: ad7768-1: Fix trigger reference leak in ad7768_triggered_buffer_alloc() Wentao Liang
2026-09-17 0:26 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox