Re: [RFC] Maintainer entry profile/contributor guide for IIO

[Joshua Crofts <joshua.crofts1@gmail.com>]

On Tue, 22 Sep 2026 16:44:07 +0100
Nuno Sá <nuno.sa@analog.com> wrote:

> On Tue, Sep 22, 2026 at 05:07:34PM +0200, Joshua Crofts wrote:
> > On Tue, 22 Sep 2026 16:03:26 +0100
> > Nuno Sá <nuno.sa@analog.com> wrote:
> >   
> > > On Tue, Sep 22, 2026 at 04:51:24PM +0200, Joshua Crofts wrote:  
> > > > On Mon, 21 Sep 2026 10:28:24 +0100
> > > > Nuno Sá <nuno.sa@analog.com> wrote:    
> > > > > > I'd propose 2 documents:
> > > > > > - entry profile - documenting the review cycle, patchwork, point people over to
> > > > > >   Sashiko, relevant git tree etc.
> > > > > > - code style - the TODO is fine for existing problems in the subsystem but doesn't
> > > > > >   point out idioms we have in IIO, i.e. not using (the awful) kernel.h, preferring
> > > > > >   devm_* functions, not failing on a mismatched ID to ensure fallback etc. This is
> > > > > >   stuff that appears a lot in patches.      
> > > > > 
> > > > > Personally I do think we have some things (not just coding style)  that are very
> > > > > specific to IIO. But maybe another docs file is not the question. Or at least one
> > > > > for humans to read :)?! Have you evaluate just having an IIO entry for
> > > > > sashiko? That way, hopefully the bot would take care about the subsystem
> > > > > specifics and preferences.
> > > > > 
> > > > > I wanted to do this myself at some point but I'm always pulled for
> > > > > something else so if this is feels like something you agree and would
> > > > > like to get done, please go ahead :)
> > > > > 
> > > > > [1]: https://github.com/masoncl/review-prompts/tree/main/kernel/subsystem
> > > > > 
> > > > > My 2 cents!
> > > > > - Nuno Sá    
> > > > 
> > > > There was a thread about adding Sashiko reviews to IIO but it died out :(
> > > > I proposed adding an IIO-specific prompt. Any ideas on what it should contain?    
> > > 
> > > Not sure if I get the above. I already see sashiko doing reviews in IIO?
> > > What am I missing?
> > > 
> > > What I mean is adding specialized IIO preferences/tecnical details to it. And for that
> > > we need to add a new iio.md in [1] and a table entry in [2]. If I'm not
> > > missing anything.
> > > 
> > > Sashiko is using the review prompt repo.
> > >   
> > 
> > Yes, that is what I meant, adding iio.md (or something like that). I believe Sashiko
> > pulls prompts from here [1] (?).  
> 
> For hwmon yes. For iio we would need our own set of rules. AFAIK, sashiko will
> use the entries in [2] (see my previous email) so that it will pull the
> proper subsystem set of rules. Given we have none, it probably uses the
> more generic technical patterns. Basically this why I suggested to have
> an iio.md for the bot rather than other howto doc in tree.
> 

Yes, I should've clarified the hwmon entry is just an example :)

I guess the only thing that remains is to write the prompt.

-- 
Kind regards,
Joshua Crofts