From: "Nuno Sá" <nuno.sa@analog.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: David Lechner <dlechner@baylibre.com>,
linux-iio@vger.kernel.org, jic23@kernel.org, andy@kernel.org
Subject: Re: [RFC] Maintainer entry profile/contributor guide for IIO
Date: Tue, 22 Sep 2026 16:03:26 +0100 [thread overview]
Message-ID: <arKWs7nTaJAda-XA@nsa> (raw)
In-Reply-To: <20260922165124.0000132f@gmail.com>
On Tue, Sep 22, 2026 at 04:51:24PM +0200, Joshua Crofts wrote:
> On Mon, 21 Sep 2026 10:28:24 +0100
> Nuno Sá <nuno.sa@analog.com> wrote:
> > > I'd propose 2 documents:
> > > - entry profile - documenting the review cycle, patchwork, point people over to
> > > Sashiko, relevant git tree etc.
> > > - code style - the TODO is fine for existing problems in the subsystem but doesn't
> > > point out idioms we have in IIO, i.e. not using (the awful) kernel.h, preferring
> > > devm_* functions, not failing on a mismatched ID to ensure fallback etc. This is
> > > stuff that appears a lot in patches.
> >
> > Personally I do think we have some things (not just coding style) that are very
> > specific to IIO. But maybe another docs file is not the question. Or at least one
> > for humans to read :)?! Have you evaluate just having an IIO entry for
> > sashiko? That way, hopefully the bot would take care about the subsystem
> > specifics and preferences.
> >
> > I wanted to do this myself at some point but I'm always pulled for
> > something else so if this is feels like something you agree and would
> > like to get done, please go ahead :)
> >
> > [1]: https://github.com/masoncl/review-prompts/tree/main/kernel/subsystem
> >
> > My 2 cents!
> > - Nuno Sá
>
> There was a thread about adding Sashiko reviews to IIO but it died out :(
> I proposed adding an IIO-specific prompt. Any ideas on what it should contain?
Not sure if I get the above. I already see sashiko doing reviews in IIO?
What am I missing?
What I mean is adding specialized IIO preferences/tecnical details to it. And for that
we need to add a new iio.md in [1] and a table entry in [2]. If I'm not
missing anything.
Sashiko is using the review prompt repo.
[1]: https://github.com/masoncl/review-prompts/tree/main/kernel/subsystem
[2]: https://github.com/masoncl/review-prompts/blob/main/kernel/subsystem/subsystem.md
- Nuno Sá
>
> As Krzysztof says, there isn't really a point in making a new doc as people
> just don't read docs (I know I didn't when I was starting out, but perhaps
> just consulting with an LLM was a mistake :) )
>
> --
> Kind regards,
> Joshua Crofts
next prev parent reply other threads:[~2026-09-22 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 9:18 [RFC] Maintainer entry profile/contributor guide for IIO Joshua Crofts
2026-08-17 18:50 ` Maxwell Doose
2026-08-18 7:22 ` Joshua Crofts
2026-08-18 0:31 ` David Lechner
2026-08-18 7:06 ` Joshua Crofts
2026-09-19 8:38 ` Krzysztof Kozlowski
2026-09-19 9:35 ` Joshua Crofts
2026-09-19 18:53 ` Krzysztof Kozlowski
2026-09-22 14:54 ` Joshua Crofts
2026-09-21 9:28 ` Nuno Sá
2026-09-22 14:51 ` Joshua Crofts
2026-09-22 15:03 ` Nuno Sá [this message]
2026-09-22 15:07 ` Joshua Crofts
2026-09-22 15:44 ` Nuno Sá
2026-09-22 15:48 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arKWs7nTaJAda-XA@nsa \
--to=nuno.sa@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox