Linux IIO development
 help / color / mirror / Atom feed
* [PATCH 00/35] iio: closing default trigger handling leaks
@ 2026-11-16  1:47 Jonathan Cameron
  2026-11-16  1:47 ` [PATCH 01/35] iio: core: add default_trigger and take reference in iio_device_register() Jonathan Cameron
                   ` (34 more replies)
  0 siblings, 35 replies; 36+ messages in thread
From: Jonathan Cameron @ 2026-11-16  1:47 UTC (permalink / raw)
  To: linux-iio, David Lechner, Nuno Sá, Andy Shevchenko
  Cc: linux-kernel, Martin Tuma, Mauro Carvalho Chehab, linux-media,
	Gustavo Silva, Marcelo Schmitt, Antoniu Miclaus,
	Michael Hennerich, Ramona Alexandra Nechita, Tomislav Denis,
	Jorge Marques, Petre Rodan, Dan Robertson, Jianping Shen,
	Gwendal Grignou, Maxwell Doose, Tomasz Duszynski, Esben Haabendal,
	Narcisa Ana Maria Vasile, Jiri Kosina, Srinivas Pandruvada,
	Vasileios Amoiridis, Abhash Jha, Puranjay Mohan, Nishant Malpani,
	Oleksij Rempel, Linus Walleij, Jonathan Cameron

From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>

Note this is compile tested only!  I definitely want a few people
to test that I didn't break everything.

This is the first part of what I think is a long term solution to the
currently really fragile ordering constraints around setting default
triggers. Today these are set by iio_dev->trig = iio_trigger_get(trig).
The reference is only released on the iio_dev.release callback and
only if we have set the mode to include one that means there might be
a trigger set. That mode set only occurs when a buffer is registered.
Thus trigger release only works if we have already registered a buffer.

One solution would be to reorder so that the default trigger is always
set after the buffer registration (we have had various recent proposed
patches to do that for individual drivers) but that is non obvious and
fragile.

The solution here is easier to reason about. Decouple the setting
of the default trigger from the acquisition of a reference. Thus
we can acquire the reference in iio_device_register() when we know
all the conditions for it's release have been achieved.
So that's all we do in this part 1 series.

Part 2 will address immutable triggers and those that are effectively
immutable but predate that logic. That is those that set a one to one
relationship between device and trigger.  That change is rather less
mechanical than this one and 35 patches is really a bit big anyway
even if most of them are small!

Part 3 and beyond will move to a situation where the iio_dev->trig
will become opaque. That should stop anyone manipulating that directly.
I have a few related cunning plans to test out before we get to that,
not because the particular challenge is hard, but because they will
trample on the same code.

Jonathan Cameron (35):
  iio: core: add default_trigger and take reference in
    iio_device_register()
  media: pci: mgb4: use IIO default_trigger
  iio: chemical: ens160: use default_trigger
  iio: adc: ad4130: use default_trigger
  iio: adc: ad4170-4: use default_trigger
  iio: adc: ad7768-1: use default_trigger
  iio: adc: ad7779: use default_trigger
  iio: adc: ti-ads131e08: use default_trigger
  iio: addac: ad74115: use default_trigger
  iio: addac: ad74413r: use default_trigger
  iio: temperature: tmp006: use default_trigger
  iio: adc: ad4062: use default_trigger
  iio: accel: bma220: use default_trigger
  iio: accel: bma400: use default_trigger
  iio: imu: smi330: use default_trigger
  iio: light: acpi-als: use default_trigger
  iio: chemical: scd30: use default_trigger
  iio: accel: bma180: use default_trigger
  iio: accel: kxcjk-1013: use default_trigger
  iio: accel: mma8452: use default_trigger
  iio: chemical: ccs811: use default_trigger
  iio: pressure: mpl3115: use default_trigger
  iio: common: st_sensors: use default_trigger
  iio: common: hid-sensors: use default_trigger
  iio: pressure: bmp280: use default_trigger
  iio: light: vl6180: use default_trigger
  iio: gyro: itg3200: use default_trigger
  iio: imu: bmi160: use default_trigger
  iio: accel: adxl355: use default_trigger
  iio: gyro: adxrs290: use default_trigger
  iio: accel: adxl372: use default_trigger
  iio: light: si1145: use default_trigger
  iio: adc: ti-tsc2046: use default_trigger
  iio: accel: mxc4005: use default_trigger
  iio: gyro: mpu3050: use default_trigger

 drivers/iio/accel/adxl355_core.c              | 19 ++++++++--------
 drivers/iio/accel/adxl372.c                   |  2 +-
 drivers/iio/accel/bma180.c                    |  2 +-
 drivers/iio/accel/bma220_core.c               |  2 +-
 drivers/iio/accel/bma400_core.c               |  2 +-
 drivers/iio/accel/kxcjk-1013.c                |  2 +-
 drivers/iio/accel/mma8452.c                   |  2 +-
 drivers/iio/accel/mxc4005.c                   |  2 +-
 drivers/iio/adc/ad4062.c                      |  2 +-
 drivers/iio/adc/ad4130.c                      |  2 +-
 drivers/iio/adc/ad4170-4.c                    |  2 +-
 drivers/iio/adc/ad7768-1.c                    |  2 +-
 drivers/iio/adc/ad7779.c                      | 20 ++++++++---------
 drivers/iio/adc/ti-ads131e08.c                |  2 +-
 drivers/iio/adc/ti-tsc2046.c                  |  3 +--
 drivers/iio/addac/ad74115.c                   |  2 +-
 drivers/iio/addac/ad74413r.c                  |  2 +-
 drivers/iio/chemical/ccs811.c                 |  2 +-
 drivers/iio/chemical/ens160_core.c            |  5 ++---
 drivers/iio/chemical/scd30_core.c             |  2 +-
 .../common/hid-sensors/hid-sensor-trigger.c   |  3 ++-
 .../common/st_sensors/st_sensors_trigger.c    |  2 +-
 drivers/iio/gyro/adxrs290.c                   | 19 ++++++++--------
 drivers/iio/gyro/itg3200_buffer.c             |  3 +--
 drivers/iio/gyro/mpu3050-core.c               |  2 +-
 drivers/iio/imu/bmi160/bmi160.h               |  1 -
 drivers/iio/imu/bmi160/bmi160_core.c          | 22 +++++++++----------
 drivers/iio/imu/smi330/smi330_core.c          |  3 +--
 drivers/iio/industrialio-core.c               | 15 ++++++++++---
 drivers/iio/industrialio-trigger.c            | 21 +++++++++++++++---
 drivers/iio/light/acpi-als.c                  |  2 +-
 drivers/iio/light/si1145.c                    |  5 +----
 drivers/iio/light/vl6180.c                    |  2 +-
 drivers/iio/pressure/bmp280-core.c            |  2 +-
 drivers/iio/pressure/mpl3115.c                |  2 +-
 drivers/iio/temperature/tmp006.c              | 22 +++++++++----------
 drivers/media/pci/mgb4/mgb4_trigger.c         |  2 +-
 include/linux/iio/iio.h                       |  4 ++++
 38 files changed, 114 insertions(+), 97 deletions(-)


base-commit: 94921bc9eb214f838481faa847cda5c42e486013
-- 
2.56.1


^ permalink raw reply	[flat|nested] 36+ messages in thread

end of thread, other threads:[~2026-11-16  1:50 UTC | newest]

Thread overview: 36+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16  1:47 [PATCH 00/35] iio: closing default trigger handling leaks Jonathan Cameron
2026-11-16  1:47 ` [PATCH 01/35] iio: core: add default_trigger and take reference in iio_device_register() Jonathan Cameron
2026-11-16  1:47 ` [PATCH 02/35] media: pci: mgb4: use IIO default_trigger Jonathan Cameron
2026-11-16  1:47 ` [PATCH 03/35] iio: chemical: ens160: use default_trigger Jonathan Cameron
2026-11-16  1:47 ` [PATCH 04/35] iio: adc: ad4130: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 05/35] iio: adc: ad4170-4: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 06/35] iio: adc: ad7768-1: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 07/35] iio: adc: ad7779: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 08/35] iio: adc: ti-ads131e08: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 09/35] iio: addac: ad74115: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 10/35] iio: addac: ad74413r: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 11/35] iio: temperature: tmp006: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 12/35] iio: adc: ad4062: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 13/35] iio: accel: bma220: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 14/35] iio: accel: bma400: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 15/35] iio: imu: smi330: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 16/35] iio: light: acpi-als: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 17/35] iio: chemical: scd30: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 18/35] iio: accel: bma180: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 19/35] iio: accel: kxcjk-1013: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 20/35] iio: accel: mma8452: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 21/35] iio: chemical: ccs811: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 22/35] iio: pressure: mpl3115: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 23/35] iio: common: st_sensors: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 24/35] iio: common: hid-sensors: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 25/35] iio: pressure: bmp280: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 26/35] iio: light: vl6180: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 27/35] iio: gyro: itg3200: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 28/35] iio: imu: bmi160: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 29/35] iio: accel: adxl355: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 30/35] iio: gyro: adxrs290: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 31/35] iio: accel: adxl372: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 32/35] iio: light: si1145: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 33/35] iio: adc: ti-tsc2046: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 34/35] iio: accel: mxc4005: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 35/35] iio: gyro: mpu3050: " Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox