From: Lars-Peter Clausen <lars@metafoo.de>
To: "Nuno Sá" <nuno.sa@analog.com>, linux-iio@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 2/3] iio: buffer: make sure O_NONBLOCK is respected
Date: Thu, 16 Feb 2023 06:00:00 -0800 [thread overview]
Message-ID: <386610fc-08ce-ec04-a577-26f415b48701@metafoo.de> (raw)
In-Reply-To: <20230216101452.591805-3-nuno.sa@analog.com>
On 2/16/23 02:14, Nuno Sá wrote:
> For output buffers, there's no guarantee that the buffer won't be full
> in the first iteration of the loop in which case we would block
> independently of userspace passing O_NONBLOCK or not. Fix it by always
> checking the flag before going to sleep.
>
> While at it (and as it's a bit related), refactored the loop so that the
> stop condition is 'written != n', i.e, run the loop until all data has
> been copied into the IIO buffers. This makes the code a bit simpler.
>
> Fixes: 9eeee3b0bf190 ("iio: Add output buffer support")
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
next prev parent reply other threads:[~2023-02-16 14:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 10:14 [PATCH 0/3] output buffer write fops fixes Nuno Sá
2023-02-16 10:14 ` [PATCH 1/3] iio: buffer: correctly return bytes written in output buffers Nuno Sá
2023-02-16 13:40 ` Lars-Peter Clausen
2023-02-18 14:07 ` Jonathan Cameron
2023-02-16 10:14 ` [PATCH 2/3] iio: buffer: make sure O_NONBLOCK is respected Nuno Sá
2023-02-16 14:00 ` Lars-Peter Clausen [this message]
2023-02-18 14:08 ` Jonathan Cameron
2023-02-16 10:14 ` [PATCH 3/3] iio: buffer: fix coding style warnings Nuno Sá
2023-02-16 14:07 ` Lars-Peter Clausen
2023-02-27 7:39 ` Nuno Sá
2023-03-04 13:03 ` Jonathan Cameron
2023-05-01 16:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=386610fc-08ce-ec04-a577-26f415b48701@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox