Linux IIO development
 help / color / mirror / Atom feed
* [PATCH] iio: adc: adi-axi-adc: replace of.h with mod_devicetable.h
@ 2025-02-18 10:34 Nuno Sá via B4 Relay
  2025-02-18 15:54 ` David Lechner
  2025-02-22 21:00 ` Andy Shevchenko
  0 siblings, 2 replies; 7+ messages in thread
From: Nuno Sá via B4 Relay @ 2025-02-18 10:34 UTC (permalink / raw)
  To: linux-iio; +Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron

From: Nuno Sá <nuno.sa@analog.com>

Don't use of.h in order to include mod_devicetable.h. Use it directly as
there no direct dependency on OF.h

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 drivers/iio/adc/adi-axi-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c
index 61ab7dce43be66868f09c41df18d09259db0cee3..068a1f61c6329967e39e8fcde70f0c903aaa6393 100644
--- a/drivers/iio/adc/adi-axi-adc.c
+++ b/drivers/iio/adc/adi-axi-adc.c
@@ -14,7 +14,7 @@
 #include <linux/delay.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
-#include <linux/of.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 #include <linux/property.h>
 #include <linux/regmap.h>

---
base-commit: c0f115a8d97599623294c8e9ec28530e19c1e85b
change-id: 20250218-dev-axi-adc-fix-headers-b2dd1dbd1be6
--

Thanks!
- Nuno Sá



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] iio: adc: adi-axi-adc: replace of.h with mod_devicetable.h
  2025-02-18 10:34 [PATCH] iio: adc: adi-axi-adc: replace of.h with mod_devicetable.h Nuno Sá via B4 Relay
@ 2025-02-18 15:54 ` David Lechner
  2025-02-22 14:24   ` Jonathan Cameron
  2025-02-22 21:00 ` Andy Shevchenko
  1 sibling, 1 reply; 7+ messages in thread
From: David Lechner @ 2025-02-18 15:54 UTC (permalink / raw)
  To: nuno.sa, linux-iio
  Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron

On 2/18/25 4:34 AM, Nuno Sá via B4 Relay wrote:
> From: Nuno Sá <nuno.sa@analog.com>
> 
> Don't use of.h in order to include mod_devicetable.h. Use it directly as
> there no direct dependency on OF.h
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---

Reviewed-by: David Lechner <dlechner@baylibre.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] iio: adc: adi-axi-adc: replace of.h with mod_devicetable.h
  2025-02-18 15:54 ` David Lechner
@ 2025-02-22 14:24   ` Jonathan Cameron
  0 siblings, 0 replies; 7+ messages in thread
From: Jonathan Cameron @ 2025-02-22 14:24 UTC (permalink / raw)
  To: David Lechner; +Cc: nuno.sa, linux-iio, Lars-Peter Clausen, Michael Hennerich

On Tue, 18 Feb 2025 09:54:23 -0600
David Lechner <dlechner@baylibre.com> wrote:

> On 2/18/25 4:34 AM, Nuno Sá via B4 Relay wrote:
> > From: Nuno Sá <nuno.sa@analog.com>
> > 
> > Don't use of.h in order to include mod_devicetable.h. Use it directly as
> > there no direct dependency on OF.h
> > 
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---  
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> 
> 

Applied

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] iio: adc: adi-axi-adc: replace of.h with mod_devicetable.h
  2025-02-18 10:34 [PATCH] iio: adc: adi-axi-adc: replace of.h with mod_devicetable.h Nuno Sá via B4 Relay
  2025-02-18 15:54 ` David Lechner
@ 2025-02-22 21:00 ` Andy Shevchenko
  2025-02-25  9:18   ` Nuno Sá
  1 sibling, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2025-02-22 21:00 UTC (permalink / raw)
  To: Nuno Sá
  Cc: linux-iio, Lars-Peter Clausen, Michael Hennerich,
	Jonathan Cameron

Tue, Feb 18, 2025 at 10:34:57AM +0000, Nuno Sá kirjoitti:
> Don't use of.h in order to include mod_devicetable.h. Use it directly as
> there no direct dependency on OF.h

...

>  #include <linux/delay.h>
>  #include <linux/module.h>
>  #include <linux/mutex.h>
> -#include <linux/of.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/platform_device.h>
>  #include <linux/property.h>
>  #include <linux/regmap.h>

Can we preserve the alpabetical ordering?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] iio: adc: adi-axi-adc: replace of.h with mod_devicetable.h
  2025-02-22 21:00 ` Andy Shevchenko
@ 2025-02-25  9:18   ` Nuno Sá
  2025-03-01  3:37     ` Jonathan Cameron
  0 siblings, 1 reply; 7+ messages in thread
From: Nuno Sá @ 2025-02-25  9:18 UTC (permalink / raw)
  To: Andy Shevchenko, Nuno Sá
  Cc: linux-iio, Lars-Peter Clausen, Michael Hennerich,
	Jonathan Cameron

On Sat, 2025-02-22 at 23:00 +0200, Andy Shevchenko wrote:
> Tue, Feb 18, 2025 at 10:34:57AM +0000, Nuno Sá kirjoitti:
> > Don't use of.h in order to include mod_devicetable.h. Use it directly as
> > there no direct dependency on OF.h
> 
> ...
> 
> >  #include <linux/delay.h>
> >  #include <linux/module.h>
> >  #include <linux/mutex.h>
> > -#include <linux/of.h>
> > +#include <linux/mod_devicetable.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/property.h>
> >  #include <linux/regmap.h>
> 
> Can we preserve the alpabetical ordering?
> 

Ups, my bad. Jonathan, should I re-spin or can you directly tweak it?

- Nuno Sá

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] iio: adc: adi-axi-adc: replace of.h with mod_devicetable.h
  2025-02-25  9:18   ` Nuno Sá
@ 2025-03-01  3:37     ` Jonathan Cameron
  2025-03-02 11:28       ` Andy Shevchenko
  0 siblings, 1 reply; 7+ messages in thread
From: Jonathan Cameron @ 2025-03-01  3:37 UTC (permalink / raw)
  To: Nuno Sá
  Cc: Andy Shevchenko, Nuno Sá, linux-iio, Lars-Peter Clausen,
	Michael Hennerich

On Tue, 25 Feb 2025 09:18:38 +0000
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Sat, 2025-02-22 at 23:00 +0200, Andy Shevchenko wrote:
> > Tue, Feb 18, 2025 at 10:34:57AM +0000, Nuno Sá kirjoitti:  
> > > Don't use of.h in order to include mod_devicetable.h. Use it directly as
> > > there no direct dependency on OF.h  
> > 
> > ...
> >   
> > >  #include <linux/delay.h>
> > >  #include <linux/module.h>
> > >  #include <linux/mutex.h>
> > > -#include <linux/of.h>
> > > +#include <linux/mod_devicetable.h>
> > >  #include <linux/platform_device.h>
> > >  #include <linux/property.h>
> > >  #include <linux/regmap.h>  
> > 
> > Can we preserve the alpabetical ordering?
> >   
> 
> Ups, my bad. Jonathan, should I re-spin or can you directly tweak it?

Tweaked.  

Thanks,

Jonathan

> 
> - Nuno Sá


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] iio: adc: adi-axi-adc: replace of.h with mod_devicetable.h
  2025-03-01  3:37     ` Jonathan Cameron
@ 2025-03-02 11:28       ` Andy Shevchenko
  0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2025-03-02 11:28 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Nuno Sá, Andy Shevchenko, Nuno Sá, linux-iio,
	Lars-Peter Clausen, Michael Hennerich

Sat, Mar 01, 2025 at 03:37:25AM +0000, Jonathan Cameron kirjoitti:
> On Tue, 25 Feb 2025 09:18:38 +0000
> Nuno Sá <noname.nuno@gmail.com> wrote:
> > On Sat, 2025-02-22 at 23:00 +0200, Andy Shevchenko wrote:
> > > Tue, Feb 18, 2025 at 10:34:57AM +0000, Nuno Sá kirjoitti:  
> > > > Don't use of.h in order to include mod_devicetable.h. Use it directly as
> > > > there no direct dependency on OF.h  

Just noticed a stray 'h' at the end.

...

> > > >  #include <linux/delay.h>
> > > >  #include <linux/module.h>
> > > >  #include <linux/mutex.h>
> > > > -#include <linux/of.h>
> > > > +#include <linux/mod_devicetable.h>
> > > >  #include <linux/platform_device.h>
> > > >  #include <linux/property.h>
> > > >  #include <linux/regmap.h>  
> > > 
> > > Can we preserve the alpabetical ordering?
> > >   
> > 
> > Ups, my bad. Jonathan, should I re-spin or can you directly tweak it?
> 
> Tweaked.  

One more time, please? :-)

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-03-02 11:29 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-18 10:34 [PATCH] iio: adc: adi-axi-adc: replace of.h with mod_devicetable.h Nuno Sá via B4 Relay
2025-02-18 15:54 ` David Lechner
2025-02-22 14:24   ` Jonathan Cameron
2025-02-22 21:00 ` Andy Shevchenko
2025-02-25  9:18   ` Nuno Sá
2025-03-01  3:37     ` Jonathan Cameron
2025-03-02 11:28       ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox