[PATCH] iio: hmc5843 : trivial changes to the way scale is reported

[PATCH] iio: hmc5843 : trivial changes to the way scale is reported

[Shubhrajyoti D]

Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
 drivers/staging/iio/magnetometer/hmc5843.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
index 66aab5a..b35b443 100644
--- a/drivers/staging/iio/magnetometer/hmc5843.c
+++ b/drivers/staging/iio/magnetometer/hmc5843.c
@@ -465,7 +465,7 @@ static ssize_t show_scale(struct device *dev,
 {
 	struct iio_dev *indio_dev = dev_get_drvdata(dev);
 	struct hmc5843_data *data = indio_dev->dev_data;
-	return strlen(strcpy(buf, regval_to_scale[data->range]));
+	return sprintf(buf, "%s\n", regval_to_scale[data->range]);
 }
 static IIO_DEVICE_ATTR(magn_scale,
 			S_IRUGO,
-- 
1.7.0.4

Re: [PATCH] iio: hmc5843 : trivial changes to the way scale is reported

[Jonathan Cameron]

On 09/03/10 11:07, Shubhrajyoti D wrote:
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>

Thanks.
Please forward to Greg KH <greg@kroah.com>
(or I can add it to my next series if you prefer.)

Jonathan
> ---
>  drivers/staging/iio/magnetometer/hmc5843.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
> index 66aab5a..b35b443 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843.c
> @@ -465,7 +465,7 @@ static ssize_t show_scale(struct device *dev,
>  {
>  	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>  	struct hmc5843_data *data = indio_dev->dev_data;
> -	return strlen(strcpy(buf, regval_to_scale[data->range]));
> +	return sprintf(buf, "%s\n", regval_to_scale[data->range]);
>  }
>  static IIO_DEVICE_ATTR(magn_scale,
>  			S_IRUGO,

RE: [PATCH] iio: hmc5843 : trivial changes to the way scale is reported

[Datta, Shubhrajyoti]

> -----Original Message-----
> From: Jonathan Cameron [mailto:jic23@cam.ac.uk]
> Sent: Saturday, September 04, 2010 9:32 PM
> To: Datta, Shubhrajyoti
> Cc: linux-iio@vger.kernel.org
> Subject: Re: [PATCH] iio: hmc5843 : trivial changes to the way scale is
> reported
>=20
> On 09/03/10 11:07, Shubhrajyoti D wrote:
> > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
>=20
> Thanks.
> Please forward to Greg KH <greg@kroah.com>
> (or I can add it to my next series if you prefer.)
>=20
Ya thanks feel free to take line it in the next series.
> Jonathan
> > ---
> >  drivers/staging/iio/magnetometer/hmc5843.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/iio/magnetometer/hmc5843.c
> b/drivers/staging/iio/magnetometer/hmc5843.c
> > index 66aab5a..b35b443 100644
> > --- a/drivers/staging/iio/magnetometer/hmc5843.c
> > +++ b/drivers/staging/iio/magnetometer/hmc5843.c
> > @@ -465,7 +465,7 @@ static ssize_t show_scale(struct device *dev,
> >  {
> >  	struct iio_dev *indio_dev =3D dev_get_drvdata(dev);
> >  	struct hmc5843_data *data =3D indio_dev->dev_data;
> > -	return strlen(strcpy(buf, regval_to_scale[data->range]));
> > +	return sprintf(buf, "%s\n", regval_to_scale[data->range]);
> >  }
> >  static IIO_DEVICE_ATTR(magn_scale,
> >  			S_IRUGO,