From: Jonathan Cameron <jic23@cam.ac.uk>
To: shubhrajyoti@ti.com
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH ]hmc5843: Convert to dev pm ops
Date: Tue, 18 Jan 2011 11:09:36 +0000 [thread overview]
Message-ID: <4D3574F0.2000109@cam.ac.uk> (raw)
In-Reply-To: <1295333951-3793-1-git-send-email-shubhrajyoti@ti.com>
On 01/18/11 06:59, shubhrajyoti@ti.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti@ti.com>
>
>
One quick query inline.
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti@ti.com>
> ---
> drivers/staging/iio/magnetometer/hmc5843.c | 18 ++++++++++++------
> 1 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
> index 5168917..b1c26d8 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843.c
> @@ -583,20 +583,25 @@ static int hmc5843_remove(struct i2c_client *client)
> kfree(i2c_get_clientdata(client));
> return 0;
> }
> -
> -static int hmc5843_suspend(struct i2c_client *client, pm_message_t mesg)
> +#ifdef CONFIG_PM
> +static int hmc5843_suspend(struct device *dev)
> {
> + struct i2c_client *client = to_i2c_client(dev);
> hmc5843_configure(client, MODE_SLEEP);
> return 0;
> }
>
> -static int hmc5843_resume(struct i2c_client *client)
> +static int hmc5843_resume(struct device *dev)
> {
> + struct i2c_client *client = to_i2c_client(dev);
> struct hmc5843_data *data = i2c_get_clientdata(client);
> hmc5843_configure(client, data->operating_mode);
> return 0;
> }
> -
> +static SIMPLE_DEV_PM_OPS(hmc5843_pm, hmc5843_suspend, hmc5843_resume);
> +#else
> +#define hmc5843_pm NULL
Is this needed given at a quick glance, it doesn't look like hmc5843_pm
is used anywhere if CONFIG_PM isn't defined? (it's protected below as
well)
> +#endif
> static const struct i2c_device_id hmc5843_id[] = {
> { "hmc5843", 0 },
> { }
> @@ -605,14 +610,15 @@ static const struct i2c_device_id hmc5843_id[] = {
> static struct i2c_driver hmc5843_driver = {
> .driver = {
> .name = "hmc5843",
> +#ifdef CONFIG_PM
> + .pm = &hmc5843_pm,
> +#endif
> },
> .id_table = hmc5843_id,
> .probe = hmc5843_probe,
> .remove = hmc5843_remove,
> .detect = hmc5843_detect,
> .address_list = normal_i2c,
> - .suspend = hmc5843_suspend,
> - .resume = hmc5843_resume,
> };
>
> static int __init hmc5843_init(void)
next prev parent reply other threads:[~2011-01-18 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 6:59 [PATCH ]hmc5843: Convert to dev pm ops shubhrajyoti
2011-01-18 6:59 ` [PATCH ] hmc5843: Trivial optimisation shubhrajyoti
2011-01-18 11:14 ` Jonathan Cameron
2011-01-18 11:09 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-18 11:42 [PATCH] hmc5843: Convert to dev pm ops shubhrajyoti
2011-01-18 11:48 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3574F0.2000109@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox