From: Jonathan Cameron <jic23@cam.ac.uk>
To: shubhrajyoti@ti.com
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH ] hmc5843: Trivial optimisation
Date: Tue, 18 Jan 2011 11:14:42 +0000 [thread overview]
Message-ID: <4D357622.1070908@cam.ac.uk> (raw)
In-Reply-To: <1295333951-3793-2-git-send-email-shubhrajyoti@ti.com>
On 01/18/11 06:59, shubhrajyoti@ti.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti@ti.com>
>
> Free the memory that is used only at init
hmc5843_init_client is only called by probe.
Could also be marked as devinit for consistency
and possible tiny saving in memory...
Otherwise all fine with me, please forward to GregKH.
>
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti@ti.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> drivers/staging/iio/magnetometer/hmc5843.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
> index b1c26d8..9df66cd 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843.c
> @@ -529,7 +529,7 @@ static void hmc5843_init_client(struct i2c_client *client)
> pr_info("HMC5843 initialized\n");
> }
>
> -static int hmc5843_probe(struct i2c_client *client,
> +static int __devinit hmc5843_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct hmc5843_data *data;
> @@ -574,7 +574,7 @@ exit:
> return err;
> }
>
> -static int hmc5843_remove(struct i2c_client *client)
> +static int __devexit hmc5843_remove(struct i2c_client *client)
> {
> struct hmc5843_data *data = i2c_get_clientdata(client);
> /* sleep mode to save power */
> @@ -616,7 +616,7 @@ static struct i2c_driver hmc5843_driver = {
> },
> .id_table = hmc5843_id,
> .probe = hmc5843_probe,
> - .remove = hmc5843_remove,
> + .remove = __devexit_p(hmc5843_remove),
> .detect = hmc5843_detect,
> .address_list = normal_i2c,
> };
next prev parent reply other threads:[~2011-01-18 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 6:59 [PATCH ]hmc5843: Convert to dev pm ops shubhrajyoti
2011-01-18 6:59 ` [PATCH ] hmc5843: Trivial optimisation shubhrajyoti
2011-01-18 11:14 ` Jonathan Cameron [this message]
2011-01-18 11:09 ` [PATCH ]hmc5843: Convert to dev pm ops Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2011-01-19 10:02 [PATCH] hmc5843: Trivial optimisation shubhrajyoti
2011-01-19 10:05 ` Shubhrajyoti
2011-01-19 10:04 shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D357622.1070908@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox