From: Jonathan Cameron <jic23@cam.ac.uk>
To: shubhrajyoti@ti.com
Cc: linux-iio@vger.kernel.org, achew@nvidia.com
Subject: Re: [PATCH] [RFC] ak8975: Trivial optimisations
Date: Tue, 18 Jan 2011 11:15:43 +0000 [thread overview]
Message-ID: <4D35765F.6060406@cam.ac.uk> (raw)
In-Reply-To: <1295333911-3762-1-git-send-email-shubhrajyoti@ti.com>
On 01/18/11 06:58, shubhrajyoti@ti.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti@ti.com>
>
> The probe memory could be freed after init.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti@ti.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Probably best to wait for Andrew to reply before sending this one on...
> ---
> Compile tested only.
> drivers/staging/iio/magnetometer/ak8975.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c
> index 420f206..694da1e 100644
> --- a/drivers/staging/iio/magnetometer/ak8975.c
> +++ b/drivers/staging/iio/magnetometer/ak8975.c
> @@ -431,7 +431,7 @@ static struct attribute_group ak8975_attr_group = {
> .attrs = ak8975_attr,
> };
>
> -static int ak8975_probe(struct i2c_client *client,
> +static int __devinit ak8975_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct ak8975_data *data;
> @@ -510,7 +510,7 @@ exit:
> return err;
> }
>
> -static int ak8975_remove(struct i2c_client *client)
> +static int __devexit ak8975_remove(struct i2c_client *client)
> {
> struct ak8975_data *data = i2c_get_clientdata(client);
>
next prev parent reply other threads:[~2011-01-18 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 6:58 [PATCH] [RFC] ak8975: Trivial optimisations shubhrajyoti
2011-01-18 11:15 ` Jonathan Cameron [this message]
2011-01-18 11:49 ` Shubhrajyoti
2011-01-18 19:59 ` Andrew Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D35765F.6060406@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=achew@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox