[PATCH] [RFC] ak8975: Trivial optimisations

[PATCH] [RFC] ak8975: Trivial optimisations

[shubhrajyoti]

From: Shubhrajyoti Datta <shubhrajyoti@ti.com>

The probe memory could be freed after init.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti@ti.com>
---
Compile tested only.
 drivers/staging/iio/magnetometer/ak8975.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c
index 420f206..694da1e 100644
--- a/drivers/staging/iio/magnetometer/ak8975.c
+++ b/drivers/staging/iio/magnetometer/ak8975.c
@@ -431,7 +431,7 @@ static struct attribute_group ak8975_attr_group = {
 	.attrs = ak8975_attr,
 };
 
-static int ak8975_probe(struct i2c_client *client,
+static int __devinit ak8975_probe(struct i2c_client *client,
 			const struct i2c_device_id *id)
 {
 	struct ak8975_data *data;
@@ -510,7 +510,7 @@ exit:
 	return err;
 }
 
-static int ak8975_remove(struct i2c_client *client)
+static int  __devexit ak8975_remove(struct i2c_client *client)
 {
 	struct ak8975_data *data = i2c_get_clientdata(client);
 
-- 
1.7.1

Re: [PATCH] [RFC] ak8975: Trivial optimisations

[Jonathan Cameron]

On 01/18/11 06:58, shubhrajyoti@ti.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti@ti.com>
> 
> The probe memory could be freed after init.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti@ti.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>

Probably best to wait for Andrew to reply before sending this one on...
> ---
> Compile tested only.
>  drivers/staging/iio/magnetometer/ak8975.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c
> index 420f206..694da1e 100644
> --- a/drivers/staging/iio/magnetometer/ak8975.c
> +++ b/drivers/staging/iio/magnetometer/ak8975.c
> @@ -431,7 +431,7 @@ static struct attribute_group ak8975_attr_group = {
>  	.attrs = ak8975_attr,
>  };
>  
> -static int ak8975_probe(struct i2c_client *client,
> +static int __devinit ak8975_probe(struct i2c_client *client,
>  			const struct i2c_device_id *id)
>  {
>  	struct ak8975_data *data;
> @@ -510,7 +510,7 @@ exit:
>  	return err;
>  }
>  
> -static int ak8975_remove(struct i2c_client *client)
> +static int  __devexit ak8975_remove(struct i2c_client *client)
>  {
>  	struct ak8975_data *data = i2c_get_clientdata(client);
>  

Re: [PATCH] [RFC] ak8975: Trivial optimisations

[Shubhrajyoti]

On Tuesday 18 January 2011 04:45 PM, Jonathan Cameron wrote:
> On 01/18/11 06:58, shubhrajyoti@ti.com wrote:
>> From: Shubhrajyoti Datta<shubhrajyoti@ti.com>
>>
>> The probe memory could be freed after init.
>>
>> Signed-off-by: Shubhrajyoti Datta<shubhrajyoti@ti.com>
> Acked-by: Jonathan Cameron<jic23@cam.ac.uk>
>
> Probably best to wait for Andrew to reply before sending this one on...
Yes , sure.
>> ---
>> Compile tested only.
>>   drivers/staging/iio/magnetometer/ak8975.c |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c
>> index 420f206..694da1e 100644
>> --- a/drivers/staging/iio/magnetometer/ak8975.c
>> +++ b/drivers/staging/iio/magnetometer/ak8975.c
>> @@ -431,7 +431,7 @@ static struct attribute_group ak8975_attr_group = {
>>   	.attrs = ak8975_attr,
>>   };
>>
>> -static int ak8975_probe(struct i2c_client *client,
>> +static int __devinit ak8975_probe(struct i2c_client *client,
>>   			const struct i2c_device_id *id)
>>   {
>>   	struct ak8975_data *data;
>> @@ -510,7 +510,7 @@ exit:
>>   	return err;
>>   }
>>
>> -static int ak8975_remove(struct i2c_client *client)
>> +static int  __devexit ak8975_remove(struct i2c_client *client)
>>   {
>>   	struct ak8975_data *data = i2c_get_clientdata(client);
>>

RE: [PATCH] [RFC] ak8975: Trivial optimisations

[Andrew Chew]

> >> Signed-off-by: Shubhrajyoti Datta<shubhrajyoti@ti.com>
> > Acked-by: Jonathan Cameron<jic23@cam.ac.uk>
> >
> > Probably best to wait for Andrew to reply before sending=20
> this one on...
> Yes , sure.

LGTM.

Acked-by: Andrew Chew <achew@nvidia.com>
-------------------------------------------------------------------------=
----------
This email message is for the sole use of the intended recipient(s) and m=
ay contain
confidential information.  Any unauthorized review, use, disclosure or di=
stribution
is prohibited.  If you are not the intended recipient, please contact the=
=20sender by
reply email and destroy all copies of the original message.
-------------------------------------------------------------------------=
----------