* RFC small change to tsl2563 event interface.
@ 2011-05-04 9:37 Jonathan Cameron
2011-05-04 12:08 ` Amit Kucheria
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cameron @ 2011-05-04 9:37 UTC (permalink / raw)
To: Amit Kucheria, linux-iio@vger.kernel.org
Hi Amit,
As part of moving to an registration of IIO channels through
a table of iio_chan_spec structures, I'm proposing to make
a small change to the event interface for the tsl2563 driver.
Currently it has
intensity0_both_thresh_en as a single sysfs attr enabling both
rising and falling attributes (which have separate value attributes).
I propose changing this to a pair of attrs which are interlinked
(e.g. change one and you'll change the other - our interface
spec has always allowed this as it's vital in more complex
interlinked event cases).
intensity0_both_thresh_falling_en intensity0_both_thresh_rising_en
It removes a fiddly special case (which I haven't figured out how to
do!) from the core code.
Any objections to this?
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: RFC small change to tsl2563 event interface.
2011-05-04 9:37 RFC small change to tsl2563 event interface Jonathan Cameron
@ 2011-05-04 12:08 ` Amit Kucheria
0 siblings, 0 replies; 2+ messages in thread
From: Amit Kucheria @ 2011-05-04 12:08 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio@vger.kernel.org
On Wed, May 4, 2011 at 12:37 PM, Jonathan Cameron <jic23@cam.ac.uk> wrote:
> Hi Amit,
>
> As part of moving to an registration of IIO channels through
> a table of iio_chan_spec structures, I'm proposing to make
> a small change to the event interface for the tsl2563 driver.
>
> Currently it has
>
> =A0intensity0_both_thresh_en as a single sysfs attr enabling both
> rising and falling attributes (which have separate value attributes).
>
> I propose changing this to a pair of attrs which are interlinked
> (e.g. change one and you'll change the other - our interface
> spec has always allowed this as it's vital in more complex
> interlinked event cases).
>
> intensity0_both_thresh_falling_en =A0 =A0 intensity0_both_thresh_rising_e=
n
>
> It removes a fiddly special case (which I haven't figured out how to
> do!) from the core code.
>
> Any objections to this?
>
No real objections.
Cheers,
Amit
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-04 12:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-04 9:37 RFC small change to tsl2563 event interface Jonathan Cameron
2011-05-04 12:08 ` Amit Kucheria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox