From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"device-drivers-devel@blackfin.uclinux.org"
<device-drivers-devel@blackfin.uclinux.org>
Subject: Re: [PATCH 0/2] blue part 6: IIO abi rework
Date: Thu, 28 Jul 2011 09:03:41 +0100 [thread overview]
Message-ID: <4E3117DD.9060904@cam.ac.uk> (raw)
In-Reply-To: <4E3023A3.80604@analog.com>
On 07/27/11 15:41, Michael Hennerich wrote:
> On 07/26/2011 01:06 PM, Jonathan Cameron wrote:
>> On 07/26/11 11:52, Michael Hennerich wrote:
>>> On 07/26/2011 11:17 AM, Jonathan Cameron wrote:
>>>> On 07/26/11 10:01, Hennerich, Michael wrote:
>>>>> Jonathan Cameron wrote on 2011-07-25:
>>>>>> Michael pointed out the issues that not having an explicit direction
>>>>>> for channels was causing and the inconsistency of the inX and outX
>>>>>> channel naming we got from hmwon.
>>>>>>
>>>>>> They are stuck with it, but we aren't, so lets fix this now.
>>>>>>
>>>>>> Interesting question is whether we reset the base units to be volts
>>>>>> whilst we are at it? (for voltage channels obviously!)
>>>>> What do you mean exactly volts versus milli volts?
>>>> Make the in_voltage_scale correspond to conversion to volts instead of
>>>> millivolts as now (I think). Err. Looking at it that isn't actually documented...
>>>> oops. I wonder which drivers actually do that and which don't.
>>> The ones I wrote provide the scale for millivolts.
>>> With the recent introduction of IIO_VAL_INT_PLUS_NANO we got
>>> the scale accurate enough for the precession 24-bit converters.
>>> If we move to the SI base unit volt, we lose this accuracy again.
>> Yup, that's the principal counter argument to the change.
> If we decide to leave the milli scale for volts...
> Do we also want to stay with milli degrees Celsius, etc.?
If we do it for one, probably best to do it for them all..
>
> One other thing we should also address is the byte-ordering/endianess of
> the scan elements stored in the ring buffers.
>
> Right now the scan_element type details signs, bits, storage bits and shifts.
> However it lacks to tell the endianess within the storage bits.
Good point. I'd completely forgotten about that.
>
> How about le:s16/32>>0 or be:s16/32>>0 for example?
Yup, that works for me. In cases where it doesn't matter they driver can
pick one at random.
Jonathan
next prev parent reply other threads:[~2011-07-28 7:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 13:23 [PATCH 0/2] blue part 6: IIO abi rework Jonathan Cameron
2011-07-25 13:23 ` [PATCH 1/2] staging:iio: ABI rework - add in_ or out_ prefix to channnels Jonathan Cameron
2011-07-25 15:19 ` Jonathan Cameron
2011-07-25 13:23 ` [PATCH 2/2] staging:iio:Documentation sysfs-bus-iio add in and out prefixes Jonathan Cameron
2011-07-26 9:01 ` [PATCH 0/2] blue part 6: IIO abi rework Hennerich, Michael
2011-07-26 9:17 ` Jonathan Cameron
2011-07-26 10:52 ` Michael Hennerich
2011-07-26 11:06 ` Jonathan Cameron
2011-07-27 14:41 ` Michael Hennerich
2011-07-28 8:03 ` Jonathan Cameron [this message]
2011-07-28 8:08 ` Hennerich, Michael
2011-07-28 8:33 ` Manuel Stahl
2011-07-28 9:52 ` Jonathan Cameron
2011-07-28 12:47 ` Manuel Stahl
2011-07-28 13:38 ` Jonathan Cameron
2011-07-28 8:36 ` Jonathan Cameron
2011-07-28 8:36 ` Michael Hennerich
2011-07-28 9:40 ` Jonathan Cameron
2011-07-28 9:53 ` Michael Hennerich
2011-07-28 11:58 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3117DD.9060904@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox