Re: [PATCH v4 01/10] iio: iio_buffer_register: Skip channels with negative scan index

[Jonathan Cameron <jic23@cam.ac.uk>]

On 6/18/2012 12:44 PM, Lars-Peter Clausen wrote:
> It is not always the case that all channels can be used in buffered mode. This
> patch allows channels, which can not be used in buffered mode, to set their scan
> index to a negative number, which will cause iio_buffer_register to ignore the
> channel.
>
> Signed-off-by: Lars-Peter Clausen<lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> This patch is new in v4
>
> Sorry for the extra noise, I should have noticed the problem with the ad7298
> driver earlier.
> ---
>   drivers/iio/industrialio-buffer.c |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index 2f35db9..3d8d187 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -285,6 +285,9 @@ int iio_buffer_register(struct iio_dev *indio_dev,
>   	if (channels) {
>   		/* new magic */
>   		for (i = 0; i<  num_channels; i++) {
> +			if (channels[i].scan_index<  0)
> +				continue;
> +
>   			/* Establish necessary mask length */
>   			if (channels[i].scan_index>
>   			(int)indio_dev->masklength - 1)