From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v4 01/10] iio: iio_buffer_register: Skip channels with negative scan index
Date: Mon, 18 Jun 2012 14:33:58 +0200 [thread overview]
Message-ID: <4FDF2036.7030303@metafoo.de> (raw)
In-Reply-To: <alpine.DEB.2.01.1206181414060.26163@pmeerw.net>
On 06/18/2012 02:15 PM, Peter Meerwald wrote:
>
>>> index to a negative number, which will cause iio_buffer_register to ignore
>>> the
>>> channel.
>
> ah, nice, I wondered about the same thing :)
>
>>> --- a/drivers/iio/industrialio-buffer.c
>>> +++ b/drivers/iio/industrialio-buffer.c
>>> @@ -285,6 +285,9 @@ int iio_buffer_register(struct iio_dev *indio_dev,
>>> if (channels) {
>>> /* new magic */
>>> for (i = 0; i< num_channels; i++) {
>>> + if (channels[i].scan_index< 0)
>>> + continue;
>>> +
>>> /* Establish necessary mask length */
>>> if (channels[i].scan_index>
>>> (int)indio_dev->masklength - 1)
>
> whitespace before/after < could be improved
>
That's not in the original patch, Jonathan's mail client seems to like to
mess-up whitespace when quoting a mail. You'll get used to it ;)
- Lars
next prev parent reply other threads:[~2012-06-18 12:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 11:44 [PATCH v4 01/10] iio: iio_buffer_register: Skip channels with negative scan index Lars-Peter Clausen
2012-06-18 11:44 ` [PATCH v4 02/10] iio: Add helper function for initializing triggered buffers Lars-Peter Clausen
2012-06-18 11:44 ` [PATCH v4 03/10] iio:adc:at91: Use new triggered buffer setup helper Lars-Peter Clausen
2012-06-18 11:44 ` [PATCH v4 04/10] staging:iio:adc:ad7192: Use new triggered buffer setup helper function Lars-Peter Clausen
2012-06-18 11:44 ` [PATCH v4 05/10] staging:iio:adc:ad7298: " Lars-Peter Clausen
2012-06-18 12:09 ` Jonathan Cameron
2012-06-18 11:44 ` [PATCH v4 06/10] staging:iio:adc:ad7476: " Lars-Peter Clausen
2012-06-18 11:45 ` [PATCH v4 07/10] staging:iio:adc:ad7606: " Lars-Peter Clausen
2012-06-18 11:45 ` [PATCH v4 08/10] staging:iio:adc:ad7793: " Lars-Peter Clausen
2012-06-18 11:45 ` [PATCH v4 09/10] staging:iio:adc:ad7887: " Lars-Peter Clausen
2012-06-18 11:45 ` [PATCH v4 10/10] staging:iio:adc:ad799x: " Lars-Peter Clausen
2012-06-18 12:08 ` [PATCH v4 01/10] iio: iio_buffer_register: Skip channels with negative scan index Jonathan Cameron
2012-06-18 12:15 ` Peter Meerwald
2012-06-18 12:33 ` Lars-Peter Clausen [this message]
2012-06-18 12:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDF2036.7030303@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox