lis3l02dq_core fails to compile

lis3l02dq_core fails to compile

[Peter Meerwald]

Hello,

staging/iio/accel/lis3l02dq_core.c fails to compile when irq_to_gpio() is 
not available

the solution is to pass both, irq and gpio via platform data (e.g. as 
done by staging/iio/magnetometer/ak8975.c)?

regards, p.

-- 

Peter Meerwald
+43-664-2444418 (mobile)

Re: lis3l02dq_core fails to compile

[Lars-Peter Clausen]

On 08/06/2012 10:39 AM, Peter Meerwald wrote:
> Hello,
> 
> staging/iio/accel/lis3l02dq_core.c fails to compile when irq_to_gpio() is 
> not available
> 
> the solution is to pass both, irq and gpio via platform data (e.g. as 
> done by staging/iio/magnetometer/ak8975.c)?
> 

gpio_to_irq will always be available. While irq_to_gpio is deprecated. So it
should work if you just pass the gpio.

But looking at the driver it only seems to check if the IRQ is a valid GPIO,
but never seems use the GPIO pin otherwise. Maybe I missed something, but
I'd just remove the whole  gpio_is_valid(irq_to_gpio(spi->irq)) check.

- Lars

Re: lis3l02dq_core fails to compile

[Peter Meerwald]

Hello,

> > staging/iio/accel/lis3l02dq_core.c fails to compile when irq_to_gpio() is 
> > not available
> > 
> > the solution is to pass both, irq and gpio via platform data (e.g. as 
> > done by staging/iio/magnetometer/ak8975.c)?

> gpio_to_irq will always be available. While irq_to_gpio is deprecated. So it
> should work if you just pass the gpio.

so: pass gpio via platform data, and derive irq from that

> But looking at the driver it only seems to check if the IRQ is a valid GPIO,
> but never seems use the GPIO pin otherwise. Maybe I missed something, but
> I'd just remove the whole  gpio_is_valid(irq_to_gpio(spi->irq)) check.

the irq is used in lis3l02dq_ring.c (I should have pointed that out):

static int lis3l02dq_trig_try_reen(struct iio_trigger *trig)
...
		if (gpio_get_value(irq_to_gpio(st->us->irq)))

p.

-- 

Peter Meerwald
+43-664-2444418 (mobile)