From: Hartmut Knaack <knaack.h@gmx.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Cameron <jic23@cam.ac.uk>,
lm-sensors@lm-sensors.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 4/9] hwmon: (adt7410) Use I2C_ADDRS helper macro
Date: Wed, 20 Feb 2013 00:17:09 +0100 [thread overview]
Message-ID: <512407F5.2050802@gmx.de> (raw)
In-Reply-To: <1360947438-2550-4-git-send-email-lars@metafoo.de>
Lars-Peter Clausen schrieb:
> Use the I2C_ADDRS macro to initialize the I2C device's address_list. Doing so
> saves a few lines of boilerplate code.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Hartmut Knaack <knaack.h@gmx.de>
> ---
> drivers/hwmon/adt7410.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c
> index 4ae16e0..99f6d32 100644
> --- a/drivers/hwmon/adt7410.c
> +++ b/drivers/hwmon/adt7410.c
> @@ -78,10 +78,6 @@ enum adt7410_type { /* keep sorted in alphabetical order */
> adt7410,
> };
>
> -/* Addresses scanned */
> -static const unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b,
> - I2C_CLIENT_END };
> -
> static const u8 ADT7410_REG_TEMP[4] = {
> ADT7410_TEMPERATURE, /* input */
> ADT7410_T_ALARM_HIGH, /* high */
> @@ -453,7 +449,7 @@ static struct i2c_driver adt7410_driver = {
> .probe = adt7410_probe,
> .remove = adt7410_remove,
> .id_table = adt7410_ids,
> - .address_list = normal_i2c,
> + .address_list = I2C_ADDRS(0x48, 0x49, 0x4a, 0x4b),
> };
>
> module_i2c_driver(adt7410_driver);
next prev parent reply other threads:[~2013-02-19 23:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 16:57 [PATCH 1/9] hwmon: (adt7410) Clear unwanted bits in the config register Lars-Peter Clausen
2013-02-15 16:57 ` [PATCH 2/9] hwmon: (adt7410) Let suspend/resume depend on CONFIG_PM_SLEEP Lars-Peter Clausen
2013-02-15 20:07 ` Guenter Roeck
2013-02-19 23:07 ` Hartmut Knaack
2013-02-15 16:57 ` [PATCH 3/9] hwmon: (adt7410) Use the SIMPLE_DEV_PM_OPS helper macro Lars-Peter Clausen
2013-02-15 20:07 ` Guenter Roeck
2013-02-19 23:13 ` Hartmut Knaack
2013-02-15 16:57 ` [PATCH 4/9] hwmon: (adt7410) Use I2C_ADDRS " Lars-Peter Clausen
2013-02-15 20:07 ` Guenter Roeck
2013-02-19 23:17 ` Hartmut Knaack [this message]
2013-02-15 16:57 ` [PATCH 5/9] hwmon: (adt7410) Add device table entry for the adt7420 Lars-Peter Clausen
2013-02-15 20:08 ` Guenter Roeck
2013-02-19 23:21 ` Hartmut Knaack
2013-02-21 0:10 ` Hartmut Knaack
2013-02-15 16:57 ` [PATCH 6/9] hwmon: (adt7410) Don't re-read non-volatile registers Lars-Peter Clausen
2013-02-15 20:20 ` Guenter Roeck
2013-02-16 15:56 ` Lars-Peter Clausen
2013-02-15 16:57 ` [PATCH 7/9] hwmon: (adt7410) Add support for the adt7310/adt7320 Lars-Peter Clausen
2013-02-15 20:05 ` Hartmut Knaack
2013-02-16 15:54 ` Lars-Peter Clausen
2013-02-15 20:32 ` Guenter Roeck
2013-02-16 16:04 ` Lars-Peter Clausen
2013-02-16 19:15 ` Guenter Roeck
2013-02-15 16:57 ` [PATCH 8/9] hwmon: (adt7x10) Add alarm interrupt support Lars-Peter Clausen
2013-02-15 16:57 ` [PATCH 9/9] staging:iio: Remove adt7410 driver Lars-Peter Clausen
2013-02-15 20:06 ` [PATCH 1/9] hwmon: (adt7410) Clear unwanted bits in the config register Guenter Roeck
2013-02-19 23:03 ` Hartmut Knaack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512407F5.2050802@gmx.de \
--to=knaack.h@gmx.de \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox