Linux IIO development
 help / color / mirror / Atom feed
* [PATCH 1/2] iio: exynos_adc: Remove redundant of_match_ptr macro
@ 2013-03-26  9:42 Sachin Kamat
  2013-03-26  9:42 ` [PATCH 2/2] iio: exynos_adc: Fix a typo in Kconfig help text Sachin Kamat
  2013-03-29  9:25 ` [PATCH 1/2] iio: exynos_adc: Remove redundant of_match_ptr macro Jonathan Cameron
  0 siblings, 2 replies; 5+ messages in thread
From: Sachin Kamat @ 2013-03-26  9:42 UTC (permalink / raw)
  To: linux-iio; +Cc: jic23, jic23, ch.naveen, sachin.kamat, patches

exynos_adc is a DT only driver and exynos_adc_match table is always
compiled in. Hence remove the macro.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/iio/adc/exynos_adc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 4a8a9a3..9f3a8ef 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -440,7 +440,7 @@ static struct platform_driver exynos_adc_driver = {
 	.driver		= {
 		.name	= "exynos-adc",
 		.owner	= THIS_MODULE,
-		.of_match_table = of_match_ptr(exynos_adc_match),
+		.of_match_table = exynos_adc_match,
 		.pm	= &exynos_adc_pm_ops,
 	},
 };
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] iio: exynos_adc: Fix a typo in Kconfig help text
  2013-03-26  9:42 [PATCH 1/2] iio: exynos_adc: Remove redundant of_match_ptr macro Sachin Kamat
@ 2013-03-26  9:42 ` Sachin Kamat
  2013-03-26 13:23   ` Naveen Krishna Ch
  2013-03-29  9:25 ` [PATCH 1/2] iio: exynos_adc: Remove redundant of_match_ptr macro Jonathan Cameron
  1 sibling, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2013-03-26  9:42 UTC (permalink / raw)
  To: linux-iio; +Cc: jic23, jic23, ch.naveen, sachin.kamat, patches

Fixes a trivial typo.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/iio/adc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index ab0767e6..718084f 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -108,7 +108,7 @@ config EXYNOS_ADC
 	depends on OF
 	help
 	  Core support for the ADC block found in the Samsung EXYNOS series
-	  of SoCs for drivers such as the touchscreen and hwmon to use to share
+	  of SoCs for drivers such as the touchscreen and hwmon to use and share
 	  this resource.
 
 config LP8788_ADC
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] iio: exynos_adc: Fix a typo in Kconfig help text
  2013-03-26  9:42 ` [PATCH 2/2] iio: exynos_adc: Fix a typo in Kconfig help text Sachin Kamat
@ 2013-03-26 13:23   ` Naveen Krishna Ch
  2013-03-29  9:26     ` Jonathan Cameron
  0 siblings, 1 reply; 5+ messages in thread
From: Naveen Krishna Ch @ 2013-03-26 13:23 UTC (permalink / raw)
  To: Sachin Kamat; +Cc: linux-iio, jic23, jic23, My self, patches

On 26 March 2013 15:12, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Fixes a trivial typo.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/iio/adc/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index ab0767e6..718084f 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -108,7 +108,7 @@ config EXYNOS_ADC
>         depends on OF
>         help
>           Core support for the ADC block found in the Samsung EXYNOS series
> -         of SoCs for drivers such as the touchscreen and hwmon to use to share
I took these lines from arch/arm/plat-samsung/Kconfig for S3C ADC.
Sure if this change makes sence.
> +         of SoCs for drivers such as the touchscreen and hwmon to use and share
>           this resource.
>
>  config LP8788_ADC
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] iio: exynos_adc: Remove redundant of_match_ptr macro
  2013-03-26  9:42 [PATCH 1/2] iio: exynos_adc: Remove redundant of_match_ptr macro Sachin Kamat
  2013-03-26  9:42 ` [PATCH 2/2] iio: exynos_adc: Fix a typo in Kconfig help text Sachin Kamat
@ 2013-03-29  9:25 ` Jonathan Cameron
  1 sibling, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2013-03-29  9:25 UTC (permalink / raw)
  To: Sachin Kamat; +Cc: linux-iio, jic23, ch.naveen, patches

On 03/26/2013 09:42 AM, Sachin Kamat wrote:
> exynos_adc is a DT only driver and exynos_adc_match table is always
> compiled in. Hence remove the macro.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to the togreg branch of iio.git
> ---
>  drivers/iio/adc/exynos_adc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index 4a8a9a3..9f3a8ef 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -440,7 +440,7 @@ static struct platform_driver exynos_adc_driver = {
>  	.driver		= {
>  		.name	= "exynos-adc",
>  		.owner	= THIS_MODULE,
> -		.of_match_table = of_match_ptr(exynos_adc_match),
> +		.of_match_table = exynos_adc_match,
>  		.pm	= &exynos_adc_pm_ops,
>  	},
>  };
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] iio: exynos_adc: Fix a typo in Kconfig help text
  2013-03-26 13:23   ` Naveen Krishna Ch
@ 2013-03-29  9:26     ` Jonathan Cameron
  0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2013-03-29  9:26 UTC (permalink / raw)
  To: Naveen Krishna Ch; +Cc: Sachin Kamat, linux-iio, My self, patches

On 03/26/2013 01:23 PM, Naveen Krishna Ch wrote:
> On 26 March 2013 15:12, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> Fixes a trivial typo.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>  drivers/iio/adc/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index ab0767e6..718084f 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -108,7 +108,7 @@ config EXYNOS_ADC
>>         depends on OF
>>         help
>>           Core support for the ADC block found in the Samsung EXYNOS series
>> -         of SoCs for drivers such as the touchscreen and hwmon to use to share
> I took these lines from arch/arm/plat-samsung/Kconfig for S3C ADC.
> Sure if this change makes sence.
Original text is just fine and has a subtly different meaning so not taking this
patch.

>> +         of SoCs for drivers such as the touchscreen and hwmon to use and share
>>           this resource.
>>
>>  config LP8788_ADC
>> --
>> 1.7.4.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 
> --
> Shine bright,
> (: Nav :)
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-03-29  9:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26  9:42 [PATCH 1/2] iio: exynos_adc: Remove redundant of_match_ptr macro Sachin Kamat
2013-03-26  9:42 ` [PATCH 2/2] iio: exynos_adc: Fix a typo in Kconfig help text Sachin Kamat
2013-03-26 13:23   ` Naveen Krishna Ch
2013-03-29  9:26     ` Jonathan Cameron
2013-03-29  9:25 ` [PATCH 1/2] iio: exynos_adc: Remove redundant of_match_ptr macro Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox