* [PATCH] iio: buffer: cleanup messages in iio_update_buffers()
@ 2013-05-04 13:19 Michał Mirosław
2013-05-06 16:14 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Michał Mirosław @ 2013-05-04 13:19 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron
1. make messages grepable (in one line)
2. include returned errno in them
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
Please ignore checkpatch long lines warning.
drivers/iio/industrialio-buffer.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index aaadd32..e73033f 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -542,8 +542,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
ret = indio_dev->setup_ops->preenable(indio_dev);
if (ret) {
printk(KERN_ERR
- "Buffer not started:"
- "buffer preenable failed\n");
+ "Buffer not started: buffer preenable failed (%d)\n", ret);
goto error_remove_inserted;
}
}
@@ -556,8 +555,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
ret = buffer->access->request_update(buffer);
if (ret) {
printk(KERN_INFO
- "Buffer not started:"
- "buffer parameter update failed\n");
+ "Buffer not started: buffer parameter update failed (%d)\n", ret);
goto error_run_postdisable;
}
}
@@ -566,7 +564,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
->update_scan_mode(indio_dev,
indio_dev->active_scan_mask);
if (ret < 0) {
- printk(KERN_INFO "update scan mode failed\n");
+ printk(KERN_INFO "Buffer not started: update scan mode failed (%d)\n", ret);
goto error_run_postdisable;
}
}
@@ -590,7 +588,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
ret = indio_dev->setup_ops->postenable(indio_dev);
if (ret) {
printk(KERN_INFO
- "Buffer not started: postenable failed\n");
+ "Buffer not started: postenable failed (%d)\n", ret);
indio_dev->currentmode = INDIO_DIRECT_MODE;
if (indio_dev->setup_ops->postdisable)
indio_dev->setup_ops->postdisable(indio_dev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: buffer: cleanup messages in iio_update_buffers()
2013-05-04 13:19 [PATCH] iio: buffer: cleanup messages in iio_update_buffers() Michał Mirosław
@ 2013-05-06 16:14 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2013-05-06 16:14 UTC (permalink / raw)
To: Michał Mirosław; +Cc: linux-iio
On 05/04/2013 02:19 PM, Michał Mirosław wrote:
> 1. make messages grepable (in one line)
> 2. include returned errno in them
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Thanks,
Applied to the togreg branch of iio.git.
> ---
> Please ignore checkpatch long lines warning.
>
> drivers/iio/industrialio-buffer.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index aaadd32..e73033f 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -542,8 +542,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
> ret = indio_dev->setup_ops->preenable(indio_dev);
> if (ret) {
> printk(KERN_ERR
> - "Buffer not started:"
> - "buffer preenable failed\n");
> + "Buffer not started: buffer preenable failed (%d)\n", ret);
> goto error_remove_inserted;
> }
> }
> @@ -556,8 +555,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
> ret = buffer->access->request_update(buffer);
> if (ret) {
> printk(KERN_INFO
> - "Buffer not started:"
> - "buffer parameter update failed\n");
> + "Buffer not started: buffer parameter update failed (%d)\n", ret);
> goto error_run_postdisable;
> }
> }
> @@ -566,7 +564,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
> ->update_scan_mode(indio_dev,
> indio_dev->active_scan_mask);
> if (ret < 0) {
> - printk(KERN_INFO "update scan mode failed\n");
> + printk(KERN_INFO "Buffer not started: update scan mode failed (%d)\n", ret);
> goto error_run_postdisable;
> }
> }
> @@ -590,7 +588,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
> ret = indio_dev->setup_ops->postenable(indio_dev);
> if (ret) {
> printk(KERN_INFO
> - "Buffer not started: postenable failed\n");
> + "Buffer not started: postenable failed (%d)\n", ret);
> indio_dev->currentmode = INDIO_DIRECT_MODE;
> if (indio_dev->setup_ops->postdisable)
> indio_dev->setup_ops->postdisable(indio_dev);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-06 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-04 13:19 [PATCH] iio: buffer: cleanup messages in iio_update_buffers() Michał Mirosław
2013-05-06 16:14 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox