hwmon: ntc_thermistor: Add another ntc(epcos) to the driver

hwmon: ntc_thermistor: Add another ntc(epcos) to the driver

[Johannes Pointner]

As I saw in the latest patches for the ntc_thermistor, in which as
part of the patch the module description changed to :

MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");

I wanted to know if it is intended to extend the driver for further
manufacturers like in my case for an epcos ntc in the future?

Of course I would create the necessary patch.

Thanks,
Hannes

Re: hwmon: ntc_thermistor: Add another ntc(epcos) to the driver

[Jean Delvare]

On Fri, 27 Jun 2014 10:50:39 +0200, Johannes Pointner wrote:
> As I saw in the latest patches for the ntc_thermistor, in which as
> part of the patch the module description changed to :
> 
> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
> 
> I wanted to know if it is intended to extend the driver for further
> manufacturers like in my case for an epcos ntc in the future?

If there is enough compatibility, then yes, of course.

> Of course I would create the necessary patch.

-- 
Jean Delvare
SUSE L3 Support

Re: hwmon: ntc_thermistor: Add another ntc(epcos) to the driver

[Guenter Roeck]

On 06/27/2014 01:50 AM, Johannes Pointner wrote:
> As I saw in the latest patches for the ntc_thermistor, in which as
> part of the patch the module description changed to :
>
> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>
> I wanted to know if it is intended to extend the driver for further
> manufacturers like in my case for an epcos ntc in the future?
>

Sure, why not ? Better than create an entirely new driver which would
be all the same but for the tables. The comment is misleading anyway
(the driver is for Murata thermistors, not from them), so we can
always drop the "from Murata".

Guenter

Re: hwmon: ntc_thermistor: Add another ntc(epcos) to the driver

[Jan Kardell]

Johannes Pointner skriver:
> As I saw in the latest patches for the ntc_thermistor, in which as
> part of the patch the module description changed to :
>
> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>
> I wanted to know if it is intended to extend the driver for further
> manufacturers like in my case for an epcos ntc in the future?
>
> Of course I would create the necessary patch.
>
> Thanks,
> Hannes
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Why not move the table to DT? There are lots of NTC types out there, and 
each type comes in an number of varietes. IMHO it seems impractical to 
change the code for each one, and the tables would grow to be very large.

//Jan

Re: hwmon: ntc_thermistor: Add another ntc(epcos) to the driver

[Guenter Roeck]

On 06/29/2014 07:23 AM, Jan Kardell wrote:
> Johannes Pointner skriver:
>> As I saw in the latest patches for the ntc_thermistor, in which as
>> part of the patch the module description changed to :
>>
>> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>>
>> I wanted to know if it is intended to extend the driver for further
>> manufacturers like in my case for an epcos ntc in the future?
>>
>> Of course I would create the necessary patch.
>>
>> Thanks,
>> Hannes
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> Why not move the table to DT? There are lots of NTC types out there, and each type comes in an number of varietes. IMHO it seems impractical to change the code for each one, and the tables would grow to be very large.
>

I would not mandate it, but I would he happy to accept a patch.

Guenter

Re: hwmon: ntc_thermistor: Add another ntc(epcos) to the driver

[Naveen Krishna Ch]

Hello Johannes Pointner skriver,


On 29 June 2014 20:41, Guenter Roeck <linux@roeck-us.net> wrote:
> On 06/29/2014 07:23 AM, Jan Kardell wrote:
>>
>> Johannes Pointner skriver:
>>>
>>> As I saw in the latest patches for the ntc_thermistor, in which as
>>> part of the patch the module description changed to :
>>>
>>> MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>>>
>>> I wanted to know if it is intended to extend the driver for further
>>> manufacturers like in my case for an epcos ntc in the future?

The ntc_thermistor.c currently, supports ncpXXXX
(all thermistors from Murata).  Thus, My assumption.

Please post your patches for supporting other thermistors. If there
is enough compatibility.

We can drop off the "from Murata" in MODULE_DESCRIPTION()
and In the Kconfig file.
I can submit a change for the same.

>>>
>>> Of course I would create the necessary patch.
>>>
>>> Thanks,
>>> Hannes
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
>> Why not move the table to DT? There are lots of NTC types out there, and
>> each type comes in an number of varietes. IMHO it seems impractical to
>> change the code for each one, and the tables would grow to be very large.
>>
>
> I would not mandate it, but I would he happy to accept a patch.
>
> Guenter
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks & Regards,
(: Nav :)