[PATCH] iio: adc: xilinx: Remove .owner field for driver

[PATCH] iio: adc: xilinx: Remove .owner field for driver

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

There is no need to init .owner field.

Based on the patch from Peter Griffin <peter.griffin@linaro.org>
"mmc: remove .owner field for drivers using module_platform_driver"

This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register anyway."

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/iio/adc/xilinx-xadc-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
index fd2745c62943..92541a80b041 100644
--- a/drivers/iio/adc/xilinx-xadc-core.c
+++ b/drivers/iio/adc/xilinx-xadc-core.c
@@ -1322,7 +1322,6 @@ static struct platform_driver xadc_driver = {
 	.remove = xadc_remove,
 	.driver = {
 		.name = "xadc",
-		.owner = THIS_MODULE,
 		.of_match_table = xadc_of_match_table,
 	},
 };
--
1.8.2.3


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] iio: adc: xilinx: Remove .owner field for driver

[Jonathan Cameron]

On 13/08/14 13:00, Michal Simek wrote:
> There is no need to init .owner field.
> 
> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
> "mmc: remove .owner field for drivers using module_platform_driver"
> 
> This patch removes the superflous .owner field for drivers which
> use the module_platform_driver API, as this is overriden in
> platform_driver_register anyway."
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Applied to the togreg branch of iio.git

Thanks,

Jonathan
> ---
> 
>  drivers/iio/adc/xilinx-xadc-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index fd2745c62943..92541a80b041 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1322,7 +1322,6 @@ static struct platform_driver xadc_driver = {
>  	.remove = xadc_remove,
>  	.driver = {
>  		.name = "xadc",
> -		.owner = THIS_MODULE,
>  		.of_match_table = xadc_of_match_table,
>  	},
>  };
> --
> 1.8.2.3
> 

Re: [PATCH] iio: adc: xilinx: Remove .owner field for driver

[sanjeev sharma]

[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]

Hi Jonathan & Michael,

There are so many occurrences in IIO directory of this .owner filed and we
need to cleanup everywhere.

Regards
Sanjeev Sharma


On Wed, Aug 20, 2014 at 12:53 AM, Jonathan Cameron <jic23@kernel.org> wrote:

> On 13/08/14 13:00, Michal Simek wrote:
> > There is no need to init .owner field.
> >
> > Based on the patch from Peter Griffin <peter.griffin@linaro.org>
> > "mmc: remove .owner field for drivers using module_platform_driver"
> >
> > This patch removes the superflous .owner field for drivers which
> > use the module_platform_driver API, as this is overriden in
> > platform_driver_register anyway."
> >
> > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Applied to the togreg branch of iio.git
>
> Thanks,
>
> Jonathan
> > ---
> >
> >  drivers/iio/adc/xilinx-xadc-core.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/xilinx-xadc-core.c
> b/drivers/iio/adc/xilinx-xadc-core.c
> > index fd2745c62943..92541a80b041 100644
> > --- a/drivers/iio/adc/xilinx-xadc-core.c
> > +++ b/drivers/iio/adc/xilinx-xadc-core.c
> > @@ -1322,7 +1322,6 @@ static struct platform_driver xadc_driver = {
> >       .remove = xadc_remove,
> >       .driver = {
> >               .name = "xadc",
> > -             .owner = THIS_MODULE,
> >               .of_match_table = xadc_of_match_table,
> >       },
> >  };
> > --
> > 1.8.2.3
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

[-- Attachment #2: Type: text/html, Size: 2592 bytes --]