From: Jonathan Cameron <jic23@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 07/27] iio: Allow compile test of GPIO consumers if !GPIOLIB
Date: Thu, 07 May 2015 11:37:29 +0100 [thread overview]
Message-ID: <554B4069.4090408@kernel.org> (raw)
In-Reply-To: <1430843563-18615-7-git-send-email-geert@linux-m68k.org>
On 05/05/15 17:32, Geert Uytterhoeven wrote:
> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
>
> Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where
> appropriate.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: linux-iio@vger.kernel.org
Not entirely convinced that the extra build coverage from this is going
to be that extensive, but it does no harm, so why not?
Applied to the togreg branch of iio.git, will sometime be pushed out
as testing, for the autobuilders to play with it, as I am travelling.
Jonathan
> ---
> drivers/iio/humidity/Kconfig | 2 +-
> drivers/iio/magnetometer/Kconfig | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
> index 4813b793b9f7f944..688c0d1cb47dea36 100644
> --- a/drivers/iio/humidity/Kconfig
> +++ b/drivers/iio/humidity/Kconfig
> @@ -5,7 +5,7 @@ menu "Humidity sensors"
>
> config DHT11
> tristate "DHT11 (and compatible sensors) driver"
> - depends on GPIOLIB
> + depends on GPIOLIB || COMPILE_TEST
> help
> This driver supports reading data via a single interrupt
> generating GPIO line. Currently tested are DHT11 and DHT22.
> diff --git a/drivers/iio/magnetometer/Kconfig b/drivers/iio/magnetometer/Kconfig
> index a5d6de72c523bab2..00297bbb7e4b4a0b 100644
> --- a/drivers/iio/magnetometer/Kconfig
> +++ b/drivers/iio/magnetometer/Kconfig
> @@ -8,7 +8,7 @@ menu "Magnetometer sensors"
> config AK8975
> tristate "Asahi Kasei AK 3-Axis Magnetometer"
> depends on I2C
> - depends on GPIOLIB
> + depends on GPIOLIB || COMPILE_TEST
> help
> Say yes here to build support for Asahi Kasei AK8975, AK8963,
> AK09911 or AK09912 3-Axis Magnetometer.
> @@ -19,7 +19,7 @@ config AK8975
> config AK09911
> tristate "Asahi Kasei AK09911 3-axis Compass"
> depends on I2C
> - depends on GPIOLIB
> + depends on GPIOLIB || COMPILE_TEST
> select AK8975
> help
> Deprecated: AK09911 is now supported by AK8975 driver.
>
next prev parent reply other threads:[~2015-05-07 23:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1430836404-15513-1-git-send-email-geert@linux-m68k.org>
[not found] ` <1430843563-18615-1-git-send-email-geert@linux-m68k.org>
2015-05-05 16:32 ` [PATCH 07/27] iio: Allow compile test of GPIO consumers if !GPIOLIB Geert Uytterhoeven
2015-05-07 10:37 ` Jonathan Cameron [this message]
2015-05-05 16:32 ` [PATCH 20/27] Staging: " Geert Uytterhoeven
2015-05-07 10:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B4069.4090408@kernel.org \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox