From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@gmail.com>, Tan Nguyen <tan.nqd@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio/accel: fixed 1 coding style problem
Date: Sun, 21 Jun 2015 10:50:11 +0100 [thread overview]
Message-ID: <558688D3.9000101@kernel.org> (raw)
In-Reply-To: <CAEnQRZBFp48M8Q_kBKh_rqCdE_6Dci3NeuxLtHSX1aiKMAikaQ@mail.gmail.com>
On 21/06/15 10:47, Daniel Baluta wrote:
> On Sat, Jun 20, 2015 at 6:43 AM, Tan Nguyen <tan.nqd@gmail.com> wrote:
>> Break line to fix "line over 80 characters" style problem.
>>
>> Signed-off-by: Tan Nguyen <tan.nqd@gmail.com>
>
> Hi Tan,
>
> The code looks better as it is. I am not in favor of this change.
>
> Daniel.
Agreed. Tan, always take the 80 character limit as a soft restriction.
You need to look at the result and decide if it helps or hurts readability.
Here it is not clear either way so we'll leave it as it currently is.
Thanks
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
prev parent reply other threads:[~2015-06-21 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 3:43 [PATCH] iio/accel: fixed 1 coding style problem Tan Nguyen
2015-06-21 9:47 ` Daniel Baluta
2015-06-21 9:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558688D3.9000101@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=tan.nqd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox