* [PATCH] iio/accel: fixed 1 coding style problem
@ 2015-06-20 3:43 Tan Nguyen
2015-06-21 9:47 ` Daniel Baluta
0 siblings, 1 reply; 3+ messages in thread
From: Tan Nguyen @ 2015-06-20 3:43 UTC (permalink / raw)
To: lars; +Cc: linux-iio
Break line to fix "line over 80 characters" style problem.
Signed-off-by: Tan Nguyen <tan.nqd@gmail.com>
---
drivers/staging/iio/accel/adis16220_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/accel/adis16220_core.c b/drivers/staging/iio/accel/adis16220_core.c
index e46a91c..60d9af4 100644
--- a/drivers/staging/iio/accel/adis16220_core.c
+++ b/drivers/staging/iio/accel/adis16220_core.c
@@ -387,7 +387,8 @@ static const struct iio_info adis16220_info = {
};
static const char * const adis16220_status_error_msgs[] = {
- [ADIS16220_DIAG_STAT_VIOLATION_BIT] = "Capture period violation/interruption",
+ [ADIS16220_DIAG_STAT_VIOLATION_BIT] =
+ "Capture period violation/interruption",
[ADIS16220_DIAG_STAT_SPI_FAIL_BIT] = "SPI failure",
[ADIS16220_DIAG_STAT_FLASH_UPT_BIT] = "Flash update failed",
[ADIS16220_DIAG_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V",
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio/accel: fixed 1 coding style problem
2015-06-20 3:43 [PATCH] iio/accel: fixed 1 coding style problem Tan Nguyen
@ 2015-06-21 9:47 ` Daniel Baluta
2015-06-21 9:50 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Baluta @ 2015-06-21 9:47 UTC (permalink / raw)
To: Tan Nguyen; +Cc: Lars-Peter Clausen, linux-iio@vger.kernel.org
On Sat, Jun 20, 2015 at 6:43 AM, Tan Nguyen <tan.nqd@gmail.com> wrote:
> Break line to fix "line over 80 characters" style problem.
>
> Signed-off-by: Tan Nguyen <tan.nqd@gmail.com>
Hi Tan,
The code looks better as it is. I am not in favor of this change.
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio/accel: fixed 1 coding style problem
2015-06-21 9:47 ` Daniel Baluta
@ 2015-06-21 9:50 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2015-06-21 9:50 UTC (permalink / raw)
To: Daniel Baluta, Tan Nguyen; +Cc: Lars-Peter Clausen, linux-iio@vger.kernel.org
On 21/06/15 10:47, Daniel Baluta wrote:
> On Sat, Jun 20, 2015 at 6:43 AM, Tan Nguyen <tan.nqd@gmail.com> wrote:
>> Break line to fix "line over 80 characters" style problem.
>>
>> Signed-off-by: Tan Nguyen <tan.nqd@gmail.com>
>
> Hi Tan,
>
> The code looks better as it is. I am not in favor of this change.
>
> Daniel.
Agreed. Tan, always take the 80 character limit as a soft restriction.
You need to look at the result and decide if it helps or hurts readability.
Here it is not clear either way so we'll leave it as it currently is.
Thanks
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-21 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-20 3:43 [PATCH] iio/accel: fixed 1 coding style problem Tan Nguyen
2015-06-21 9:47 ` Daniel Baluta
2015-06-21 9:50 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox