Re: [PATCH v2 5/7] iio:light:cm3323: replace unneeded variable

[Jonathan Cameron <jic23@kernel.org>]

On 17/06/15 23:32, Hartmut Knaack wrote:
> In cm3323_read_raw() i is used as return variable for the integration time
> index. The also existing return variable ret however is unused in this
> case, although appropriate. Replace i with ret and drop it.
> 
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
> Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
applied to the togreg branch of iio.git

Thanks,
> ---
>  drivers/iio/light/cm3323.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/light/cm3323.c b/drivers/iio/light/cm3323.c
> index 9cd7d2a..2c49ec2 100644
> --- a/drivers/iio/light/cm3323.c
> +++ b/drivers/iio/light/cm3323.c
> @@ -153,7 +153,7 @@ static int cm3323_read_raw(struct iio_dev *indio_dev,
>  			   struct iio_chan_spec const *chan, int *val,
>  			   int *val2, long mask)
>  {
> -	int i, ret;
> +	int ret;
>  	struct cm3323_data *data = iio_priv(indio_dev);
>  
>  	switch (mask) {
> @@ -170,14 +170,14 @@ static int cm3323_read_raw(struct iio_dev *indio_dev,
>  		return IIO_VAL_INT;
>  	case IIO_CHAN_INFO_INT_TIME:
>  		mutex_lock(&data->mutex);
> -		i = cm3323_get_it_bits(data);
> -		if (i < 0) {
> +		ret = cm3323_get_it_bits(data);
> +		if (ret < 0) {
>  			mutex_unlock(&data->mutex);
> -			return i;
> +			return ret;
>  		}
>  
> -		*val = cm3323_int_time[i].val;
> -		*val2 = cm3323_int_time[i].val2;
> +		*val = cm3323_int_time[ret].val;
> +		*val2 = cm3323_int_time[ret].val2;
>  		mutex_unlock(&data->mutex);
>  
>  		return IIO_VAL_INT_PLUS_MICRO;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in