public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Hartmut Knaack <knaack.h@gmx.de>, linux-iio@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Kevin Tsai <ktsai@capellamicro.com>,
	Daniel Baluta <daniel.baluta@intel.com>
Subject: Re: [PATCH v2 7/7] iio:light:cm3323: add empty lines for code structure
Date: Sun, 21 Jun 2015 14:28:44 +0100	[thread overview]
Message-ID: <5586BC0C.1040005@kernel.org> (raw)
In-Reply-To: <b12e8ab9927598c03f55206140753a33eaa53b90.1434578207.git.knaack.h@gmx.de>

On 17/06/15 23:32, Hartmut Knaack wrote:
> Add some empty lines to visually separate logical structure blocks, as
> after if-blocks or before regular returns.
> 
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
> Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
Applied.
> ---
>  drivers/iio/light/cm3323.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/iio/light/cm3323.c b/drivers/iio/light/cm3323.c
> index 1fc9f78..0831f06 100644
> --- a/drivers/iio/light/cm3323.c
> +++ b/drivers/iio/light/cm3323.c
> @@ -131,9 +131,11 @@ static int cm3323_set_it_bits(struct cm3323_data *data, int val, int val2)
>  				return ret;
>  
>  			data->reg_conf = reg_conf;
> +
>  			return 0;
>  		}
>  	}
> +
>  	return -EINVAL;
>  }
>  
> @@ -146,6 +148,7 @@ static int cm3323_get_it_bits(struct cm3323_data *data)
>  
>  	if (bits >= ARRAY_SIZE(cm3323_int_time))
>  		return -EINVAL;
> +
>  	return bits;
>  }
>  
> @@ -241,11 +244,13 @@ static int cm3323_probe(struct i2c_client *client,
>  		dev_err(&client->dev, "cm3323 chip init failed\n");
>  		return ret;
>  	}
> +
>  	ret = iio_device_register(indio_dev);
>  	if (ret < 0) {
>  		dev_err(&client->dev, "failed to register iio dev\n");
>  		goto err_init;
>  	}
> +
>  	return 0;
>  err_init:
>  	cm3323_disable(indio_dev);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in

  reply	other threads:[~2015-06-21 13:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 22:31 [PATCH v2 0/7] cm3323 fixes and cleanups Hartmut Knaack
2015-06-17 22:31 ` [PATCH v2 1/7] iio:light:cm3323: clear bitmask before set Hartmut Knaack
2015-06-21 13:25   ` Jonathan Cameron
2015-06-17 22:32 ` [PATCH v2 2/7] iio:light:Kconfig: fix typo in description Hartmut Knaack
2015-06-21 13:26   ` Jonathan Cameron
2015-06-17 22:32 ` [PATCH v2 3/7] iio:light:cm3323: pass up error value Hartmut Knaack
2015-06-21 13:27   ` Jonathan Cameron
2015-06-17 22:32 ` [PATCH v2 4/7] iio:light:cm3323: drop barely used variable Hartmut Knaack
2015-06-17 22:32 ` [PATCH v2 5/7] iio:light:cm3323: replace unneeded variable Hartmut Knaack
2015-06-21 13:27   ` Jonathan Cameron
2015-06-17 22:32 ` [PATCH v2 6/7] iio:light:cm3323: make use of GENMASK Hartmut Knaack
2015-06-21 13:28   ` Jonathan Cameron
2015-06-17 22:32 ` [PATCH v2 7/7] iio:light:cm3323: add empty lines for code structure Hartmut Knaack
2015-06-21 13:28   ` Jonathan Cameron [this message]
2015-06-21 13:19 ` [PATCH v2 0/7] cm3323 fixes and cleanups Jonathan Cameron
2015-06-21 13:20   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5586BC0C.1040005@kernel.org \
    --to=jic23@kernel.org \
    --cc=daniel.baluta@intel.com \
    --cc=knaack.h@gmx.de \
    --cc=ktsai@capellamicro.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox