From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Cc: stephan.kleisinger@gmail.com
Subject: Re: [PATCH] iio: light: tcs3414: Fix bug preventing to set integration time
Date: Sun, 21 Jun 2015 14:54:52 +0100 [thread overview]
Message-ID: <5586C22C.7000307@kernel.org> (raw)
In-Reply-To: <1434316175-24657-1-git-send-email-pmeerw@pmeerw.net>
On 14/06/15 22:09, Peter Meerwald wrote:
> the millisecond values in tcs3414_times should be checked against
> val2, not val, which is always zero.
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Reported-by: Stephan Kleisinger <stephan.kleisinger@gmail.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/light/tcs3414.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/tcs3414.c b/drivers/iio/light/tcs3414.c
> index 71c2bde..f8b1df0 100644
> --- a/drivers/iio/light/tcs3414.c
> +++ b/drivers/iio/light/tcs3414.c
> @@ -185,7 +185,7 @@ static int tcs3414_write_raw(struct iio_dev *indio_dev,
> if (val != 0)
> return -EINVAL;
> for (i = 0; i < ARRAY_SIZE(tcs3414_times); i++) {
> - if (val == tcs3414_times[i] * 1000) {
> + if (val2 == tcs3414_times[i] * 1000) {
> data->timing &= ~TCS3414_INTEG_MASK;
> data->timing |= i;
> return i2c_smbus_write_byte_data(
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
prev parent reply other threads:[~2015-06-21 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 21:09 [PATCH] iio: light: tcs3414: Fix bug preventing to set integration time Peter Meerwald
2015-06-15 5:42 ` Shubhrajyoti Datta
2015-06-15 7:00 ` Daniel Baluta
2015-06-21 13:54 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5586C22C.7000307@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stephan.kleisinger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox