* [PATCH] iio: light: tcs3414: Fix bug preventing to set integration time
@ 2015-06-14 21:09 Peter Meerwald
2015-06-15 5:42 ` Shubhrajyoti Datta
2015-06-21 13:54 ` Jonathan Cameron
0 siblings, 2 replies; 4+ messages in thread
From: Peter Meerwald @ 2015-06-14 21:09 UTC (permalink / raw)
To: linux-iio; +Cc: jic23, Peter Meerwald
the millisecond values in tcs3414_times should be checked against
val2, not val, which is always zero.
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Reported-by: Stephan Kleisinger <stephan.kleisinger@gmail.com>
---
drivers/iio/light/tcs3414.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/light/tcs3414.c b/drivers/iio/light/tcs3414.c
index 71c2bde..f8b1df0 100644
--- a/drivers/iio/light/tcs3414.c
+++ b/drivers/iio/light/tcs3414.c
@@ -185,7 +185,7 @@ static int tcs3414_write_raw(struct iio_dev *indio_dev,
if (val != 0)
return -EINVAL;
for (i = 0; i < ARRAY_SIZE(tcs3414_times); i++) {
- if (val == tcs3414_times[i] * 1000) {
+ if (val2 == tcs3414_times[i] * 1000) {
data->timing &= ~TCS3414_INTEG_MASK;
data->timing |= i;
return i2c_smbus_write_byte_data(
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio: light: tcs3414: Fix bug preventing to set integration time
2015-06-14 21:09 [PATCH] iio: light: tcs3414: Fix bug preventing to set integration time Peter Meerwald
@ 2015-06-15 5:42 ` Shubhrajyoti Datta
2015-06-15 7:00 ` Daniel Baluta
2015-06-21 13:54 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: Shubhrajyoti Datta @ 2015-06-15 5:42 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio@vger.kernel.org, Jonathan Cameron
On Mon, Jun 15, 2015 at 2:39 AM, Peter Meerwald <pmeerw@pmeerw.net> wrote:
> the millisecond values in tcs3414_times should be checked against
> val2, not val, which is always zero.
nit :
may be the variable name could be little more descriptive.
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Reported-by: Stephan Kleisinger <stephan.kleisinger@gmail.com>
> ---
> drivers/iio/light/tcs3414.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/tcs3414.c b/drivers/iio/light/tcs3414.c
> index 71c2bde..f8b1df0 100644
> --- a/drivers/iio/light/tcs3414.c
> +++ b/drivers/iio/light/tcs3414.c
> @@ -185,7 +185,7 @@ static int tcs3414_write_raw(struct iio_dev *indio_dev,
> if (val != 0)
> return -EINVAL;
> for (i = 0; i < ARRAY_SIZE(tcs3414_times); i++) {
> - if (val == tcs3414_times[i] * 1000) {
> + if (val2 == tcs3414_times[i] * 1000) {
> data->timing &= ~TCS3414_INTEG_MASK;
> data->timing |= i;
> return i2c_smbus_write_byte_data(
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: light: tcs3414: Fix bug preventing to set integration time
2015-06-15 5:42 ` Shubhrajyoti Datta
@ 2015-06-15 7:00 ` Daniel Baluta
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Baluta @ 2015-06-15 7:00 UTC (permalink / raw)
To: Shubhrajyoti Datta
Cc: Peter Meerwald, linux-iio@vger.kernel.org, Jonathan Cameron
On Mon, Jun 15, 2015 at 8:42 AM, Shubhrajyoti Datta
<omaplinuxkernel@gmail.com> wrote:
> On Mon, Jun 15, 2015 at 2:39 AM, Peter Meerwald <pmeerw@pmeerw.net> wrote:
>> the millisecond values in tcs3414_times should be checked against
>> val2, not val, which is always zero.
> nit :
>
> may be the variable name could be little more descriptive.
This is the convention for fractional part in IIO. :)
Daniel.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: light: tcs3414: Fix bug preventing to set integration time
2015-06-14 21:09 [PATCH] iio: light: tcs3414: Fix bug preventing to set integration time Peter Meerwald
2015-06-15 5:42 ` Shubhrajyoti Datta
@ 2015-06-21 13:54 ` Jonathan Cameron
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2015-06-21 13:54 UTC (permalink / raw)
To: Peter Meerwald, linux-iio; +Cc: stephan.kleisinger
On 14/06/15 22:09, Peter Meerwald wrote:
> the millisecond values in tcs3414_times should be checked against
> val2, not val, which is always zero.
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Reported-by: Stephan Kleisinger <stephan.kleisinger@gmail.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/light/tcs3414.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/tcs3414.c b/drivers/iio/light/tcs3414.c
> index 71c2bde..f8b1df0 100644
> --- a/drivers/iio/light/tcs3414.c
> +++ b/drivers/iio/light/tcs3414.c
> @@ -185,7 +185,7 @@ static int tcs3414_write_raw(struct iio_dev *indio_dev,
> if (val != 0)
> return -EINVAL;
> for (i = 0; i < ARRAY_SIZE(tcs3414_times); i++) {
> - if (val == tcs3414_times[i] * 1000) {
> + if (val2 == tcs3414_times[i] * 1000) {
> data->timing &= ~TCS3414_INTEG_MASK;
> data->timing |= i;
> return i2c_smbus_write_byte_data(
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-21 13:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-14 21:09 [PATCH] iio: light: tcs3414: Fix bug preventing to set integration time Peter Meerwald
2015-06-15 5:42 ` Shubhrajyoti Datta
2015-06-15 7:00 ` Daniel Baluta
2015-06-21 13:54 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox