From: David Lechner <dlechner@baylibre.com>
To: Archit Anant <architanant5@gmail.com>,
jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com
Cc: nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] iio: adc: ad799x: make rx_buf static and DMA-safe
Date: Mon, 2 Mar 2026 10:29:49 -0600 [thread overview]
Message-ID: <5599f271-3d81-460c-b2f3-3cbd704ffbdf@baylibre.com> (raw)
In-Reply-To: <20260302130632.29144-2-architanant5@gmail.com>
On 3/2/26 7:06 AM, Archit Anant wrote:
> Currently, rx_buf is dynamically allocated using kmalloc() every time
> ad799x_update_scan_mode() is called. This can lead to memory leaks if
> the scan mask is updated multiple times.
>
> Drop the dynamic allocation and replace it with a static, buffer at the
> end of the state structure using IIO_DECLARE_DMA_BUFFER_WITH_TS().
> This eliminates the allocation overhead, prevents leaks, and removes
> the need for manual kfree() on driver removal.
>
See replies in v1 and v2. DMA-safe is not important because it is I2C.
next prev parent reply other threads:[~2026-03-02 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 13:06 [PATCH v3 0/4] iio: adc: ad799x: modernize resource management Archit Anant
2026-03-02 13:06 ` [PATCH v3 1/4] iio: adc: ad799x: make rx_buf static and DMA-safe Archit Anant
2026-03-02 16:29 ` David Lechner [this message]
2026-03-02 16:31 ` David Lechner
2026-03-02 13:06 ` [PATCH v3 2/4] iio: adc: ad799x: cache regulator voltages during probe Archit Anant
2026-03-02 13:13 ` Andy Shevchenko
2026-03-02 16:37 ` David Lechner
2026-03-02 13:06 ` [PATCH v3 3/4] iio: adc: ad799x: use devm_add_action_or_reset for regulators Archit Anant
2026-03-02 13:16 ` Andy Shevchenko
2026-03-02 16:35 ` David Lechner
2026-03-02 13:06 ` [PATCH v3 4/4] iio: adc: ad799x: use devm_iio_device_register and drop remove Archit Anant
2026-03-02 13:17 ` Andy Shevchenko
2026-03-02 16:28 ` [PATCH v3 0/4] iio: adc: ad799x: modernize resource management David Lechner
2026-03-03 5:11 ` Archit Anant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5599f271-3d81-460c-b2f3-3cbd704ffbdf@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=architanant5@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox