Linux IIO development
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: Archit Anant <architanant5@gmail.com>,
	jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com
Cc: nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] iio: adc: ad799x: modernize resource management
Date: Mon, 2 Mar 2026 10:28:11 -0600	[thread overview]
Message-ID: <8ce6bc3a-c55e-49e4-973e-5f135e2b24ba@baylibre.com> (raw)
In-Reply-To: <20260302130632.29144-1-architanant5@gmail.com>

On 3/2/26 7:06 AM, Archit Anant wrote:
> This series modernizes the ad799x driver by converting all resource
> management to use the devm_ infrastructure, ultimately allowing for the
> complete removal of the ad799x_remove() function and simplifying the
> error paths in probe.
> 
> This series addresses the feedback from v2, where the changes were
> squashed into a single patch, by splitting the logical steps into
> individual, bisectable commits. It also incorporates feedback regarding
> the safe ordering of regulator disablement and IIO device unregistration.
> 
> Changes in v3:
> - Split the monolithic v2 patch into 4 logical commits as requested by
>   Andy Shevchenko.
> 
> Changes in v2:
> - Incorporated feedback from David Lechner to eliminate dynamic buffer
>   allocation.
> - Incorporated feedback from Jonathan Cameron regarding the ordering
>   hazards of mixing devm and manual teardown, utilizing devm_add_action
>   and voltage caching.
> 

I just reviewed v2 because I didn't see there was a v3 yet. This is why
we ask to wait ideally 1 week, but at a few days before sending a new
revision.

Some of those comment will still apply to v3.


  parent reply	other threads:[~2026-03-02 16:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 13:06 [PATCH v3 0/4] iio: adc: ad799x: modernize resource management Archit Anant
2026-03-02 13:06 ` [PATCH v3 1/4] iio: adc: ad799x: make rx_buf static and DMA-safe Archit Anant
2026-03-02 16:29   ` David Lechner
2026-03-02 16:31   ` David Lechner
2026-03-02 13:06 ` [PATCH v3 2/4] iio: adc: ad799x: cache regulator voltages during probe Archit Anant
2026-03-02 13:13   ` Andy Shevchenko
2026-03-02 16:37   ` David Lechner
2026-03-02 13:06 ` [PATCH v3 3/4] iio: adc: ad799x: use devm_add_action_or_reset for regulators Archit Anant
2026-03-02 13:16   ` Andy Shevchenko
2026-03-02 16:35   ` David Lechner
2026-03-02 13:06 ` [PATCH v3 4/4] iio: adc: ad799x: use devm_iio_device_register and drop remove Archit Anant
2026-03-02 13:17   ` Andy Shevchenko
2026-03-02 16:28 ` David Lechner [this message]
2026-03-03  5:11   ` [PATCH v3 0/4] iio: adc: ad799x: modernize resource management Archit Anant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ce6bc3a-c55e-49e4-973e-5f135e2b24ba@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=architanant5@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox