Add lis2dh12 to st-sensor driver

Add lis2dh12 to st-sensor driver

[Giuseppe Barba]

This little commit is intended to add the lis2dh12 support on top of st iio driver.

[V2] iio: st-accel: add support for lis2dh12

[Giuseppe Barba]

This commit add support for STMicroelectronics lis2dh12 accelerometer.

Signed-off-by: Giuseppe Barba <giuseppe.barba@st.com>
---
 Documentation/devicetree/bindings/iio/st-sensors.txt | 1 +
 drivers/iio/accel/st_accel.h                         | 1 +
 drivers/iio/accel/st_accel_core.c                    | 1 +
 drivers/iio/accel/st_accel_i2c.c                     | 5 +++++
 drivers/iio/accel/st_accel_spi.c                     | 1 +
 5 files changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/st-sensors.txt b/Documentation/devicetree/bindings/iio/st-sensors.txt
index d3ccdb1..d4b87cc 100644
--- a/Documentation/devicetree/bindings/iio/st-sensors.txt
+++ b/Documentation/devicetree/bindings/iio/st-sensors.txt
@@ -36,6 +36,7 @@ Accelerometers:
 - st,lsm303dlm-accel
 - st,lsm330-accel
 - st,lsm303agr-accel
+- st,lis2dh12-accel
 
 Gyroscopes:
 - st,l3g4200d-gyro
diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h
index 468f21f..5d4a189 100644
--- a/drivers/iio/accel/st_accel.h
+++ b/drivers/iio/accel/st_accel.h
@@ -27,6 +27,7 @@
 #define LSM303DLM_ACCEL_DEV_NAME	"lsm303dlm_accel"
 #define LSM330_ACCEL_DEV_NAME		"lsm330_accel"
 #define LSM303AGR_ACCEL_DEV_NAME	"lsm303agr_accel"
+#define LIS2DH12_ACCEL_DEV_NAME		"lis2dh12_accel"
 
 /**
 * struct st_sensors_platform_data - default accel platform data
diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c
index dab8b76..9d973f1 100644
--- a/drivers/iio/accel/st_accel_core.c
+++ b/drivers/iio/accel/st_accel_core.c
@@ -234,6 +234,7 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = {
 			[3] = LSM330DL_ACCEL_DEV_NAME,
 			[4] = LSM330DLC_ACCEL_DEV_NAME,
 			[5] = LSM303AGR_ACCEL_DEV_NAME,
+			[6] = LIS2DH12_ACCEL_DEV_NAME,
 		},
 		.ch = (struct iio_chan_spec *)st_accel_12bit_channels,
 		.odr = {
diff --git a/drivers/iio/accel/st_accel_i2c.c b/drivers/iio/accel/st_accel_i2c.c
index 8b9cc84..294a32f 100644
--- a/drivers/iio/accel/st_accel_i2c.c
+++ b/drivers/iio/accel/st_accel_i2c.c
@@ -72,6 +72,10 @@ static const struct of_device_id st_accel_of_match[] = {
 		.compatible = "st,lsm303agr-accel",
 		.data = LSM303AGR_ACCEL_DEV_NAME,
 	},
+	{
+		.compatible = "st,lis2dh12-accel",
+		.data = LIS2DH12_ACCEL_DEV_NAME,
+	},
 	{},
 };
 MODULE_DEVICE_TABLE(of, st_accel_of_match);
@@ -121,6 +125,7 @@ static const struct i2c_device_id st_accel_id_table[] = {
 	{ LSM303DLM_ACCEL_DEV_NAME },
 	{ LSM330_ACCEL_DEV_NAME },
 	{ LSM303AGR_ACCEL_DEV_NAME },
+	{ LIS2DH12_ACCEL_DEV_NAME },
 	{},
 };
 MODULE_DEVICE_TABLE(i2c, st_accel_id_table);
diff --git a/drivers/iio/accel/st_accel_spi.c b/drivers/iio/accel/st_accel_spi.c
index 54b61a3..e82bedf 100644
--- a/drivers/iio/accel/st_accel_spi.c
+++ b/drivers/iio/accel/st_accel_spi.c
@@ -58,6 +58,7 @@ static const struct spi_device_id st_accel_id_table[] = {
 	{ LSM303DLM_ACCEL_DEV_NAME },
 	{ LSM330_ACCEL_DEV_NAME },
 	{ LSM303AGR_ACCEL_DEV_NAME },
+	{ LIS2DH12_ACCEL_DEV_NAME },
 	{},
 };
 MODULE_DEVICE_TABLE(spi, st_accel_id_table);
-- 
1.9.1

Re: Add lis2dh12 to st-sensor driver

[Daniel Baluta]

On Wed, Nov 11, 2015 at 3:52 PM, Giuseppe Barba <giuseppe.barba@st.com> wrote:
> This little commit is intended to add the lis2dh12 support on top of st iio driver.

How did you generate this patch? :). This is supposed to be the cover letter.

git format-patch -1 --cover-letter

Anyhow, in the case of a single patch you don't need a cover letter.

Re: [V2] iio: st-accel: add support for lis2dh12

[Daniel Baluta]

On Wed, Nov 11, 2015 at 3:52 PM, Giuseppe Barba <giuseppe.barba@st.com> wrote:
> This commit add support for STMicroelectronics lis2dh12 accelerometer.

Link to datasheet?

The subject should start with [PATCH v2] ...

>
> Signed-off-by: Giuseppe Barba <giuseppe.barba@st.com>
> ---

Here you should add a short changelog with what you changed since v1.

>  Documentation/devicetree/bindings/iio/st-sensors.txt | 1 +
>  drivers/iio/accel/st_accel.h                         | 1 +
>  drivers/iio/accel/st_accel_core.c                    | 1 +
>  drivers/iio/accel/st_accel_i2c.c                     | 5 +++++
>  drivers/iio/accel/st_accel_spi.c                     | 1 +
>  5 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/st-sensors.txt b/Documentation/devicetree/bindings/iio/st-sensors.txt
> index d3ccdb1..d4b87cc 100644
> --- a/Documentation/devicetree/bindings/iio/st-sensors.txt
> +++ b/Documentation/devicetree/bindings/iio/st-sensors.txt
> @@ -36,6 +36,7 @@ Accelerometers:
>  - st,lsm303dlm-accel
>  - st,lsm330-accel
>  - st,lsm303agr-accel
> +- st,lis2dh12-accel
>
>  Gyroscopes:
>  - st,l3g4200d-gyro
> diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h
> index 468f21f..5d4a189 100644
> --- a/drivers/iio/accel/st_accel.h
> +++ b/drivers/iio/accel/st_accel.h
> @@ -27,6 +27,7 @@
>  #define LSM303DLM_ACCEL_DEV_NAME       "lsm303dlm_accel"
>  #define LSM330_ACCEL_DEV_NAME          "lsm330_accel"
>  #define LSM303AGR_ACCEL_DEV_NAME       "lsm303agr_accel"
> +#define LIS2DH12_ACCEL_DEV_NAME                "lis2dh12_accel"
>
>  /**
>  * struct st_sensors_platform_data - default accel platform data
> diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c
> index dab8b76..9d973f1 100644
> --- a/drivers/iio/accel/st_accel_core.c
> +++ b/drivers/iio/accel/st_accel_core.c
> @@ -234,6 +234,7 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = {
>                         [3] = LSM330DL_ACCEL_DEV_NAME,
>                         [4] = LSM330DLC_ACCEL_DEV_NAME,
>                         [5] = LSM303AGR_ACCEL_DEV_NAME,
> +                       [6] = LIS2DH12_ACCEL_DEV_NAME,
>                 },
>                 .ch = (struct iio_chan_spec *)st_accel_12bit_channels,
>                 .odr = {
> diff --git a/drivers/iio/accel/st_accel_i2c.c b/drivers/iio/accel/st_accel_i2c.c
> index 8b9cc84..294a32f 100644
> --- a/drivers/iio/accel/st_accel_i2c.c
> +++ b/drivers/iio/accel/st_accel_i2c.c
> @@ -72,6 +72,10 @@ static const struct of_device_id st_accel_of_match[] = {
>                 .compatible = "st,lsm303agr-accel",
>                 .data = LSM303AGR_ACCEL_DEV_NAME,
>         },
> +       {
> +               .compatible = "st,lis2dh12-accel",
> +               .data = LIS2DH12_ACCEL_DEV_NAME,
> +       },
>         {},
>  };
>  MODULE_DEVICE_TABLE(of, st_accel_of_match);
> @@ -121,6 +125,7 @@ static const struct i2c_device_id st_accel_id_table[] = {
>         { LSM303DLM_ACCEL_DEV_NAME },
>         { LSM330_ACCEL_DEV_NAME },
>         { LSM303AGR_ACCEL_DEV_NAME },
> +       { LIS2DH12_ACCEL_DEV_NAME },
>         {},
>  };
>  MODULE_DEVICE_TABLE(i2c, st_accel_id_table);
> diff --git a/drivers/iio/accel/st_accel_spi.c b/drivers/iio/accel/st_accel_spi.c
> index 54b61a3..e82bedf 100644
> --- a/drivers/iio/accel/st_accel_spi.c
> +++ b/drivers/iio/accel/st_accel_spi.c
> @@ -58,6 +58,7 @@ static const struct spi_device_id st_accel_id_table[] = {
>         { LSM303DLM_ACCEL_DEV_NAME },
>         { LSM330_ACCEL_DEV_NAME },
>         { LSM303AGR_ACCEL_DEV_NAME },
> +       { LIS2DH12_ACCEL_DEV_NAME },
>         {},
>  };
>  MODULE_DEVICE_TABLE(spi, st_accel_id_table);
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Add lis2dh12 to st-sensor driver

[Giuseppe BARBA]

SGkgRGFuaWVsLA0KDQpTb3JyeSBmb3IgdGhlIG1haWwgamFtbWluZy4NCkknbSBhZ3JlZSB3aXRo
IHlvdSAuLi5idXQgSSd2ZSB1c2VkIGEgd3JvbmcgZmxhZyBmb3Igc2VuZC1lbWFpbC4NCg0KR2l1
c2VwcGUuDQoNCk9uIDExLzExLzIwMTUgMTU6NDMsIERhbmllbCBCYWx1dGEgd3JvdGU6DQo+IE9u
IFdlZCwgTm92IDExLCAyMDE1IGF0IDM6NTIgUE0sIEdpdXNlcHBlIEJhcmJhIDxnaXVzZXBwZS5i
YXJiYUBzdC5jb20+IHdyb3RlOg0KPj4gVGhpcyBsaXR0bGUgY29tbWl0IGlzIGludGVuZGVkIHRv
IGFkZCB0aGUgbGlzMmRoMTIgc3VwcG9ydCBvbiB0b3Agb2Ygc3QgaWlvIGRyaXZlci4NCj4NCj4g
SG93IGRpZCB5b3UgZ2VuZXJhdGUgdGhpcyBwYXRjaD8gOikuIFRoaXMgaXMgc3VwcG9zZWQgdG8g
YmUgdGhlIGNvdmVyIGxldHRlci4NCj4NCj4gZ2l0IGZvcm1hdC1wYXRjaCAtMSAtLWNvdmVyLWxl
dHRlcg0KPg0KPiBBbnlob3csIGluIHRoZSBjYXNlIG9mIGEgc2luZ2xlIHBhdGNoIHlvdSBkb24n
dCBuZWVkIGEgY292ZXIgbGV0dGVyLg0KPg==

Re: [V2] iio: st-accel: add support for lis2dh12

[Giuseppe BARBA]

SGkgRGFuaWVsLA0KDQp0aGFuayB5b3UgZm9yIHRoZSByZXZpZXcuDQoNCk9uIDExLzExLzIwMTUg
MTU6NDUsIERhbmllbCBCYWx1dGEgd3JvdGU6DQo+IE9uIFdlZCwgTm92IDExLCAyMDE1IGF0IDM6
NTIgUE0sIEdpdXNlcHBlIEJhcmJhIDxnaXVzZXBwZS5iYXJiYUBzdC5jb20+IHdyb3RlOg0KPj4g
VGhpcyBjb21taXQgYWRkIHN1cHBvcnQgZm9yIFNUTWljcm9lbGVjdHJvbmljcyBsaXMyZGgxMiBh
Y2NlbGVyb21ldGVyLg0KPg0KPiBMaW5rIHRvIGRhdGFzaGVldD8NCg0KVGhlIGRhdGFzaGVldCBs
aW5rIGlzOg0KDQpodHRwOi8vd3d3LnN0LmNvbS9zdC13ZWItdWkvc3RhdGljL2FjdGl2ZS9lbi9y
ZXNvdXJjZS90ZWNobmljYWwvZG9jdW1lbnQvZGF0YXNoZWV0L0RNMDAwOTE1MTMucGRmDQoNCj4N
Cj4gVGhlIHN1YmplY3Qgc2hvdWxkIHN0YXJ0IHdpdGggW1BBVENIIHYyXSAuLi4NCj4NCj4+DQo+
PiBTaWduZWQtb2ZmLWJ5OiBHaXVzZXBwZSBCYXJiYSA8Z2l1c2VwcGUuYmFyYmFAc3QuY29tPg0K
Pj4gLS0tDQo+DQo+IEhlcmUgeW91IHNob3VsZCBhZGQgYSBzaG9ydCBjaGFuZ2Vsb2cgd2l0aCB3
aGF0IHlvdSBjaGFuZ2VkIHNpbmNlIHYxLg0KDQpZZXMgSSBjYW4gZG8gdGhhdCBpZiBuZWVkZWQg
YnV0IGl0IGlzIGp1c3QgYSB0eXBvIG9uIA0KTElTMkRIMTJfQUNDRUxfREVWX05BTUUgbWFjcm8g
d2hlcmUgSSd2ZSB1c2VkIGEgbWludXMgaW5zdGVhZCBvZiANCnVuZGVyc2NvcmUgY2hhci4NCg0K
Pg0KPj4gICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaWlvL3N0LXNlbnNvcnMu
dHh0IHwgMSArDQo+PiAgIGRyaXZlcnMvaWlvL2FjY2VsL3N0X2FjY2VsLmggICAgICAgICAgICAg
ICAgICAgICAgICAgfCAxICsNCj4+ICAgZHJpdmVycy9paW8vYWNjZWwvc3RfYWNjZWxfY29yZS5j
ICAgICAgICAgICAgICAgICAgICB8IDEgKw0KPj4gICBkcml2ZXJzL2lpby9hY2NlbC9zdF9hY2Nl
bF9pMmMuYyAgICAgICAgICAgICAgICAgICAgIHwgNSArKysrKw0KPj4gICBkcml2ZXJzL2lpby9h
Y2NlbC9zdF9hY2NlbF9zcGkuYyAgICAgICAgICAgICAgICAgICAgIHwgMSArDQo+PiAgIDUgZmls
ZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50
YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9paW8vc3Qtc2Vuc29ycy50eHQgYi9Eb2N1bWVudGF0
aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaWlvL3N0LXNlbnNvcnMudHh0DQo+PiBpbmRleCBkM2Nj
ZGIxLi5kNGI4N2NjIDEwMDY0NA0KPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp
bmRpbmdzL2lpby9zdC1zZW5zb3JzLnR4dA0KPj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0
cmVlL2JpbmRpbmdzL2lpby9zdC1zZW5zb3JzLnR4dA0KPj4gQEAgLTM2LDYgKzM2LDcgQEAgQWNj
ZWxlcm9tZXRlcnM6DQo+PiAgIC0gc3QsbHNtMzAzZGxtLWFjY2VsDQo+PiAgIC0gc3QsbHNtMzMw
LWFjY2VsDQo+PiAgIC0gc3QsbHNtMzAzYWdyLWFjY2VsDQo+PiArLSBzdCxsaXMyZGgxMi1hY2Nl
bA0KPj4NCj4+ICAgR3lyb3Njb3BlczoNCj4+ICAgLSBzdCxsM2c0MjAwZC1neXJvDQo+PiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9paW8vYWNjZWwvc3RfYWNjZWwuaCBiL2RyaXZlcnMvaWlvL2FjY2Vs
L3N0X2FjY2VsLmgNCj4+IGluZGV4IDQ2OGYyMWYuLjVkNGExODkgMTAwNjQ0DQo+PiAtLS0gYS9k
cml2ZXJzL2lpby9hY2NlbC9zdF9hY2NlbC5oDQo+PiArKysgYi9kcml2ZXJzL2lpby9hY2NlbC9z
dF9hY2NlbC5oDQo+PiBAQCAtMjcsNiArMjcsNyBAQA0KPj4gICAjZGVmaW5lIExTTTMwM0RMTV9B
Q0NFTF9ERVZfTkFNRSAgICAgICAibHNtMzAzZGxtX2FjY2VsIg0KPj4gICAjZGVmaW5lIExTTTMz
MF9BQ0NFTF9ERVZfTkFNRSAgICAgICAgICAibHNtMzMwX2FjY2VsIg0KPj4gICAjZGVmaW5lIExT
TTMwM0FHUl9BQ0NFTF9ERVZfTkFNRSAgICAgICAibHNtMzAzYWdyX2FjY2VsIg0KPj4gKyNkZWZp
bmUgTElTMkRIMTJfQUNDRUxfREVWX05BTUUgICAgICAgICAgICAgICAgImxpczJkaDEyX2FjY2Vs
Ig0KPj4NCj4+ICAgLyoqDQo+PiAgICogc3RydWN0IHN0X3NlbnNvcnNfcGxhdGZvcm1fZGF0YSAt
IGRlZmF1bHQgYWNjZWwgcGxhdGZvcm0gZGF0YQ0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaWlv
L2FjY2VsL3N0X2FjY2VsX2NvcmUuYyBiL2RyaXZlcnMvaWlvL2FjY2VsL3N0X2FjY2VsX2NvcmUu
Yw0KPj4gaW5kZXggZGFiOGI3Ni4uOWQ5NzNmMSAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMvaWlv
L2FjY2VsL3N0X2FjY2VsX2NvcmUuYw0KPj4gKysrIGIvZHJpdmVycy9paW8vYWNjZWwvc3RfYWNj
ZWxfY29yZS5jDQo+PiBAQCAtMjM0LDYgKzIzNCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgc3Rf
c2Vuc29yX3NldHRpbmdzIHN0X2FjY2VsX3NlbnNvcnNfc2V0dGluZ3NbXSA9IHsNCj4+ICAgICAg
ICAgICAgICAgICAgICAgICAgICBbM10gPSBMU00zMzBETF9BQ0NFTF9ERVZfTkFNRSwNCj4+ICAg
ICAgICAgICAgICAgICAgICAgICAgICBbNF0gPSBMU00zMzBETENfQUNDRUxfREVWX05BTUUsDQo+
PiAgICAgICAgICAgICAgICAgICAgICAgICAgWzVdID0gTFNNMzAzQUdSX0FDQ0VMX0RFVl9OQU1F
LA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgWzZdID0gTElTMkRIMTJfQUNDRUxfREVWX05B
TUUsDQo+PiAgICAgICAgICAgICAgICAgIH0sDQo+PiAgICAgICAgICAgICAgICAgIC5jaCA9IChz
dHJ1Y3QgaWlvX2NoYW5fc3BlYyAqKXN0X2FjY2VsXzEyYml0X2NoYW5uZWxzLA0KPj4gICAgICAg
ICAgICAgICAgICAub2RyID0gew0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaWlvL2FjY2VsL3N0
X2FjY2VsX2kyYy5jIGIvZHJpdmVycy9paW8vYWNjZWwvc3RfYWNjZWxfaTJjLmMNCj4+IGluZGV4
IDhiOWNjODQuLjI5NGEzMmYgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL2lpby9hY2NlbC9zdF9h
Y2NlbF9pMmMuYw0KPj4gKysrIGIvZHJpdmVycy9paW8vYWNjZWwvc3RfYWNjZWxfaTJjLmMNCj4+
IEBAIC03Miw2ICs3MiwxMCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBzdF9h
Y2NlbF9vZl9tYXRjaFtdID0gew0KPj4gICAgICAgICAgICAgICAgICAuY29tcGF0aWJsZSA9ICJz
dCxsc20zMDNhZ3ItYWNjZWwiLA0KPj4gICAgICAgICAgICAgICAgICAuZGF0YSA9IExTTTMwM0FH
Ul9BQ0NFTF9ERVZfTkFNRSwNCj4+ICAgICAgICAgIH0sDQo+PiArICAgICAgIHsNCj4+ICsgICAg
ICAgICAgICAgICAuY29tcGF0aWJsZSA9ICJzdCxsaXMyZGgxMi1hY2NlbCIsDQo+PiArICAgICAg
ICAgICAgICAgLmRhdGEgPSBMSVMyREgxMl9BQ0NFTF9ERVZfTkFNRSwNCj4+ICsgICAgICAgfSwN
Cj4+ICAgICAgICAgIHt9LA0KPj4gICB9Ow0KPj4gICBNT0RVTEVfREVWSUNFX1RBQkxFKG9mLCBz
dF9hY2NlbF9vZl9tYXRjaCk7DQo+PiBAQCAtMTIxLDYgKzEyNSw3IEBAIHN0YXRpYyBjb25zdCBz
dHJ1Y3QgaTJjX2RldmljZV9pZCBzdF9hY2NlbF9pZF90YWJsZVtdID0gew0KPj4gICAgICAgICAg
eyBMU00zMDNETE1fQUNDRUxfREVWX05BTUUgfSwNCj4+ICAgICAgICAgIHsgTFNNMzMwX0FDQ0VM
X0RFVl9OQU1FIH0sDQo+PiAgICAgICAgICB7IExTTTMwM0FHUl9BQ0NFTF9ERVZfTkFNRSB9LA0K
Pj4gKyAgICAgICB7IExJUzJESDEyX0FDQ0VMX0RFVl9OQU1FIH0sDQo+PiAgICAgICAgICB7fSwN
Cj4+ICAgfTsNCj4+ICAgTU9EVUxFX0RFVklDRV9UQUJMRShpMmMsIHN0X2FjY2VsX2lkX3RhYmxl
KTsNCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lpby9hY2NlbC9zdF9hY2NlbF9zcGkuYyBiL2Ry
aXZlcnMvaWlvL2FjY2VsL3N0X2FjY2VsX3NwaS5jDQo+PiBpbmRleCA1NGI2MWEzLi5lODJiZWRm
IDEwMDY0NA0KPj4gLS0tIGEvZHJpdmVycy9paW8vYWNjZWwvc3RfYWNjZWxfc3BpLmMNCj4+ICsr
KyBiL2RyaXZlcnMvaWlvL2FjY2VsL3N0X2FjY2VsX3NwaS5jDQo+PiBAQCAtNTgsNiArNTgsNyBA
QCBzdGF0aWMgY29uc3Qgc3RydWN0IHNwaV9kZXZpY2VfaWQgc3RfYWNjZWxfaWRfdGFibGVbXSA9
IHsNCj4+ICAgICAgICAgIHsgTFNNMzAzRExNX0FDQ0VMX0RFVl9OQU1FIH0sDQo+PiAgICAgICAg
ICB7IExTTTMzMF9BQ0NFTF9ERVZfTkFNRSB9LA0KPj4gICAgICAgICAgeyBMU00zMDNBR1JfQUND
RUxfREVWX05BTUUgfSwNCj4+ICsgICAgICAgeyBMSVMyREgxMl9BQ0NFTF9ERVZfTkFNRSB9LA0K
Pj4gICAgICAgICAge30sDQo+PiAgIH07DQo+PiAgIE1PRFVMRV9ERVZJQ0VfVEFCTEUoc3BpLCBz
dF9hY2NlbF9pZF90YWJsZSk7DQo+PiAtLQ0KPj4gMS45LjENCj4+DQo+PiAtLQ0KPj4gVG8gdW5z
dWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4
LWlpbyIgaW4NCj4+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJu
ZWwub3JnDQo+PiBNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3Jn
L21ham9yZG9tby1pbmZvLmh0bWw=

Re: [V2] iio: st-accel: add support for lis2dh12

[Daniel Baluta]

On Wed, Nov 11, 2015 at 4:59 PM, Giuseppe BARBA <giuseppe.barba@st.com> wrote:
> Hi Daniel,
>
> thank you for the review.
>
> On 11/11/2015 15:45, Daniel Baluta wrote:
>> On Wed, Nov 11, 2015 at 3:52 PM, Giuseppe Barba <giuseppe.barba@st.com> wrote:
>>> This commit add support for STMicroelectronics lis2dh12 accelerometer.
>>
>> Link to datasheet?
>
> The datasheet link is:
>
> http://www.st.com/st-web-ui/static/active/en/resource/technical/document/datasheet/DM00091513.pdf

Care to send v3 with the commit message updated with the link to datasheet?
>
>>
>> The subject should start with [PATCH v2] ...
>>
>>>
>>> Signed-off-by: Giuseppe Barba <giuseppe.barba@st.com>
>>> ---
>>
>> Here you should add a short changelog with what you changed since v1.
>
> Yes I can do that if needed but it is just a typo on
> LIS2DH12_ACCEL_DEV_NAME macro where I've used a minus instead of
> underscore char.

Usually, it's easier for reviewers to check your patch having
the change log even if there is a minor change like yours.

thanks,
Daniel.

Re: [V2] iio: st-accel: add support for lis2dh12

[Giuseppe BARBA]

SGkgRGFuaWVsLA0KDQpPbiAxMS8xMS8yMDE1IDE2OjAzLCBEYW5pZWwgQmFsdXRhIHdyb3RlOg0K
PiBPbiBXZWQsIE5vdiAxMSwgMjAxNSBhdCA0OjU5IFBNLCBHaXVzZXBwZSBCQVJCQSA8Z2l1c2Vw
cGUuYmFyYmFAc3QuY29tPiB3cm90ZToNCj4+IEhpIERhbmllbCwNCj4+DQo+PiB0aGFuayB5b3Ug
Zm9yIHRoZSByZXZpZXcuDQo+Pg0KPj4gT24gMTEvMTEvMjAxNSAxNTo0NSwgRGFuaWVsIEJhbHV0
YSB3cm90ZToNCj4+PiBPbiBXZWQsIE5vdiAxMSwgMjAxNSBhdCAzOjUyIFBNLCBHaXVzZXBwZSBC
YXJiYSA8Z2l1c2VwcGUuYmFyYmFAc3QuY29tPiB3cm90ZToNCj4+Pj4gVGhpcyBjb21taXQgYWRk
IHN1cHBvcnQgZm9yIFNUTWljcm9lbGVjdHJvbmljcyBsaXMyZGgxMiBhY2NlbGVyb21ldGVyLg0K
Pj4+DQo+Pj4gTGluayB0byBkYXRhc2hlZXQ/DQo+Pg0KPj4gVGhlIGRhdGFzaGVldCBsaW5rIGlz
Og0KPj4NCj4+IGh0dHA6Ly93d3cuc3QuY29tL3N0LXdlYi11aS9zdGF0aWMvYWN0aXZlL2VuL3Jl
c291cmNlL3RlY2huaWNhbC9kb2N1bWVudC9kYXRhc2hlZXQvRE0wMDA5MTUxMy5wZGYNCj4NCj4g
Q2FyZSB0byBzZW5kIHYzIHdpdGggdGhlIGNvbW1pdCBtZXNzYWdlIHVwZGF0ZWQgd2l0aCB0aGUg
bGluayB0byBkYXRhc2hlZXQ/DQoNClllcywgZm9yIHN1cmUuDQoNCj4+DQo+Pj4NCj4+PiBUaGUg
c3ViamVjdCBzaG91bGQgc3RhcnQgd2l0aCBbUEFUQ0ggdjJdIC4uLg0KPj4+DQo+Pj4+DQo+Pj4+
IFNpZ25lZC1vZmYtYnk6IEdpdXNlcHBlIEJhcmJhIDxnaXVzZXBwZS5iYXJiYUBzdC5jb20+DQo+
Pj4+IC0tLQ0KPj4+DQo+Pj4gSGVyZSB5b3Ugc2hvdWxkIGFkZCBhIHNob3J0IGNoYW5nZWxvZyB3
aXRoIHdoYXQgeW91IGNoYW5nZWQgc2luY2UgdjEuDQo+Pg0KPj4gWWVzIEkgY2FuIGRvIHRoYXQg
aWYgbmVlZGVkIGJ1dCBpdCBpcyBqdXN0IGEgdHlwbyBvbg0KPj4gTElTMkRIMTJfQUNDRUxfREVW
X05BTUUgbWFjcm8gd2hlcmUgSSd2ZSB1c2VkIGEgbWludXMgaW5zdGVhZCBvZg0KPj4gdW5kZXJz
Y29yZSBjaGFyLg0KPg0KPiBVc3VhbGx5LCBpdCdzIGVhc2llciBmb3IgcmV2aWV3ZXJzIHRvIGNo
ZWNrIHlvdXIgcGF0Y2ggaGF2aW5nDQo+IHRoZSBjaGFuZ2UgbG9nIGV2ZW4gaWYgdGhlcmUgaXMg
YSBtaW5vciBjaGFuZ2UgbGlrZSB5b3Vycy4NCg0KSSdtIGFncmVlLg0KSSdsbCBzZW5kIGFnYWlu
IHRoZSBjb21taXQgZml4ZWQgd2l0aCB5b3VyIHRpcHMuDQoNCnRoYW5rcywNCkdpdXNlcHBlDQoN
Cj4NCj4gdGhhbmtzLA0KPiBEYW5pZWwuDQo+