Linux IIO development
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Matt Ranostay <mranostay@gmail.com>, linux-iio@vger.kernel.org
Cc: jic23@kernel.org
Subject: Re: [PATCH] iio: proximity: as3935: remove redundant zeroing of tune_cap
Date: Fri, 17 Jun 2016 03:04:29 +0200	[thread overview]
Message-ID: <57634C9D.7090705@gmail.com> (raw)
In-Reply-To: <1466041622-1236-1-git-send-email-mranostay@gmail.com>

On 06/16/2016 03:47 AM, Matt Ranostay wrote:

Commit message explaining what the patch does and why this patch is
needed is missing.

> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
> ---
>  drivers/iio/proximity/as3935.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
> index 9aa2ce551ba8..692e9cda8ae0 100644
> --- a/drivers/iio/proximity/as3935.c
> +++ b/drivers/iio/proximity/as3935.c
> @@ -346,7 +346,6 @@ static int as3935_probe(struct spi_device *spi)
>  
>  	st = iio_priv(indio_dev);
>  	st->spi = spi;
> -	st->tune_cap = 0;
>  
>  	spi_set_drvdata(spi, indio_dev);
>  	mutex_init(&st->lock);
> 


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2016-06-17  1:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16  1:47 [PATCH] iio: proximity: as3935: remove redundant zeroing of tune_cap Matt Ranostay
2016-06-17  1:04 ` Marek Vasut [this message]
2016-06-26 16:20   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57634C9D.7090705@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=mranostay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox