Linux IIO development
 help / color / mirror / Atom feed
* [PATCH] iio: proximity: as3935: remove redundant zeroing of tune_cap
@ 2016-06-16  1:47 Matt Ranostay
  2016-06-17  1:04 ` Marek Vasut
  0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2016-06-16  1:47 UTC (permalink / raw)
  To: linux-iio; +Cc: jic23, Matt Ranostay

Signed-off-by: Matt Ranostay <mranostay@gmail.com>
---
 drivers/iio/proximity/as3935.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
index 9aa2ce551ba8..692e9cda8ae0 100644
--- a/drivers/iio/proximity/as3935.c
+++ b/drivers/iio/proximity/as3935.c
@@ -346,7 +346,6 @@ static int as3935_probe(struct spi_device *spi)
 
 	st = iio_priv(indio_dev);
 	st->spi = spi;
-	st->tune_cap = 0;
 
 	spi_set_drvdata(spi, indio_dev);
 	mutex_init(&st->lock);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: proximity: as3935: remove redundant zeroing of tune_cap
  2016-06-16  1:47 [PATCH] iio: proximity: as3935: remove redundant zeroing of tune_cap Matt Ranostay
@ 2016-06-17  1:04 ` Marek Vasut
  2016-06-26 16:20   ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2016-06-17  1:04 UTC (permalink / raw)
  To: Matt Ranostay, linux-iio; +Cc: jic23

On 06/16/2016 03:47 AM, Matt Ranostay wrote:

Commit message explaining what the patch does and why this patch is
needed is missing.

> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
> ---
>  drivers/iio/proximity/as3935.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
> index 9aa2ce551ba8..692e9cda8ae0 100644
> --- a/drivers/iio/proximity/as3935.c
> +++ b/drivers/iio/proximity/as3935.c
> @@ -346,7 +346,6 @@ static int as3935_probe(struct spi_device *spi)
>  
>  	st = iio_priv(indio_dev);
>  	st->spi = spi;
> -	st->tune_cap = 0;
>  
>  	spi_set_drvdata(spi, indio_dev);
>  	mutex_init(&st->lock);
> 


-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: proximity: as3935: remove redundant zeroing of tune_cap
  2016-06-17  1:04 ` Marek Vasut
@ 2016-06-26 16:20   ` Jonathan Cameron
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-06-26 16:20 UTC (permalink / raw)
  To: Marek Vasut, Matt Ranostay, linux-iio

On 17/06/16 02:04, Marek Vasut wrote:
> On 06/16/2016 03:47 AM, Matt Ranostay wrote:
> 
> Commit message explaining what the patch does and why this patch is
> needed is missing.
Applied with a note about why this is already 0 added to the commit
message.

Thanks,

Jonathan
> 
>> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
>> ---
>>  drivers/iio/proximity/as3935.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
>> index 9aa2ce551ba8..692e9cda8ae0 100644
>> --- a/drivers/iio/proximity/as3935.c
>> +++ b/drivers/iio/proximity/as3935.c
>> @@ -346,7 +346,6 @@ static int as3935_probe(struct spi_device *spi)
>>  
>>  	st = iio_priv(indio_dev);
>>  	st->spi = spi;
>> -	st->tune_cap = 0;
>>  
>>  	spi_set_drvdata(spi, indio_dev);
>>  	mutex_init(&st->lock);
>>
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-26 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-16  1:47 [PATCH] iio: proximity: as3935: remove redundant zeroing of tune_cap Matt Ranostay
2016-06-17  1:04 ` Marek Vasut
2016-06-26 16:20   ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox